From: sashiko-bot@kernel.org
To: pankaj.gupta@oss.nxp.com
Cc: imx@lists.linux.dev, devicetree@vger.kernel.org, robh@kernel.org,
Frank.Li@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v38 1/7] Documentation/firmware: add imx/se to other_interfaces
Date: Wed, 19 Aug 2026 13:20:08 +0000 [thread overview]
Message-ID: <20260819132009.4DC841F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260820-imx-se-if-v38-1-5df4a4cff736@nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch includes a `kernel-doc` directive for a file (`drivers/firmware/imx/se_ctrl.c`) that does not exist in the source tree at this revision.
--
--- Patch [1]: [PATCH v38 1/7] Documentation/firmware: add imx/se to other_interfaces ---
commit 9d7548655ebb737efce2e2011a588d419c6d261b
Author: Pankaj Gupta <pankaj.gupta@nxp.com>
Documentation/firmware: add imx/se to other_interfaces
This commit documents the i.MX SoC's Service layer and C_DEV driver for
selected SoCs containing NXP hardware IPs for Secure Enclaves.
> diff --git a/Documentation/driver-api/firmware/other_interfaces.rst b/Documentation/driver-api/firmware/other_interfaces.rst
> index 06ac89adaafba..6c6fa9a0ba1df 100644
> --- a/Documentation/driver-api/firmware/other_interfaces.rst
> +++ b/Documentation/driver-api/firmware/other_interfaces.rst
[ ... ]
> +When a user sends a command to the firmware, it registers its device_ctx
> +as waiter of a response from firmware.
> +
> +Enclave's Firmware owns the storage management over a Linux filesystem.
> +For this c_dev provisions a dedicated slave device called "receiver".
> +
> +.. kernel-doc:: drivers/firmware/imx/se_ctrl.c
> + :export:
[Severity: Low]
Does this file exist in the source tree at this revision? It appears that
building the htmldocs will generate warnings because
drivers/firmware/imx/se_ctrl.c is not present in the tree yet.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260820-imx-se-if-v38-0-5df4a4cff736@nxp.com?part=1
next prev parent reply other threads:[~2026-08-19 13:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 18:45 [PATCH v38 0/7] firmware: imx: driver for NXP secure-enclave pankaj.gupta
2026-08-19 18:45 ` [PATCH v38 1/7] Documentation/firmware: add imx/se to other_interfaces pankaj.gupta
2026-08-19 13:20 ` sashiko-bot [this message]
2026-08-19 18:45 ` [PATCH v38 2/7] dt-bindings: arm: fsl: add imx-se-fw binding doc pankaj.gupta
2026-08-19 18:45 ` [PATCH v38 3/7] firmware: imx: add driver for NXP EdgeLock Enclave pankaj.gupta
2026-08-19 13:30 ` sashiko-bot
2026-08-19 18:45 ` [PATCH v38 4/7] firmware: imx: device context dedicated to priv pankaj.gupta
2026-08-19 18:46 ` [PATCH v38 5/7] firmware: imx: adds miscdev pankaj.gupta
2026-08-19 13:30 ` sashiko-bot
2026-08-19 18:46 ` [PATCH v38 6/7] arm64: dts: imx8ulp: add secure enclave node pankaj.gupta
2026-08-19 13:23 ` sashiko-bot
2026-08-19 18:46 ` [PATCH v38 7/7] arm64: dts: imx8ulp: add reserved memory for EdgeLock Enclave pankaj.gupta
2026-08-19 13:33 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260819132009.4DC841F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=pankaj.gupta@oss.nxp.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.