From: Thierry Chatard <tchatard@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: hansg@kernel.org, lee@kernel.org,
platform-driver-x86@vger.kernel.org,
ilpo.jarvinen@linux.intel.com, djrscally@gmail.com,
linux-media@vger.kernel.org, mchehab@kernel.org,
sakari.ailus@linux.intel.com, jacopo.mondi@ideasonboard.com,
nicholas@rothemail.net, andriy.shevchenko@intel.com,
v.vitovt@gmail.com, Thierry Chatard <tchatard@gmail.com>
Subject: [PATCH v7 0/5] Enable cameras on Dell Latitude 5285 2-in-1
Date: Wed, 19 Aug 2026 16:01:02 +0200 [thread overview]
Message-ID: <20260819140107.1329091-1-tchatard@gmail.com> (raw)
In-Reply-To: <ae8U0JBdSaPgU-Zl@kekkonen.localdomain>
This series enables the front (OV5670/INT3479) and rear (OV8858/INT3477)
cameras on the Dell Latitude 5285 2-in-1 under Linux.
I prepared this v7 at the end of April, then went on vacation in May and
forgot to send it out - apologies for the long gap since the v6 review.
Nothing has changed since then apart from the v6 review fixes listed below.
Per Documentation/process/coding-assistants.rst, and following up on Sakari's
question during the v6 review: this work was developed with significant help
from an AI coding assistant (Claude Code, by Anthropic). I used it to help
reverse-engineer the ACPI/TPS68470 bring-up, iterate on the board data, and
draft these patches. I have reviewed and tested all of it on the actual
hardware and take full responsibility for the result.
Changes since v6 (addressing feedback from Sakari Ailus and Hans de Goede):
- Patch 2: Move board_data lookup and clk_pdata setup to after the
device-type switch, so they are only reached on the Windows path.
- Patch 5: Revert the supply name reorder (avdd, dvdd, dovdd ->
avdd, dovdd, dvdd); regulator_bulk_enable() does not guarantee enable
ordering between supplies, so the reorder had no functional effect.
Remove the now-stale paragraph from the commit message.
Changes since v5:
- Patch 2: Use a local 'tables' pointer before the gpiod_add/remove_
lookup_table() loops so that neither call ends with a bare '(' (fixes
checkpatch CHECK reported by the Media CI robot).
Also restore the missing VSIO->avdd consumer for INT3479 (OV5670):
the v4 refactor dropped this entry, leaving OV5670 without its analog
supply and causing -EIO from ov5670_identify_module().
Changes since v4 (addressing feedback from Sakari Ailus):
- Patch 1: Drop the data == &spt_i2c_info guard from the probe condition;
the HID (INT3446) + DMI check is already precise enough.
- Patch 2: Revert n_consumers back to int (unsigned int broke the
if (n_consumers < 0) error check on skl_int3472_fill_clk_pdata());
restructure probe so ChromeOS and error cases return early from the
switch and the Windows path follows as straight-line code after it.
- Patch 3: Correct the VIO description in the commit message and code
comment; drop the inaccurate "no enable register" claim and instead
document why VIO is kept always_on (voltage must match VSIO, no direct
consumers).
- Patch 5: Drop the paragraph explaining the VSIO->dovdd mapping from
the commit message (implementation detail belonging in patch 3);
add an explanation for the dvdd/dovdd reorder in supply_names (core
power stable before the I2C passthrough opens).
- Patch 4: Unchanged.
Tested on Ubuntu 25.10 (kernel 6.17.0-22-generic) and Ubuntu 26.04
(kernel 7.0.0-28-generic). Both cameras working in Zoom, Chrome, and
GNOME Camera via PipeWire.
This approach has also been independently tested on the closely-related Dell
Latitude 5290 2-in-1 (same IPU3/TPS68470/OV5670/OV8858/DW9714 stack) by
Vitalii Tytskyi, who got both cameras working across boot and suspend/resume
with additional 5290 board data, and who separately identified a
hibernate-restore fix for the TPS68470. Dell 5290 board data and that
hibernate fix can follow as a separate series on top of this one:
https://github.com/vitovt/dell-5290-camera-kernel/tree/master/patches
Thierry Chatard (5):
platform/x86: intel_lpss: add resource conflict quirk for Dell Latitude 5285
platform/x86: int3472: tps68470: fix clock consumer registration for Dell Latitude 5285
platform/x86: int3472: tps68470: add board data for Dell Latitude 5285
media: ipu-bridge: add sensor configuration for OV8858 (INT3477)
media: ov8858: add ACPI device ID INT3477
next prev parent reply other threads:[~2026-08-19 14:01 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 0:09 [PATCH 0/5] Enable dual cameras on Dell Latitude 5285 2-in-1 Thierry Chatard
2026-03-20 0:09 ` [PATCH 1/5] platform/x86: intel_lpss: add resource conflict quirk for Dell Latitude 5285 Thierry Chatard
2026-04-29 9:29 ` Andy Shevchenko
2026-03-20 0:09 ` [PATCH 2/5] platform/x86: int3472: tps68470: fix GNVS clock fields " Thierry Chatard
2026-03-21 9:44 ` kernel test robot
2026-03-20 0:09 ` [PATCH 3/5] platform/x86: int3472: tps68470: add board data " Thierry Chatard
2026-03-20 0:09 ` [PATCH 4/5] media: ipu-bridge: add sensor configuration for OV8858 (INT3477) Thierry Chatard
2026-03-20 0:09 ` [PATCH 5/5] media: ov8858: add ACPI device ID INT3477 and vsio power supply Thierry Chatard
2026-03-24 21:41 ` [PATCH v2 0/5] Enable dual cameras on Dell Latitude 5285 2-in-1 Thierry Chatard
2026-03-24 21:41 ` [PATCH v2 1/3] platform/x86: intel_lpss: add resource conflict quirk for Dell Latitude 5285 Thierry Chatard
2026-04-13 9:48 ` Hans de Goede
2026-03-24 21:41 ` [PATCH v2 2/3] platform/x86: int3472: tps68470: fix GNVS clock fields " Thierry Chatard
2026-04-13 11:02 ` Hans de Goede
2026-04-17 16:32 ` [PATCH v3 0/5] Enable cameras on Dell Latitude 5285 2-in-1 Thierry Chatard
2026-04-17 16:32 ` [PATCH v3 1/5] platform/x86: intel_lpss: add resource conflict quirk for Dell Latitude 5285 Thierry Chatard
2026-04-17 17:35 ` Hans de Goede
2026-04-18 6:31 ` Sakari Ailus
2026-04-17 16:32 ` [PATCH v3 2/5] platform/x86: int3472: tps68470: fix clock consumer registration " Thierry Chatard
2026-04-17 17:40 ` Hans de Goede
2026-04-18 6:29 ` Sakari Ailus
2026-04-17 16:32 ` [PATCH v3 3/5] platform/x86: int3472: tps68470: add board data " Thierry Chatard
2026-04-17 18:54 ` Hans de Goede
2026-04-18 7:16 ` Sakari Ailus
2026-04-21 22:52 ` [PATCH v4 0/5] Enable cameras on Dell Latitude 5285 2-in-1 Thierry Chatard
2026-04-21 22:52 ` [PATCH v4 1/5] platform/x86: intel_lpss: add resource conflict quirk for Dell Latitude 5285 Thierry Chatard
2026-04-22 6:54 ` Sakari Ailus
2026-04-21 22:52 ` [PATCH v4 2/5] platform/x86: int3472: tps68470: fix clock consumer registration " Thierry Chatard
2026-04-22 7:07 ` Sakari Ailus
2026-04-25 5:13 ` [PATCH v5 0/5] Enable cameras on Dell Latitude 5285 2-in-1 Thierry Chatard
2026-04-25 5:13 ` [PATCH v5 1/5] platform/x86: intel_lpss: add resource conflict quirk for Dell Latitude 5285 Thierry Chatard
2026-04-25 5:13 ` [PATCH v5 2/5] platform/x86: int3472: tps68470: fix clock consumer registration " Thierry Chatard
2026-04-25 5:13 ` [PATCH v5 3/5] platform/x86: int3472: tps68470: add board data " Thierry Chatard
2026-04-25 5:13 ` [PATCH v5 4/5] media: ipu-bridge: add sensor configuration for OV8858 (INT3477) Thierry Chatard
2026-04-25 5:13 ` [PATCH v5 5/5] media: ov8858: add ACPI device ID INT3477 Thierry Chatard
2026-04-25 16:31 ` [PATCH v6 0/5] Enable cameras on Dell Latitude 5285 2-in-1 Thierry Chatard
2026-04-25 16:31 ` [PATCH v6 1/5] platform/x86: intel_lpss: add resource conflict quirk for Dell Latitude 5285 Thierry Chatard
2026-04-25 16:31 ` [PATCH v6 2/5] platform/x86: int3472: tps68470: fix clock consumer registration " Thierry Chatard
2026-04-27 7:48 ` Sakari Ailus
2026-08-19 14:01 ` Thierry Chatard [this message]
2026-08-19 14:01 ` [PATCH v7 1/5] platform/x86: intel_lpss: add resource conflict quirk " Thierry Chatard
2026-08-19 18:43 ` Andy Shevchenko
2026-08-19 14:01 ` [PATCH v7 2/5] platform/x86: int3472: tps68470: fix clock consumer registration " Thierry Chatard
2026-08-19 14:01 ` [PATCH v7 3/5] platform/x86: int3472: tps68470: add board data " Thierry Chatard
2026-08-19 14:01 ` [PATCH v7 4/5] media: ipu-bridge: add sensor configuration for OV8858 (INT3477) Thierry Chatard
2026-08-19 14:01 ` [PATCH v7 5/5] media: ov8858: add ACPI device ID INT3477 Thierry Chatard
2026-04-25 16:31 ` [PATCH v6 3/5] platform/x86: int3472: tps68470: add board data for Dell Latitude 5285 Thierry Chatard
2026-04-25 16:31 ` [PATCH v6 4/5] media: ipu-bridge: add sensor configuration for OV8858 (INT3477) Thierry Chatard
2026-04-25 16:31 ` [PATCH v6 5/5] media: ov8858: add ACPI device ID INT3477 Thierry Chatard
2026-04-27 7:49 ` Sakari Ailus
2026-04-27 12:06 ` Hans de Goede
2026-04-21 22:52 ` [PATCH v4 3/5] platform/x86: int3472: tps68470: add board data for Dell Latitude 5285 Thierry Chatard
2026-04-22 7:11 ` Sakari Ailus
2026-04-22 7:13 ` Sakari Ailus
2026-04-21 22:52 ` [PATCH v4 4/5] media: ipu-bridge: add sensor configuration for OV8858 (INT3477) Thierry Chatard
2026-04-21 22:52 ` [PATCH v4 5/5] media: ov8858: add ACPI device ID INT3477 Thierry Chatard
2026-04-22 7:15 ` Sakari Ailus
2026-04-17 16:32 ` [PATCH v3 4/5] media: ipu-bridge: add sensor configuration for OV8858 (INT3477) Thierry Chatard
2026-04-17 18:56 ` Hans de Goede
2026-04-18 7:18 ` Sakari Ailus
2026-04-17 16:32 ` [PATCH v3 5/5] media: ov8858: add ACPI device ID INT3477 and vsio power supply Thierry Chatard
2026-04-17 18:59 ` Hans de Goede
2026-04-17 16:35 ` [PATCH v2 2/3] platform/x86: int3472: tps68470: fix GNVS clock fields for Dell Latitude 5285 tchatard
2026-03-24 21:41 ` [PATCH v2 3/3] platform/x86: int3472: tps68470: add board data " Thierry Chatard
2026-03-24 21:41 ` [PATCH v2 4/5] media: ipu-bridge: add sensor configuration for OV8858 (INT3477) Thierry Chatard
2026-03-24 21:41 ` [PATCH v2 5/5] media: ov8858: add ACPI device ID INT3477 and vsio power supply Thierry Chatard
2026-04-13 9:45 ` [PATCH v2 0/5] Enable dual cameras on Dell Latitude 5285 2-in-1 Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260819140107.1329091-1-tchatard@gmail.com \
--to=tchatard@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=djrscally@gmail.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicholas@rothemail.net \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=v.vitovt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.