diff for duplicates of <202608191405.jP6epa63-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index a31f2c0..54a3f74 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,14 +1,6 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -CC: linux-arm-kernel@lists.infradead.org -CC: arm@kernel.org -TO: Arnd Bergmann <arnd@arndb.de> - tree: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git board-remove head: c12d647b0229f4d75a2973c9b4e79f9b53406426 commit: c12d647b0229f4d75a2973c9b4e79f9b53406426 [200/200] remaining pdata removal -:::::: branch date: 16 hours ago -:::::: commit date: 16 hours ago config: parisc-randconfig-r073-20260819 (https://download.01.org/0day-ci/archive/20260819/202608191405.jP6epa63-lkp@intel.com/config) compiler: hppa-linux-gcc (GCC) 8.5.0 smatch: v0.5.0-9187-g5189e3fb @@ -24,32 +16,6 @@ drivers/mmc/host/sdhci-pxav2.c:318 sdhci_pxav2_probe() error: we previously assu vim +/variant +318 drivers/mmc/host/sdhci-pxav2.c -b650352dd3df36 Chris Ball 2012-04-10 269 -c3be1efd41a97f Bill Pemberton 2012-11-19 270 static int sdhci_pxav2_probe(struct platform_device *pdev) -9f5d71e4a78a02 Zhangfei Gao 2011-06-08 271 { -9f5d71e4a78a02 Zhangfei Gao 2011-06-08 272 struct sdhci_pltfm_host *pltfm_host; -c12d647b0229f4 Arnd Bergmann 2026-08-07 273 struct sdhci_pxa_platdata *pdata; -f35ca223882aa6 Doug Brown 2023-01-16 274 struct sdhci_pxav2_host *pxav2_host; -9f5d71e4a78a02 Zhangfei Gao 2011-06-08 275 struct device *dev = &pdev->dev; -9f5d71e4a78a02 Zhangfei Gao 2011-06-08 276 struct sdhci_host *host = NULL; -dfe9746aed2d12 Doug Brown 2023-01-16 277 const struct sdhci_pxa_variant *variant; -b650352dd3df36 Chris Ball 2012-04-10 278 -e41c48b4bcb3ce Doug Brown 2023-01-16 279 struct clk *clk, *clk_core; -9f5d71e4a78a02 Zhangfei Gao 2011-06-08 280 -f35ca223882aa6 Doug Brown 2023-01-16 281 host = sdhci_pltfm_init(pdev, NULL, sizeof(*pxav2_host)); -6a686c31324c9e Sebastian Hesselbarth 2014-10-21 282 if (IS_ERR(host)) -9f5d71e4a78a02 Zhangfei Gao 2011-06-08 283 return PTR_ERR(host); -6a686c31324c9e Sebastian Hesselbarth 2014-10-21 284 -9f5d71e4a78a02 Zhangfei Gao 2011-06-08 285 pltfm_host = sdhci_priv(host); -f35ca223882aa6 Doug Brown 2023-01-16 286 pxav2_host = sdhci_pltfm_priv(pltfm_host); -9f5d71e4a78a02 Zhangfei Gao 2011-06-08 287 -c21f1b0dc6418e Adrian Hunter 2023-08-11 288 clk = devm_clk_get_optional_enabled(dev, "io"); -c21f1b0dc6418e Adrian Hunter 2023-08-11 289 if (!clk) -c21f1b0dc6418e Adrian Hunter 2023-08-11 290 clk = devm_clk_get_enabled(dev, NULL); -072f5e2c34a95b Binbin Zhou 2025-06-07 291 if (IS_ERR(clk)) -072f5e2c34a95b Binbin Zhou 2025-06-07 292 return dev_err_probe(dev, PTR_ERR(clk), "failed to get io clock\n"); -9f5d71e4a78a02 Zhangfei Gao 2011-06-08 293 pltfm_host->clk = clk; -9f5d71e4a78a02 Zhangfei Gao 2011-06-08 294 e41c48b4bcb3ce Doug Brown 2023-01-16 295 clk_core = devm_clk_get_optional_enabled(dev, "core"); 072f5e2c34a95b Binbin Zhou 2025-06-07 296 if (IS_ERR(clk_core)) 072f5e2c34a95b Binbin Zhou 2025-06-07 297 return dev_err_probe(dev, PTR_ERR(clk_core), @@ -61,6 +27,9 @@ e41c48b4bcb3ce Doug Brown 2023-01-16 299 9f5d71e4a78a02 Zhangfei Gao 2011-06-08 303 dfe9746aed2d12 Doug Brown 2023-01-16 304 variant = of_device_get_match_data(dev); dfe9746aed2d12 Doug Brown 2023-01-16 @305 if (variant) + +This assumes "variant" can be NULL. + b650352dd3df36 Chris Ball 2012-04-10 306 pdata = pxav2_get_mmc_pdata(dev); dfe9746aed2d12 Doug Brown 2023-01-16 307 9f5d71e4a78a02 Zhangfei Gao 2011-06-08 308 if (pdata->flags & PXA_FLAG_CARD_PERMANENT) { @@ -75,6 +44,9 @@ dfe9746aed2d12 Doug Brown 2023-01-16 307 9f5d71e4a78a02 Zhangfei Gao 2011-06-08 317 dfe9746aed2d12 Doug Brown 2023-01-16 @318 host->quirks |= variant->extra_quirks; dfe9746aed2d12 Doug Brown 2023-01-16 319 host->ops = variant->ops; + +But later it's dereferenced without checking. + 9f5d71e4a78a02 Zhangfei Gao 2011-06-08 320 f35ca223882aa6 Doug Brown 2023-01-16 321 /* Set up optional pinctrl for PXA168 SDIO IRQ fix */ f35ca223882aa6 Doug Brown 2023-01-16 322 pxav2_host->pinctrl = devm_pinctrl_get(dev); @@ -83,23 +55,6 @@ f35ca223882aa6 Doug Brown 2023-01-16 324 pxav2_host->pins_cmd_gpi f35ca223882aa6 Doug Brown 2023-01-16 325 "state_cmd_gpio"); f35ca223882aa6 Doug Brown 2023-01-16 326 if (IS_ERR(pxav2_host->pins_cmd_gpio)) f35ca223882aa6 Doug Brown 2023-01-16 327 pxav2_host->pins_cmd_gpio = NULL; -f35ca223882aa6 Doug Brown 2023-01-16 328 pxav2_host->pins_default = pinctrl_lookup_state(pxav2_host->pinctrl, -f35ca223882aa6 Doug Brown 2023-01-16 329 "default"); -f35ca223882aa6 Doug Brown 2023-01-16 330 if (IS_ERR(pxav2_host->pins_default)) -f35ca223882aa6 Doug Brown 2023-01-16 331 pxav2_host->pins_default = NULL; -f35ca223882aa6 Doug Brown 2023-01-16 332 } else { -f35ca223882aa6 Doug Brown 2023-01-16 333 pxav2_host->pinctrl = NULL; -f35ca223882aa6 Doug Brown 2023-01-16 334 } -f35ca223882aa6 Doug Brown 2023-01-16 335 -072f5e2c34a95b Binbin Zhou 2025-06-07 336 return sdhci_add_host(host); -9f5d71e4a78a02 Zhangfei Gao 2011-06-08 337 } -9f5d71e4a78a02 Zhangfei Gao 2011-06-08 338 - -:::::: The code at line 318 was first introduced by commit -:::::: dfe9746aed2d1267f00b880ae232170d7d9e4202 mmc: sdhci-pxav2: add initial support for PXA168 V1 controller - -:::::: TO: Doug Brown <doug@schmorgal.com> -:::::: CC: Ulf Hansson <ulf.hansson@linaro.org> -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index 30dc7fb..98a6d57 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,22 +1,17 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0[soc:board-remove 200/200] drivers/mmc/host/sdhci-pxav2.c:318 sdhci_pxav2_probe() error: we previously assumed 'variant' could be null (see line 305)\0" - "Date\0Wed, 19 Aug 2026 14:42:21 +0800\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Wed, 19 Aug 2026 10:54:24 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + " Arnd Bergmann <arnd@arndb.de>\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + oe-kbuild-all@lists.linux.dev + linux-arm-kernel@lists.infradead.org + " arm@kernel.org\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "CC: linux-arm-kernel@lists.infradead.org\n" - "CC: arm@kernel.org\n" - "TO: Arnd Bergmann <arnd@arndb.de>\n" - "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git board-remove\n" "head: c12d647b0229f4d75a2973c9b4e79f9b53406426\n" "commit: c12d647b0229f4d75a2973c9b4e79f9b53406426 [200/200] remaining pdata removal\n" - ":::::: branch date: 16 hours ago\n" - ":::::: commit date: 16 hours ago\n" "config: parisc-randconfig-r073-20260819 (https://download.01.org/0day-ci/archive/20260819/202608191405.jP6epa63-lkp@intel.com/config)\n" "compiler: hppa-linux-gcc (GCC) 8.5.0\n" "smatch: v0.5.0-9187-g5189e3fb\n" @@ -32,32 +27,6 @@ "\n" "vim +/variant +318 drivers/mmc/host/sdhci-pxav2.c\n" "\n" - "b650352dd3df36 Chris Ball 2012-04-10 269 \n" - "c3be1efd41a97f Bill Pemberton 2012-11-19 270 static int sdhci_pxav2_probe(struct platform_device *pdev)\n" - "9f5d71e4a78a02 Zhangfei Gao 2011-06-08 271 {\n" - "9f5d71e4a78a02 Zhangfei Gao 2011-06-08 272 \tstruct sdhci_pltfm_host *pltfm_host;\n" - "c12d647b0229f4 Arnd Bergmann 2026-08-07 273 \tstruct sdhci_pxa_platdata *pdata;\n" - "f35ca223882aa6 Doug Brown 2023-01-16 274 \tstruct sdhci_pxav2_host *pxav2_host;\n" - "9f5d71e4a78a02 Zhangfei Gao 2011-06-08 275 \tstruct device *dev = &pdev->dev;\n" - "9f5d71e4a78a02 Zhangfei Gao 2011-06-08 276 \tstruct sdhci_host *host = NULL;\n" - "dfe9746aed2d12 Doug Brown 2023-01-16 277 \tconst struct sdhci_pxa_variant *variant;\n" - "b650352dd3df36 Chris Ball 2012-04-10 278 \n" - "e41c48b4bcb3ce Doug Brown 2023-01-16 279 \tstruct clk *clk, *clk_core;\n" - "9f5d71e4a78a02 Zhangfei Gao 2011-06-08 280 \n" - "f35ca223882aa6 Doug Brown 2023-01-16 281 \thost = sdhci_pltfm_init(pdev, NULL, sizeof(*pxav2_host));\n" - "6a686c31324c9e Sebastian Hesselbarth 2014-10-21 282 \tif (IS_ERR(host))\n" - "9f5d71e4a78a02 Zhangfei Gao 2011-06-08 283 \t\treturn PTR_ERR(host);\n" - "6a686c31324c9e Sebastian Hesselbarth 2014-10-21 284 \n" - "9f5d71e4a78a02 Zhangfei Gao 2011-06-08 285 \tpltfm_host = sdhci_priv(host);\n" - "f35ca223882aa6 Doug Brown 2023-01-16 286 \tpxav2_host = sdhci_pltfm_priv(pltfm_host);\n" - "9f5d71e4a78a02 Zhangfei Gao 2011-06-08 287 \n" - "c21f1b0dc6418e Adrian Hunter 2023-08-11 288 \tclk = devm_clk_get_optional_enabled(dev, \"io\");\n" - "c21f1b0dc6418e Adrian Hunter 2023-08-11 289 \tif (!clk)\n" - "c21f1b0dc6418e Adrian Hunter 2023-08-11 290 \t\tclk = devm_clk_get_enabled(dev, NULL);\n" - "072f5e2c34a95b Binbin Zhou 2025-06-07 291 \tif (IS_ERR(clk))\n" - "072f5e2c34a95b Binbin Zhou 2025-06-07 292 \t\treturn dev_err_probe(dev, PTR_ERR(clk), \"failed to get io clock\\n\");\n" - "9f5d71e4a78a02 Zhangfei Gao 2011-06-08 293 \tpltfm_host->clk = clk;\n" - "9f5d71e4a78a02 Zhangfei Gao 2011-06-08 294 \n" "e41c48b4bcb3ce Doug Brown 2023-01-16 295 \tclk_core = devm_clk_get_optional_enabled(dev, \"core\");\n" "072f5e2c34a95b Binbin Zhou 2025-06-07 296 \tif (IS_ERR(clk_core))\n" "072f5e2c34a95b Binbin Zhou 2025-06-07 297 \t\treturn dev_err_probe(dev, PTR_ERR(clk_core),\n" @@ -69,6 +38,9 @@ "9f5d71e4a78a02 Zhangfei Gao 2011-06-08 303 \n" "dfe9746aed2d12 Doug Brown 2023-01-16 304 \tvariant = of_device_get_match_data(dev);\n" "dfe9746aed2d12 Doug Brown 2023-01-16 @305 \tif (variant)\n" + "\n" + "This assumes \"variant\" can be NULL.\n" + "\n" "b650352dd3df36 Chris Ball 2012-04-10 306 \t\tpdata = pxav2_get_mmc_pdata(dev);\n" "dfe9746aed2d12 Doug Brown 2023-01-16 307 \n" "9f5d71e4a78a02 Zhangfei Gao 2011-06-08 308 \tif (pdata->flags & PXA_FLAG_CARD_PERMANENT) {\n" @@ -83,6 +55,9 @@ "9f5d71e4a78a02 Zhangfei Gao 2011-06-08 317 \n" "dfe9746aed2d12 Doug Brown 2023-01-16 @318 \thost->quirks |= variant->extra_quirks;\n" "dfe9746aed2d12 Doug Brown 2023-01-16 319 \thost->ops = variant->ops;\n" + "\n" + "But later it's dereferenced without checking.\n" + "\n" "9f5d71e4a78a02 Zhangfei Gao 2011-06-08 320 \n" "f35ca223882aa6 Doug Brown 2023-01-16 321 \t/* Set up optional pinctrl for PXA168 SDIO IRQ fix */\n" "f35ca223882aa6 Doug Brown 2023-01-16 322 \tpxav2_host->pinctrl = devm_pinctrl_get(dev);\n" @@ -91,26 +66,9 @@ "f35ca223882aa6 Doug Brown 2023-01-16 325 \t\t\t\t\t\t\t\t \"state_cmd_gpio\");\n" "f35ca223882aa6 Doug Brown 2023-01-16 326 \t\tif (IS_ERR(pxav2_host->pins_cmd_gpio))\n" "f35ca223882aa6 Doug Brown 2023-01-16 327 \t\t\tpxav2_host->pins_cmd_gpio = NULL;\n" - "f35ca223882aa6 Doug Brown 2023-01-16 328 \t\tpxav2_host->pins_default = pinctrl_lookup_state(pxav2_host->pinctrl,\n" - "f35ca223882aa6 Doug Brown 2023-01-16 329 \t\t\t\t\t\t\t\t\"default\");\n" - "f35ca223882aa6 Doug Brown 2023-01-16 330 \t\tif (IS_ERR(pxav2_host->pins_default))\n" - "f35ca223882aa6 Doug Brown 2023-01-16 331 \t\t\tpxav2_host->pins_default = NULL;\n" - "f35ca223882aa6 Doug Brown 2023-01-16 332 \t} else {\n" - "f35ca223882aa6 Doug Brown 2023-01-16 333 \t\tpxav2_host->pinctrl = NULL;\n" - "f35ca223882aa6 Doug Brown 2023-01-16 334 \t}\n" - "f35ca223882aa6 Doug Brown 2023-01-16 335 \n" - "072f5e2c34a95b Binbin Zhou 2025-06-07 336 \treturn sdhci_add_host(host);\n" - "9f5d71e4a78a02 Zhangfei Gao 2011-06-08 337 }\n" - "9f5d71e4a78a02 Zhangfei Gao 2011-06-08 338 \n" - "\n" - ":::::: The code at line 318 was first introduced by commit\n" - ":::::: dfe9746aed2d1267f00b880ae232170d7d9e4202 mmc: sdhci-pxav2: add initial support for PXA168 V1 controller\n" - "\n" - ":::::: TO: Doug Brown <doug@schmorgal.com>\n" - ":::::: CC: Ulf Hansson <ulf.hansson@linaro.org>\n" "\n" "--\n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -5b3ce55430a0a85e9e0bfb8fbd44b9e4611b796dde11b97164d4023033f9c5f9 +817e63441edd6f16047b9f5c9ef3c685605cd7651ce3b1709268b43a634e47cc
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.