From: Fabiano Rosas <farosas@suse.de>
To: qemu-devel@nongnu.org
Cc: Rohitashv Kumar <roohiit@amazon.de>
Subject: [PULL 4/4] tests/qtest/pxe-test: skip per-row cases whose machine is unavailable
Date: Wed, 19 Aug 2026 11:31:52 -0300 [thread overview]
Message-ID: <20260819143152.1541266-5-farosas@suse.de> (raw)
In-Reply-To: <20260819143152.1541266-1-farosas@suse.de>
From: Rohitashv Kumar <roohiit@amazon.de>
The x86 test table mixes 'pc' and 'q35' rows. When QEMU is built without
the i440fx/pc machine, the 'pc' rows fail with "unsupported machine type".
Add a per-row qtest_has_machine() check in test_batch(), mirroring the
existing per-row qtest_has_device() guard, so rows for an unavailable
machine are skipped while the others (e.g. q35) still run.
Signed-off-by: Rohitashv Kumar <roohiit@amazon.de>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
tests/qtest/pxe-test.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/qtest/pxe-test.c b/tests/qtest/pxe-test.c
index a3f900fbea3..e85dec5a4e1 100644
--- a/tests/qtest/pxe-test.c
+++ b/tests/qtest/pxe-test.c
@@ -108,6 +108,10 @@ static void test_batch(const testdef_t *tests, bool ipv6)
const testdef_t *test = &tests[i];
char *testname;
+ if (!qtest_has_machine(test->machine)) {
+ continue;
+ }
+
if (!qtest_has_device(test->model)) {
continue;
}
--
2.53.0
next prev parent reply other threads:[~2026-08-19 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 14:31 [PULL 0/4] Qtest patches for 2026-08-19 Fabiano Rosas
2026-08-19 14:31 ` [PULL 1/4] tests/qtest/libqtest: Use GLib functions for proper const correctness Fabiano Rosas
2026-08-19 14:31 ` [PULL 2/4] tests/qtest/device-plug-test: skip pc tests when 'pc' machine is unavailable Fabiano Rosas
2026-08-19 14:31 ` [PULL 3/4] tests/qtest/drive_del-test: " Fabiano Rosas
2026-08-19 14:31 ` Fabiano Rosas [this message]
2026-08-19 19:57 ` [PULL 0/4] Qtest patches for 2026-08-19 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260819143152.1541266-5-farosas@suse.de \
--to=farosas@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=roohiit@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.