Re: [PATCH v2 1/2] dt-bindings: gpio: otto-gpio: Add gpio-ranges

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Logical contradiction in JSON schema makes the `realtek,rtl9607-gpio` binding un-satisfiable.
--

--- Patch [1]: [PATCH v2 1/2] dt-bindings: gpio: otto-gpio: Add gpio-ranges ---
commit dc172e5a62e85037c013247864994cd4ea3bc026
Author: misha.zavertkin@mail.ru <misha.zavertkin@mail.ru>

dt-bindings: gpio: otto-gpio: Add gpio-ranges

This commit updates the realtek,otto-gpio binding documentation to add
support for the gpio-ranges property. It specifically requires this
property to be present when the realtek,rtl9607-gpio compatible string is
used to ensure proper pinctrl routing.

> diff --git a/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml b/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml
> index b18f8f0ca0ae4..96396f968e788 100644
> --- a/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml
> @@ -40,6 +40,8 @@ properties:
>  
>    gpio-controller: true
>  
> +  gpio-ranges: false
> +

[ ... ]

> @@ -75,6 +77,18 @@ required:
>    - "#gpio-cells"
>    - gpio-controller
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: realtek,rtl9607-gpio
> +    then:
> +      properties:
> +        gpio-ranges: true
> +      required:
> +        - gpio-ranges

[Severity: Medium]
Does this create a logical contradiction that makes the schema unsatisfiable
for the realtek,rtl9607-gpio compatible string?

Because gpio-ranges is defined as false in the top-level properties list,
it unconditionally forbids the property. However, the new allOf conditional
block requires the exact same gpio-ranges property to be present.

Will this cause device tree validation to fail every time? If the property
is present, it would fail the top-level false constraint, and if it is
omitted, it would fail the required constraint in the conditional block.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1787130560.git.misha.zavertkin@mail.ru?part=1