All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Perez de Castro <aperez@igalia.com>
To: Thomas Devoogdt <thomas@devoogdt.com>
Cc: buildroot@buildroot.org, Thomas Devoogdt <thomas@devoogdt.com>
Subject: Re: [Buildroot] [PATCH] package/webkitgtk: fix wrong config option
Date: Wed, 19 Aug 2026 16:35:41 +0200	[thread overview]
Message-ID: <20260819163541.GF771367@igalia.com> (raw)
In-Reply-To: <20260819123811.420995-1-thomas@devoogdt.com>


[-- Attachment #1.1: Type: text/plain, Size: 1133 bytes --]

Hi Thomas,

Good catch!

On Wed, 19 Aug 2026 14:38:11 +0200 Thomas Devoogdt <thomas@devoogdt.com> wrote:
> Commit 713d63b "package/webkitgtk: add option to enable MiniBrowser",
> added support to select BR2_PACKAGE_WEBKITGTK_MINIBROWSER, but forgot
> to drop the default -DENABLE_MINIBROWSER=ON entry.
> 
> Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

Acked-By: Adrian Perez de Castro <aperez@igalia.com>

> ---
>  package/webkitgtk/webkitgtk.mk | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
> index 6cab2c6a247..ee9e707cb55 100644
> --- a/package/webkitgtk/webkitgtk.mk
> +++ b/package/webkitgtk/webkitgtk.mk
> @@ -27,7 +27,6 @@ WEBKITGTK_CONF_OPTS = \
>  	-DENABLE_API_TESTS=OFF \
>  	-DENABLE_DOCUMENTATION=OFF \
>  	-DENABLE_GEOLOCATION=OFF \
> -	-DENABLE_MINIBROWSER=ON \
>  	-DENABLE_SPELLCHECK=ON \
>  	-DENABLE_WEB_RTC=OFF \
>  	-DPORT=GTK \
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

Cheers,
—Adrián

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-08-19 14:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19 12:38 [Buildroot] [PATCH] package/webkitgtk: fix wrong config option Thomas Devoogdt
2026-08-19 14:35 ` Adrian Perez de Castro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260819163541.GF771367@igalia.com \
    --to=aperez@igalia.com \
    --cc=buildroot@buildroot.org \
    --cc=thomas@devoogdt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.