From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 432E7C5DF85 for ; Wed, 19 Aug 2026 19:13:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wp7smuyx4cqmmE3S8sV9+nPIKOCFX9muTMFnxC5Hi4I=; b=1ixLZJQFxbSw/n xSQ/UrvXPWlSsxNBXhK9FIP25ngCLWXi8k9ml7mK5g6RvlTqCPLRtWAYnMJH0vOmC02pF52awdoHK eyaXGs0JoTbUyD4n0OlShr2dAM4yIkpy+7DhG5dNJHwU5hNl7dpiJ/SRjn3aMYFpPVbrZm8EnV1GX JVhQ4ihhRQsUamGH67g2ZsCGGWeE5aMOwdRjwJ9zdsB2ifiP/gnYW8+27C6B69jqtReQNFu0OOAom cr0r3CzU+zn7h7NikEXvBlStpL6O2SrX0xabk+knkWRk0ZojZ8SsBSiMzbCorTL+aX5aOAa4aWUeg sAYmj/ZqPol+bDsKQOGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wwliw-0000000AR4K-21Zu; Wed, 19 Aug 2026 19:13:18 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wwliv-0000000AR3t-1MLJ for linux-amlogic@lists.infradead.org; Wed, 19 Aug 2026 19:13:17 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id D78F7413CA; Wed, 19 Aug 2026 19:13:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F2F21F000E9; Wed, 19 Aug 2026 19:13:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787166796; bh=7QPB8xntRosfEaEsyywjE8Y9e9e7wAx1p25F0kiuc9I=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=avFL27vf7uiDuhOHLuxB/2oCnPMbgPs124dXFVRT5tHaeRQQCP2+ZifxIXNr163q2 0WmOepLH205z65+O10bAs3Vs3o9P+7gMNQJSoER6EPsgVcLrdvg9AhHM25vpQD4TBn D7zzhY7iNTS25TLnTyPGlM0Z4ugnBZLe/UkucPfZmSjQD/DjwXn/VGH6WULFwtEIqd EFe19QZUf3E8F9SDthfUMIVl4MrNFn1LFrQWoxUh1S95SvS5g3u+Zl9n2ksOSMqwqs sL+XArbeCt8QqsqbIfzmhN/qwKpv/2F7M5AtiFK/Vj7pwf0IXIJozlH7biGZyhTfLL pmeSDzXiC4yUQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH treewide 4/5] iio: frequency: adf4377: Make sure clk_init_data is fully initialized To: "Geert Uytterhoeven" Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, neil.armstrong@linaro.org, linux-hwmon@vger.kernel.org In-Reply-To: <302584628c4c0699239a0218376fe1c11cdc8944.1787165329.git.geert+renesas@glider.be> References: <302584628c4c0699239a0218376fe1c11cdc8944.1787165329.git.geert+renesas@glider.be> Date: Wed, 19 Aug 2026 19:13:16 +0000 Message-Id: <20260819191316.8F2F21F000E9@smtp.kernel.org> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBJbmNvbXBsZXRlIGZpeCBmb3IgdW5pbml0aWFsaXplZCBzdGFjayB2YXJpYWJsZXM6 IGBzdHJ1Y3QgY2xrX3BhcmVudF9kYXRhIHBhcmVudF9kYXRhYCByZW1haW5zIHVuaW5pdGlhbGl6 ZWQgb24gdGhlIHN0YWNrLCBsZWFkaW5nIHRvIGEga2VybmVsIGNyYXNoIGR1cmluZyBjbG9jayBy ZWdpc3RyYXRpb24uCi0tCgotLS0gUGF0Y2ggWzRdOiBbUEFUQ0ggdHJlZXdpZGUgNC81XSBpaW86 IGZyZXF1ZW5jeTogYWRmNDM3NzogTWFrZSBzdXJlIGNsa19pbml0X2RhdGEgaXMgZnVsbHkgaW5p dGlhbGl6ZWQgLS0tCmNvbW1pdCA5OWUwMjRhNzdmNWJjZTU5MjFkM2M2YjQ2MDU0MjYzYWE0NTA2 MTBkCkF1dGhvcjogR2VlcnQgVXl0dGVyaG9ldmVuIDxnZWVydCtyZW5lc2FzQGdsaWRlci5iZT4K CmlpbzogZnJlcXVlbmN5OiBhZGY0Mzc3OiBNYWtlIHN1cmUgY2xrX2luaXRfZGF0YSBpcyBmdWxs eSBpbml0aWFsaXplZAoKVGhpcyBjb21taXQgaW5pdGlhbGl6ZXMgdGhlIGNsa19pbml0X2RhdGEg c3RydWN0dXJlIGluCmFkZjQzNzdfY2xrX3JlZ2lzdGVyKCkgdG8gemVyby4gVGhpcyBwcmV2ZW50 cyBjcmFzaGVzIGNhdXNlZCBieQp1bmluaXRpYWxpemVkIGZpZWxkcyBsaWtlIHBhcmVudF9uYW1l cyB3aGVuIENPTkZJR19JTklUX1NUQUNLX0FMTF9QQVRURVJOCm9yIENPTkZJR19JTklUX1NUQUNL X05PTkUgaXMgZW5hYmxlZC4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvaWlvL2ZyZXF1ZW5jeS9h ZGY0Mzc3LmMgYi9kcml2ZXJzL2lpby9mcmVxdWVuY3kvYWRmNDM3Ny5jCj4gLS0tIGEvZHJpdmVy cy9paW8vZnJlcXVlbmN5L2FkZjQzNzcuYwo+ICsrKyBiL2RyaXZlcnMvaWlvL2ZyZXF1ZW5jeS9h ZGY0Mzc3LmMKPiBAQCAtOTk5LDcgKzk5OSw3IEBAIHN0YXRpYyBpbnQgYWRmNDM3N19jbGtfcmVn aXN0ZXIoc3RydWN0IGFkZjQzNzdfc3RhdGUgKnN0KQo+ICB7Cj4gIAlzdHJ1Y3Qgc3BpX2Rldmlj ZSAqc3BpID0gc3QtPnNwaTsKPiAgCXN0cnVjdCBkZXZpY2UgKmRldiA9ICZzcGktPmRldjsKPiAt CXN0cnVjdCBjbGtfaW5pdF9kYXRhIGluaXQ7Cj4gKwlzdHJ1Y3QgY2xrX2luaXRfZGF0YSBpbml0 ID0ge307Cj4gIAlzdHJ1Y3QgY2xrX3BhcmVudF9kYXRhIHBhcmVudF9kYXRhOwoKW1NldmVyaXR5 OiBIaWdoXQpUaGlzIGlzIGEgcHJlLWV4aXN0aW5nIGlzc3VlLCBidXQgZG9lcyB0aGlzIHN0cnVj dCBjbGtfcGFyZW50X2RhdGEgYWxzbwpuZWVkIHRvIGJlIHplcm8taW5pdGlhbGl6ZWQ/CgpPbmx5 IGZ3X25hbWUgaXMgZXhwbGljaXRseSBhc3NpZ25lZCBiZWxvdywgbGVhdmluZyBuYW1lLCBodywg YW5kIGluZGV4CnBvcHVsYXRlZCB3aXRoIHN0YWNrIGdhcmJhZ2UuIFdoZW4gYWRmNDM3N19jbGtf cmVnaXN0ZXIoKSBwYXNzZXMgdGhpcyB0bwp0aGUgY2xvY2sgZnJhbWV3b3JrLCBjbGtfY29yZV9w b3B1bGF0ZV9wYXJlbnRfbWFwKCkgd2lsbCByZWFkCnBhcmVudF9kYXRhLm5hbWUgYW5kIHBhc3Mg aXQgdG8gY2xrX2NweV9uYW1lKCksIHdoaWNoIHVsdGltYXRlbHkgY2FsbHMKc3RybGVuKCkgYW5k IGNhbiBjYXVzZSBhIHBhZ2UgZmF1bHQgZHVyaW5nIHByb2JlLgoKWyAuLi4gXQoKPiAgCXBhcmVu dF9kYXRhLmZ3X25hbWUgPSAicmVmX2luIjsKPiAgCj4gIAlpbml0Lm9wcyA9ICZhZGY0Mzc3X2Ns a19vcHM7Cj4gIAlpbml0LnBhcmVudF9kYXRhID0gJnBhcmVudF9kYXRhOwoKLS0gClNhc2hpa28g QUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC9jb3Zlci4xNzg3MTY1 MzI5LmdpdC5nZWVydCtyZW5lc2FzQGdsaWRlci5iZT9wYXJ0PTQKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFtbG9naWMgbWFpbGluZyBsaXN0 CmxpbnV4LWFtbG9naWNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFtbG9naWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DC464078F2; Wed, 19 Aug 2026 19:13:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787166799; cv=none; b=rNvhjURl1W1v0I5aS4LIA+1eR5PkzF5QMNyBU4vah4B+PIHp1YGTokKwXQLAz+OPqw77+sALgNtvBxSsvtaSRLvD4zR88H1aHNFJm1vE+0cJnSj6P+mXYBT/I9X85sJAFeriuQW9UQWbi/nROewxy+Z3yizNnvoc7/IvX0UXx7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787166799; c=relaxed/simple; bh=MqmqIfzNmkuth/E+kk7+72FX2PfWhxL55bDSfc2zD0k=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=PCVSLG7BNKtuAoBctFHAYmt3pxqND79ydmA2JtTPiHXVFl0wXAifXrrVWlu4dI1LYWmqJ8ij5MIhcvcQlnArGKEY1KuCury9RuJmT5zP5nKaLJC0jCBMrrd9prqqWspkHlZ/kP0PCKZlND5JaP+xZT+92aVWcpkLEdedn7AhfkM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=avFL27vf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="avFL27vf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F2F21F000E9; Wed, 19 Aug 2026 19:13:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787166796; bh=7QPB8xntRosfEaEsyywjE8Y9e9e7wAx1p25F0kiuc9I=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=avFL27vf7uiDuhOHLuxB/2oCnPMbgPs124dXFVRT5tHaeRQQCP2+ZifxIXNr163q2 0WmOepLH205z65+O10bAs3Vs3o9P+7gMNQJSoER6EPsgVcLrdvg9AhHM25vpQD4TBn D7zzhY7iNTS25TLnTyPGlM0Z4ugnBZLe/UkucPfZmSjQD/DjwXn/VGH6WULFwtEIqd EFe19QZUf3E8F9SDthfUMIVl4MrNFn1LFrQWoxUh1S95SvS5g3u+Zl9n2ksOSMqwqs sL+XArbeCt8QqsqbIfzmhN/qwKpv/2F7M5AtiFK/Vj7pwf0IXIJozlH7biGZyhTfLL pmeSDzXiC4yUQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH treewide 4/5] iio: frequency: adf4377: Make sure clk_init_data is fully initialized Reply-To: sashiko-reviews@lists.linux.dev To: "Geert Uytterhoeven" Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, neil.armstrong@linaro.org, linux-hwmon@vger.kernel.org In-Reply-To: <302584628c4c0699239a0218376fe1c11cdc8944.1787165329.git.geert+renesas@glider.be> References: <302584628c4c0699239a0218376fe1c11cdc8944.1787165329.git.geert+renesas@glider.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 19 Aug 2026 19:13:16 +0000 Message-Id: <20260819191316.8F2F21F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: Pre-existing issues: - [High] Incomplete fix for uninitialized stack variables: `struct clk_pare= nt_data parent_data` remains uninitialized on the stack, leading to a kerne= l crash during clock registration. -- --- Patch [4]: [PATCH treewide 4/5] iio: frequency: adf4377: Make sure clk_= init_data is fully initialized --- commit 99e024a77f5bce5921d3c6b46054263aa450610d Author: Geert Uytterhoeven iio: frequency: adf4377: Make sure clk_init_data is fully initialized This commit initializes the clk_init_data structure in adf4377_clk_register() to zero. This prevents crashes caused by uninitialized fields like parent_names when CONFIG_INIT_STACK_ALL_PATTERN or CONFIG_INIT_STACK_NONE is enabled. > diff --git a/drivers/iio/frequency/adf4377.c b/drivers/iio/frequency/adf4= 377.c > --- a/drivers/iio/frequency/adf4377.c > +++ b/drivers/iio/frequency/adf4377.c > @@ -999,7 +999,7 @@ static int adf4377_clk_register(struct adf4377_state = *st) > { > struct spi_device *spi =3D st->spi; > struct device *dev =3D &spi->dev; > - struct clk_init_data init; > + struct clk_init_data init =3D {}; > struct clk_parent_data parent_data; [Severity: High] This is a pre-existing issue, but does this struct clk_parent_data also need to be zero-initialized? Only fw_name is explicitly assigned below, leaving name, hw, and index populated with stack garbage. When adf4377_clk_register() passes this to the clock framework, clk_core_populate_parent_map() will read parent_data.name and pass it to clk_cpy_name(), which ultimately calls strlen() and can cause a page fault during probe. [ ... ] > parent_data.fw_name =3D "ref_in"; > =20 > init.ops =3D &adf4377_clk_ops; > init.parent_data =3D &parent_data; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/cover.1787165329.gi= t.geert+renesas@glider.be?part=3D4