From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E15F9C5B572 for ; Wed, 19 Aug 2026 22:26:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qUHF/iiwesIbimQHX6jq2u+WabfFlLd7D+fMwnkKIsA=; b=A3ZfCiO8e0w6ITMJOWpNAspGqr ayW4GvFEJgvqm8XnU/UuMdAZ9uUzt0y7N46SltyoGuaRlzhH6tHSXY5WOqPV5tT7I8qjqt/JZZaFz 64CgBjgkJpd/JxTgZZ9Eza5l8eJDfx/yfckM8bfwvRrqL4VM+f99IVYjIDoACtBFQc/kaiXM8xY9m 38F0dHw24p0QEIMpBDKrVxYn/2DhJe5ifIFzoG0q0ZzlX7yy6I1j4gzOMBj6ptfZh8cT0+/+U4tPH m7fN8tosdlsPDHDbN9Di1Dr/0slwNjyKoyZBwr/IlLhcWel8OTiDgUXNTXh96CdBnYoQxF8uJ2b/e djHnvexw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wwojJ-0000000AbpM-3EkY; Wed, 19 Aug 2026 22:25:53 +0000 Received: from smtpout-03.galae.net ([185.246.85.4]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wwojH-0000000Aboa-1z7L for linux-arm-kernel@lists.infradead.org; Wed, 19 Aug 2026 22:25:52 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id D56F34E412DF; Wed, 19 Aug 2026 22:25:49 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 9FDF45FF42; Wed, 19 Aug 2026 22:25:49 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 8F4A711C75BF8; Thu, 20 Aug 2026 00:25:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1787178344; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=qUHF/iiwesIbimQHX6jq2u+WabfFlLd7D+fMwnkKIsA=; b=JYbCaxaU3RsAOJeIbw/wpZPp+zf5o1Q32Yfcredac8E06E91juxJ4zuUmiVunBi5poy1E9 9CPGhpZ13mrps2B7PuIfs6ujXEZ5hCdZjVf4dYIQ9FnDRIkaPta+abyrAFemliH3NPcOkE 9SLuj3bUIRxgm7ner+/CRQbT9zw/G3f/5UPM+NdJSuIX/0+eHju1kMz5ED6njDYcjhTPkE rjAmw3qnAV6Zmne+d/Git/elI6mAGZxYWw1TfTQ6OQ/jvpr3krJmlWyymTpqwAh0SQwzKa XvSlolFeFiDkgnsZiacjpK9/6xEL9XNB68XygzPDx/utRKEECGqLi4pRpQhdoQ== Date: Thu, 20 Aug 2026 00:25:41 +0200 From: Alexandre Belloni To: Markus Probst Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Michael Langer , Andrew Morton , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/6] rtc: s35390a: Fix alarm not disabling Message-ID: <2026081922254172956b52@mail.local> References: <20260820-rtc_s35390a_int1-v5-0-5eb4ef85c6a9@posteo.de> <20260820-rtc_s35390a_int1-v5-3-5eb4ef85c6a9@posteo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260820-rtc_s35390a_int1-v5-3-5eb4ef85c6a9@posteo.de> X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260819_152551_658057_BE520D28 X-CRM114-Status: GOOD ( 19.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/08/2026 22:05:55+0000, Markus Probst wrote: > Implement alarm_irq_enable callback. > > Fixes: 542dd33a4925 ("drivers/rtc/rtc-s35390a.c: add wakealarm support for rtc-s35390A rtc chip") > Signed-off-by: Markus Probst > --- > drivers/rtc/rtc-s35390a.c | 29 ++++++++++++++++++++++++----- > 1 file changed, 24 insertions(+), 5 deletions(-) > > diff --git a/drivers/rtc/rtc-s35390a.c b/drivers/rtc/rtc-s35390a.c > index 4cfe7034c516..575bb256eb25 100644 > --- a/drivers/rtc/rtc-s35390a.c > +++ b/drivers/rtc/rtc-s35390a.c > @@ -270,6 +270,24 @@ static int s35390a_rtc_read_time(struct device *dev, struct rtc_time *tm) > return 0; > } > > +static int s35390a_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) > +{ > + struct s35390a *s35390a = dev_get_drvdata(dev); > + u8 sts; > + int err; > + > + if (enabled) > + sts = S35390A_INT2_MODE_ALARM; > + else > + sts = S35390A_INT2_MODE_NOINTR; > + > + err = s35390a_set_reg(s35390a, S35390A_CMD_STATUS2, &sts, sizeof(sts)); > + if (err < 0) > + return err; > + > + return 0; > +} You can definitively call this from s35390a_rtc_set_alarm instead of duplicating code. > + > static int s35390a_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alm) > { > struct i2c_client *client = to_i2c_client(dev); > @@ -410,11 +428,12 @@ static int s35390a_rtc_ioctl(struct device *dev, unsigned int cmd, > } > > static const struct rtc_class_ops s35390a_rtc_ops = { > - .read_time = s35390a_rtc_read_time, > - .set_time = s35390a_rtc_set_time, > - .set_alarm = s35390a_rtc_set_alarm, > - .read_alarm = s35390a_rtc_read_alarm, > - .ioctl = s35390a_rtc_ioctl, > + .read_time = s35390a_rtc_read_time, > + .set_time = s35390a_rtc_set_time, > + .set_alarm = s35390a_rtc_set_alarm, > + .read_alarm = s35390a_rtc_read_alarm, > + .alarm_irq_enable = s35390a_rtc_alarm_irq_enable, > + .ioctl = s35390a_rtc_ioctl, > }; > > static int s35390a_nvmem_read(void *priv, unsigned int offset, void *val, > > -- > 2.54.0 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com