From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi_debug: add support to corrupt data and/or reftag
Date: Thu, 20 Aug 2026 08:09:46 +0200 [thread overview]
Message-ID: <20260820060946.GA18804@lst.de> (raw)
In-Reply-To: <18c7a0ff-d88d-4865-936a-62e28e8fbb1c@acm.org>
On Wed, Aug 19, 2026 at 09:00:39AM -0700, Bart Van Assche wrote:
> On 8/18/26 11:58 PM, Christoph Hellwig wrote:
>> +static int corrupt_lbas(struct sdebug_dev_info *devip, u64 lba, u32 num,
>> + u32 nr_bit_errors, s32 reftag_adjust);
>
> Can the corrupt_lbas() definition be moved here such that the forward
> declaration of this function can be removed?
Not without reordering the entire file unfortunately. It depends
on various helpers further down the file, while the debugfs registration
happens further up. I've tried a few approaches to sort this out,
but failed to come up with something simple enough.
next prev parent reply other threads:[~2026-08-20 6:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 6:58 scsi_debug: add support to corrupt data and/or reftag v2 Christoph Hellwig
2026-08-19 6:58 ` [PATCH] scsi_debug: add support to corrupt data and/or reftag Christoph Hellwig
2026-08-19 7:13 ` sashiko-bot
2026-08-19 16:00 ` Bart Van Assche
2026-08-20 6:09 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-07-23 14:21 Christoph Hellwig
2026-07-23 14:37 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260820060946.GA18804@lst.de \
--to=hch@lst.de \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.