Re: [PATCH v3 1/2] dt-bindings: media: i2c: Add onsemi AR0234 image sensor binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The dt-binding schema uses `additionalProperties: false` at the top level alongside an `$ref` to `video-interface-devices.yaml`, which incorrectly rejects standard video interface properties.
- [Low] The hardware power supplies (`vaa-supply`, `vdd-supply`, `vddio-supply`) are omitted from the `required` list.
--

--- Patch [1]: [PATCH v3 1/2] dt-bindings: media: i2c: Add onsemi AR0234 image sensor binding ---
commit 9f105de6fb0990c272e7a588c7c4aea9fe0b6566
Author: Alexander Shiyan <eagle.alexander923@gmail.com>

dt-bindings: media: i2c: Add onsemi AR0234 image sensor binding

This commit adds the devicetree binding schema for the onsemi AR0234 CMOS
image sensor. It defines properties for clocks, supplies, reset GPIOs, and
the CSI-2 transmitter port.

> diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml
> new file mode 100644
> index 0000000000000..ee321acf22b59
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/onnn,ar0234.yaml
> @@ -0,0 +1,121 @@
[ ... ]
> +allOf:
> +- $ref: /schemas/media/video-interface-devices.yaml#
> +
> +properties:
[ ... ]
> +  vaa-supply:
> +    description: Analog (2.8V) supply regulator
> +
> +  vdd-supply:
> +    description: Digital Core (1.2V) supply regulator
> +
> +  vddio-supply:
> +    description: I/O (1.8V-2.8V) supply regulator
[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - port

[Severity: Low]
Should the hardware power supplies (vaa-supply, vdd-supply, vddio-supply)
be included in this required list to ensure the physical power routing is
fully described in the device tree?

> +
> +additionalProperties: false

[Severity: Medium]
Since this schema uses an allOf $ref to video-interface-devices.yaml, will
using additionalProperties: false incorrectly reject standard properties
inherited from that schema? Should this be changed to
unevaluatedProperties: false?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260820075524.2056029-1-eagle.alexander923@gmail.com?part=1