Re: [PATCH v2 7/7] arm64: dts: qcom: Add Xiaomi Redmi 9T

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Invalid `brightness-levels` property in `led-backlight` triggers boot warning and is ignored.
--

--- Patch [7]: [PATCH v2 7/7] arm64: dts: qcom: Add Xiaomi Redmi 9T ---
commit 98a4b41cf18b5589a5dbba3f7c9d120fe90da54f
Author: Adam Skladowski <a39.skl@gmail.com>

arm64: dts: qcom: Add Xiaomi Redmi 9T

This commit adds a devicetree for the Xiaomi Redmi 9T smartphone, which is 
based on the Bengal/SM6115 SoC. It introduces initial support for features 
like display, GPU, regulators, UFS, USB, and remoteprocs.

> diff --git a/arch/arm64/boot/dts/qcom/sm6115-xiaomi-lemon.dts b/arch/arm64/boot/dts/qcom/sm6115-xiaomi-lemon.dts
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm6115-xiaomi-lemon.dts

[ ... ]

> +	backlight_dsi: backlight-dsi {
> +		compatible = "led-backlight";
> +		leds = <&led_backlight>;
> +		brightness-levels = <255>;

[Severity: Low]
Does providing a single value to brightness-levels trigger a boot warning? 

The led-backlight driver typically expects brightness-levels to be an array 
of multiple values mapping an index to a brightness level. Providing a single 
element causes the driver to emit a "Not enough levels defined" warning during 
probe and ignores the property completely.

> +		default-brightness-level = <190>;
> +		/* Backlight controllers can differ between panel variants */
> +		status = "disabled";
> +	};

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260820-next-patches-v2-0-7130d68183d9@gmail.com?part=7