From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A916C5DF81 for ; Thu, 20 Aug 2026 10:17:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CB13610EFC1; Thu, 20 Aug 2026 10:17:07 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="moarlYQt"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id 80ED610EFC1 for ; Thu, 20 Aug 2026 10:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787221024; x=1818757024; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RlFPGTbbJjZQ9MkO49BnjH4jPf810bJQ+B1g2z5AFZw=; b=moarlYQt2/b0E8mkJUTxhZhWg1sp+Eu3vHAOiAe+aWejDkaNJo6LOkwZ qrFFVwWaRMuXPDLrr4nmKzC3OU8sWOJpSymW1nLINkqJAsOiNc0J7YHF6 ZGN5ERnoiklgGOPmxcWD/52WSx6NBBDMWlUdwgQVm8WCTbnn+QjTHPxJ8 8mY/lDqm7/KNxjzoo4m2LtAUFYMqE3Azw97BS2ANaQQgdNtkedxVVW9Dq HbBM7f89+k/1xCeeb8/ZmaqIFtyGhkPuFaHx73VicHM96aUyImzmwXmgh I2aEvJbuSZlRsRBzYPjsoFssUsLW390xTKlxDK1VEqOL6V8S0TQrPC1Kg g==; X-CSE-ConnectionGUID: d6r87SBOQ4iyqz6qUv1y/w== X-CSE-MsgGUID: 8Pd9EYXFTqWzCBUrGw3H8Q== X-IronPort-AV: E=McAfee;i="6800,10657,11880"; a="113290938" X-IronPort-AV: E=Sophos;i="6.25,233,1779174000"; d="scan'208";a="113290938" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2026 03:17:04 -0700 X-CSE-ConnectionGUID: bcqU9GqfSGyqOQx/RhLubA== X-CSE-MsgGUID: +zCCp6/bTXy/iHMX7EirWQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,233,1779174000"; d="scan'208";a="271176444" Received: from jraag-z790m-itx-wifi.iind.intel.com ([10.190.239.23]) by fmviesa005.fm.intel.com with ESMTP; 20 Aug 2026 03:17:00 -0700 From: Mallesh Koujalagi To: intel-xe@lists.freedesktop.org, rodrigo.vivi@intel.com, matthew.brost@intel.com Cc: anshuman.gupta@intel.com, badal.nilawar@intel.com, vinay.belgaumkar@intel.com, riana.tauro@intel.com, karthik.poosa@intel.com, sk.anirban@intel.com, raag.jadav@intel.com, michal.wajdeczko@intel.com, aravind.iddamsetty@linux.intel.com, umesh.nerlige.ramappa@intel.com, dnyaneshwar.bhadane@intel.com, anoop.c.vijay@intel.com, Mallesh Koujalagi Subject: [PATCH v4 5/7] drm/xe/sysctrl: Improve firmware response error logging Date: Thu, 20 Aug 2026 15:46:38 +0530 Message-ID: <20260820101632.527214-14-mallesh.koujalagi@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260820101632.527214-9-mallesh.koujalagi@intel.com> References: <20260820101632.527214-9-mallesh.koujalagi@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Use xe_log_err() helper and include additional details when a response header mismatch occurs. Signed-off-by: Mallesh Koujalagi --- drivers/gpu/drm/xe/xe_sysctrl_mailbox.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c b/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c index c043b51cacc8..9d7915c9d4ae 100644 --- a/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c +++ b/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c @@ -237,13 +237,17 @@ static int sysctrl_receive_frames(struct xe_sysctrl *sc, if (!XE_SYSCTRL_HDR_IS_RESPONSE(hdr) || XE_SYSCTRL_HDR_GROUP_ID(hdr) != XE_SYSCTRL_HDR_GROUP_ID(req) || XE_SYSCTRL_HDR_COMMAND(hdr) != XE_SYSCTRL_HDR_COMMAND(req)) { - xe_err(xe, "sysctrl: Response header mismatch\n"); + xe_log_err(xe, SYSCTRL, -EPROTO, + "Response header mismatch: got group=0x%02lx cmd=0x%02lx is_resp=%lu, expected group=0x%02lx cmd=0x%02lx\n", + XE_SYSCTRL_HDR_GROUP_ID(hdr), XE_SYSCTRL_HDR_COMMAND(hdr), + XE_SYSCTRL_HDR_IS_RESPONSE(hdr), + XE_SYSCTRL_HDR_GROUP_ID(req), XE_SYSCTRL_HDR_COMMAND(req)); return -EPROTO; } if (XE_SYSCTRL_HDR_RESULT(hdr) != 0) { - xe_err(xe, "sysctrl: Firmware error: 0x%02lx\n", - XE_SYSCTRL_HDR_RESULT(hdr)); + xe_log_err(xe, SYSCTRL, -EIO, "Firmware error: 0x%02lx\n", + XE_SYSCTRL_HDR_RESULT(hdr)); return -EIO; } -- 2.48.1