From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3805C5DF81 for ; Thu, 20 Aug 2026 10:17:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A367B10EFB9; Thu, 20 Aug 2026 10:17:11 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="NCCdrPhY"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id A4F8B10EFC6 for ; Thu, 20 Aug 2026 10:17:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787221028; x=1818757028; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IjjbJ4LG7X3tuntpdKdzcsgpiwdOl1o631wlKHBtJ9U=; b=NCCdrPhYiKRWg4UjvTbnon6zv/85UKqK3O85+ecWsdG8MOppi5U8jRbX ANl2lr2qr8aa4doVid5x4FczpEL3LibprQMg/GNjTwDArtGtU8l+OAI5y pwTkw6uO2IMBX1pU1qF0Zg5kev/8AYCqJJJkoCYq7QF/bQQLt/IhSunlo DmFcGRdjx5j6up+7FaZygjPtioMSWCydcT+rlF7X0KCn2vOlCCDoTJnvf DdSwJ8MWVkrtk7u6B8U560lEkWMwvr08V7W3fTbf1bkUl+ccrb5TJNKqV ZJZybYP4J6VZ0wTZ5Gq7HVNvZyNLxVBPWihu1WFIYKXtsTMLyyrVFuH4n Q==; X-CSE-ConnectionGUID: QdyaoejKTgqxgcY1B3WwrQ== X-CSE-MsgGUID: yUdXLuQeQtiF1UOMWoRmeA== X-IronPort-AV: E=McAfee;i="6800,10657,11880"; a="113290947" X-IronPort-AV: E=Sophos;i="6.25,233,1779174000"; d="scan'208";a="113290947" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2026 03:17:08 -0700 X-CSE-ConnectionGUID: n+CUv+crR9+u+aPTHrsw8g== X-CSE-MsgGUID: urxYt3AiTM+oJAk+dLClqQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,233,1779174000"; d="scan'208";a="271176450" Received: from jraag-z790m-itx-wifi.iind.intel.com ([10.190.239.23]) by fmviesa005.fm.intel.com with ESMTP; 20 Aug 2026 03:17:04 -0700 From: Mallesh Koujalagi To: intel-xe@lists.freedesktop.org, rodrigo.vivi@intel.com, matthew.brost@intel.com Cc: anshuman.gupta@intel.com, badal.nilawar@intel.com, vinay.belgaumkar@intel.com, riana.tauro@intel.com, karthik.poosa@intel.com, sk.anirban@intel.com, raag.jadav@intel.com, michal.wajdeczko@intel.com, aravind.iddamsetty@linux.intel.com, umesh.nerlige.ramappa@intel.com, dnyaneshwar.bhadane@intel.com, anoop.c.vijay@intel.com, Mallesh Koujalagi Subject: [PATCH v4 6/7] drm/xe/sysctrl: Log group and command ID on mailbox failure Date: Thu, 20 Aug 2026 15:46:39 +0530 Message-ID: <20260820101632.527214-15-mallesh.koujalagi@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260820101632.527214-9-mallesh.koujalagi@intel.com> References: <20260820101632.527214-9-mallesh.koujalagi@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Include the mailbox group ID and command code in error logs for command preparation and execution failures. Signed-off-by: Mallesh Koujalagi --- drivers/gpu/drm/xe/xe_sysctrl_mailbox.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c b/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c index 9d7915c9d4ae..dd4cf8ad1279 100644 --- a/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c +++ b/drivers/gpu/drm/xe/xe_sysctrl_mailbox.c @@ -373,7 +373,8 @@ int xe_sysctrl_send_command(struct xe_sysctrl *sc, cmd->data_in, cmd->data_in_len, &mbox_cmd, &cmd_size); if (ret) { - xe_err(xe, "sysctrl: Failed to prepare command: %pe\n", ERR_PTR(ret)); + xe_log_err(xe, SYSCTRL, ret, "Failed to prepare command group=0x%02x cmd=0x%02x\n", + group_id, command_code); return ret; } @@ -383,7 +384,8 @@ int xe_sysctrl_send_command(struct xe_sysctrl *sc, cmd->data_out, cmd->data_out_len, rdata_len, XE_SYSCTRL_MB_DEFAULT_TIMEOUT_MS); if (ret) - xe_err(xe, "sysctrl: Mailbox command failed: %pe\n", ERR_PTR(ret)); + xe_log_err(xe, SYSCTRL, ret, "Mailbox command failed group=0x%02x cmd=0x%02x\n", + group_id, command_code); kfree(mbox_cmd); -- 2.48.1