From: Jakub Kicinski <kuba@kernel.org>
To: Thomas Walsh <thwalsh@redhat.com>
Cc: Pavan Chebbi <pavan.chebbi@broadcom.com>,
Michael Chan <michael.chan@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Michal Schmidt <mschmidt@redhat.com>
Subject: Re: [PATCH net] bnxt_en: Gate TPH enablement behind BNXT_SUPPORTS_QUEUE_API check
Date: Thu, 20 Aug 2026 12:11:34 -0700 [thread overview]
Message-ID: <20260820121134.6af40206@kernel.org> (raw)
In-Reply-To: <CAD+aA82ONaO+oNuX448ruJdLJ+ySvsnNwyCLYGGyDZfOA6U6cQ@mail.gmail.com>
On Thu, 20 Aug 2026 14:29:55 -0400 Thomas Walsh wrote:
> On Thu, Aug 20, 2026 at 2:16 PM Jakub Kicinski <kuba@kernel.org> wrote:
> > On Thu, 20 Aug 2026 13:55:57 -0400 Thomas Walsh wrote:
> > > In this particular situation, the customer had very recently upgraded their
> > > firmware. "RX queue restart failed: err=-95" messages were still observed.
> >
> > Would you be able to share the NIC and the FW version?
>
> NIC is BCM57414 NetXtreme-E 10Gb/25Gb RDMA Ethernet Controller
> [14e4:16d7]
> FW version shared with us was 238.1.138.6 upgraded from 236.1.167.0
>
> > Could it be that they upgraded to a version which has TPH but not queue
> > resets yet? I _think_ queue resets came in 232.x but maybe there were
> > bugs which delayed it later.
>
> I suspected something similar initially, but both of the versions are
> _relatively_ recent AFAICT.
Ugh, apparently :( I would have thought nobody is buying BCM574xx
> Which lead us to graceful handling of pcie_enable_tph()
Either way, I still agree with your approach.
Let's see if Pavan and Michael feel strongly.
prev parent reply other threads:[~2026-08-20 19:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 14:15 [PATCH net] bnxt_en: Gate TPH enablement behind BNXT_SUPPORTS_QUEUE_API check Thomas Walsh
2026-08-19 9:48 ` Pavan Chebbi
2026-08-20 17:39 ` Jakub Kicinski
2026-08-20 17:55 ` Thomas Walsh
2026-08-20 18:15 ` Jakub Kicinski
2026-08-20 18:29 ` Thomas Walsh
2026-08-20 18:59 ` Michael Chan
2026-08-20 19:16 ` Michael Chan
2026-08-20 21:14 ` Jakub Kicinski
2026-08-20 21:24 ` Thomas Walsh
2026-08-20 19:11 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260820121134.6af40206@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=thwalsh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.