From: sashiko-bot@kernel.org
To: "Janosch Frank" <frankja@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, "Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
kvm@vger.kernel.org, "Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH v4 2/3] KVM: s390: Kick PV cpus at the right time for service irqs
Date: Thu, 20 Aug 2026 12:30:21 +0000 [thread overview]
Message-ID: <20260820123022.0A95F1F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260820121546.24694-3-frankja@linux.ibm.com>
> Service call handling is a two stage process for PV vms. First we
> receive the secure instruction intercept and then the secure
> instruction notification intercept.
>
> The secure instruction intercept (104) is analogous to the non-pv
> instruction intercept (4) with the difference that we're not allowed
> to inject an IRQ when re-entering SIE. We have to wait for the
> notification intercept (108) which tells us that we're allowed to
> inject.
>
> Unfortunately we never considered this difference and hence the IRQ
> injection code will try to inject on the secure instruction intercept
> where service IRQs are masked.
>
> It's time to move injection to the instruction notification and skip
> injection on the instruction interception path.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260820121546.24694-1-frankja@linux.ibm.com?part=2
next prev parent reply other threads:[~2026-08-20 12:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 12:12 [PATCH v4 0/3] KVM: s390: Improve floating IRQ injection behavior Janosch Frank
2026-08-20 12:12 ` [PATCH v4 1/3] " Janosch Frank
2026-08-20 12:31 ` sashiko-bot
2026-08-20 12:12 ` [PATCH v4 2/3] KVM: s390: Kick PV cpus at the right time for service irqs Janosch Frank
2026-08-20 12:30 ` sashiko-bot [this message]
2026-08-20 12:12 ` [PATCH v4 3/3] KVM: s390: Add opportunistic floating IRQ injection Janosch Frank
2026-08-20 12:27 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260820123022.0A95F1F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.