Re: [PATCH v3 3/5] dt-bindings: iio: pressure: Add MS5637

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Making `vdd-supply` an unconditionally required property breaks backward compatibility for existing device trees.
--

--- Patch [3]: [PATCH v3 3/5] dt-bindings: iio: pressure: Add MS5637 ---
commit f37736f8c819b5be2f362b907ebbc2d3373ecbfe
Author: Louis Adamian <adamianlouis@gmail.com>

dt-bindings: iio: pressure: Add MS5637

Create meas,ms5637 devicetree binding and move existing devices from
trivial-devices.yaml. Explicit compatible strings are added for the
different sub-variants because each requires different constants for the
second-order temperature compensation formulas.

> diff --git a/Documentation/devicetree/bindings/iio/pressure/meas,ms5637.yaml b/Documentation/devicetree/bindings/iio/pressure/meas,ms5637.yaml
> new file mode 100644
> index 0000000000000..befd81d1907b4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/pressure/meas,ms5637.yaml

[ ... ]

> +properties:
> +  compatible:
> +    oneOf:
> +      - enum:
> +          - meas,ms5637-02ba
> +          - meas,ms5637-30ba
> +          - meas,ms5803-01ba
> +          - meas,ms5803-02ba
> +          - meas,ms5803-05ba
> +          - meas,ms5803-14ba
> +          - meas,ms5803-30ba
> +          - meas,ms5805
> +          - meas,ms5837-02ba
> +          - meas,ms5837-30ba
> +          - meas,ms8607-temppressure
> +      # These generic compatible strings do not identify the sub-variants of
> +      # the part. They are retained so that existing device trees continue
> +      # to bind, and each is treated as the -02BA variant of its family.
> +      - enum:
> +          - meas,ms5637
> +          - meas,ms5803
> +          - meas,ms5837
> +        deprecated: true
> +
> +  reg:
> +    maxItems: 1
> +
> +  vdd-supply:
> +    description: Regulator that provides power to the sensor
> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply

[Severity: Medium]
Will making vdd-supply unconditionally required break backward compatibility
for existing device trees?

These generic compatible strings (e.g., meas,ms5637, meas,ms5803) were
previously documented in trivial-devices.yaml. That schema restricts
properties to a very narrow set and strictly forbids vdd-supply via
additionalProperties: false.

Consequently, existing valid device trees do not include vdd-supply.

By moving these devices to a new standalone binding and making vdd-supply
unconditionally required, won't previously valid device trees fail validation?

Should newly documented properties remain optional, or be conditionally
required using an if-then block only for the newly added specific compatible
strings to preserve the DT ABI when extracting devices from
trivial-devices.yaml?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260820141224.23730-1-adamianlouis@gmail.com?part=3