Re: [PATCH] drm/amd/display: Drop KUnit tests for removed parse_hdmi_amd_vsdb()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Erroneous deletion of active test coverage and prototype causing a compiler warning. The patch removes the KUnit tests and header declaration for `parse_hdmi_amd_vsdb()` based on the incorrect assumption that the function was removed by commit `f65198b3d073`. However, `f65198b3d073` is not present in the baseline tree. As a result, `parse_hdmi_amd_vsdb()` remains fully implemented and actively used by `amdgpu_dm_update_freesync_caps()`. Applying this patch deletes valid test coverage for an active code path. Additionally, because the function uses the `STATIC_IFN_KUNIT` macro (making it global when KUnit is enabled), removing its prototype from the header triggers a `-Wmissing-prototypes` compiler warning.
--

--- Patch [1]: [PATCH] drm/amd/display: Drop KUnit tests for removed parse_hdmi_amd_vsdb() ---
commit 9e04fb9539ed0ab6b97c5e730b64224c40a317f4
Author: Rodrigo Vivi <rodrigo.vivi@intel.com>

drm/amd/display: Drop KUnit tests for removed parse_hdmi_amd_vsdb()

This commit removes the declaration and KUnit tests for
parse_hdmi_amd_vsdb(), stating that the function was previously removed.

Fixes: f65198b3d073 ("drm/amd/display: Use HDMI FreeSync range from common EDID parser")
Cc: Alex Huang <Alex.Huang2@amd.com>
Cc: Mario Limonciello <superm1@kernel.org>
Assisted-by: Copilot:Claude-Opus-5
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.h
> index 4e9eb3ff2c904..ce900844602e5 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.h
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.h
> @@ -153,9 +153,6 @@ void parse_edid_displayid_vrr(struct drm_connector *connector,
>  			      const struct edid *edid);
>  int get_amd_vsdb(struct amdgpu_dm_connector *aconnector,
>  		 struct amdgpu_hdmi_vsdb_info *vsdb_info);
> -int parse_hdmi_amd_vsdb(struct amdgpu_dm_connector *aconnector,
> -			const struct edid *edid,
> -			struct amdgpu_hdmi_vsdb_info *vsdb_info);

[Severity: Medium]
Is this function actually removed in the current tree?

The commit message states parse_hdmi_amd_vsdb() was removed by f65198b3d073,
but it appears that commit is not present in the baseline tree.

Looking at drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c, 
parse_hdmi_amd_vsdb() is still fully implemented and actively called by 
amdgpu_dm_update_freesync_caps():

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c:amdgpu_dm_update_freesync_caps() {
    ...
    i = parse_hdmi_amd_vsdb(amdgpu_dm_connector, edid, &vsdb_info);
    ...
}

Since parse_hdmi_amd_vsdb() is defined using STATIC_IFN_KUNIT (which makes
it a global function when KUnit is enabled), removing its prototype here
triggers a -Wmissing-prototypes compiler warning during KUnit builds.

[ ... ]

> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_connector_test.c b/drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_connector_test.c
> index a54fd9529dc9e..83d3be5432028 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_connector_test.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_connector_test.c
> @@ -4874,75 +4874,6 @@ static void dm_test_get_amd_vsdb_supported(struct kunit *test)
>  	KUNIT_EXPECT_TRUE(test, vsdb_info.replay_mode);
>  }
>  
> -/**
> - * dm_test_parse_hdmi_amd_vsdb_null_edid - Test NULL EDID returns -ENODEV
> - * @test: The KUnit test context
> - */
> -static void dm_test_parse_hdmi_amd_vsdb_null_edid(struct kunit *test)

[Severity: Medium]
Because parse_hdmi_amd_vsdb() is still present and used, does removing
these tests prematurely delete valid test coverage for an active code path?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260820142802.1342066-2-rodrigo.vivi@intel.com?part=1