From: Nikolaus Schuetz <nikolauspschuetz@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH] t1402: test forbidden characters in refnames
Date: Thu, 20 Aug 2026 09:46:37 -0500 [thread overview]
Message-ID: <20260820144648.47267-1-nikolauspschuetz@gmail.com> (raw)
In-Reply-To: <xmqqo6exuagw.fsf@gitster.g>
> True. And c does not have to be a single byte. ".." can also be
> part of the repertoire.
Agreed and updated accordingly: forbidden chars are looped over,
and I folded ".." in along with "\" (the same forbidden-char list).
The other refname rules enforced by refs.c are well covered,
so I kept the loop to the embedded forbidden tokens.
> By the way, one weird bit: is it intentional that all of these really
> use "heads/something" instead of "refs/heads/something"?
Not intentional -- the file already mixes them (e.g. 'refs/heads/foo.'
vs 'heads/foo..bar'). check-ref-format validates each component
regardless of a refs/ prefix, so it doesn't change what's tested; I
kept 'heads/' to match the neighbours.
Thanks,
Nikolaus
next prev parent reply other threads:[~2026-08-20 14:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 20:43 [PATCH] t1402: test forbidden characters in refnames Nikolaus Schuetz via GitGitGadget
2026-08-19 11:20 ` Patrick Steinhardt
2026-08-19 20:22 ` Junio C Hamano
2026-08-20 14:46 ` Nikolaus Schuetz [this message]
2026-08-20 22:20 ` [PATCH v2] " Nikolaus Schuetz via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260820144648.47267-1-nikolauspschuetz@gmail.com \
--to=nikolauspschuetz@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.