From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC02F272E53; Thu, 20 Aug 2026 16:42:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787244157; cv=none; b=jgj2SWoowFvasjNVrWnD1ytCcLp3GkLU2/gjT4Oq/3clKEbkV4JkTur+o5ZzFtM5OaFC4cr1SoS7es9PfQLlvFF+UaS9VP8YVvs3oG4QCiun9q95vGzjBma8gl5+n6u8ey7Vl/CpcaumaxevhlrkfxrJ/pSu091fCk5GWVh7ydU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787244157; c=relaxed/simple; bh=SORTebHlB+xUdmYsII381BGnDVD+2r5VKnM6lt7rsB8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fs9+ORI8ENMdi1IUNAG1SXBfcNKhttNJo69tudq9wROR23Q7zadE/Y+x9is4rdk8Tr+FAPr11IFk7/xnn5TnscfaElL+Qb7B585mRsX3m8fLeAGbhXnUQckTe/aQxpUH4ShTLrwAJFZ1K0m9voWtGd1M67I3v6RIU//BNUm75pM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dN3AclY4; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dN3AclY4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21DBB1F000E9; Thu, 20 Aug 2026 16:42:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1787244156; bh=L5+dg5fpPvOKz6ShLvQbtYiMoAHYLBZ+QDcqjFgTpkM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=dN3AclY43AS0zPw1W0pvG0B9ZBMuxSJgMsNZbxe9i9AZCvrYH6E/+gfjwTW6B9CAW sMkaq/g0je3JpYgKM7kO/7iS0YochQG16F7iz16VadouvSC4KsPR1eLWPsdb44RiOu n5nqxAYHDukkpDBSzQ7iGVjkUW3qmv1jLaJvZHQ0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ren Wei , Pablo Neira Ayuso , Florian Westphal , Sasha Levin Subject: [PATCH 5.10 072/235] netfilter: nf_conntrack_sip: validate skb_dst() before accessing it Date: Thu, 20 Aug 2026 16:55:08 +0200 Message-ID: <20260820145218.627644543@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260820145216.426568665@linuxfoundation.org> References: <20260820145216.426568665@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pablo Neira Ayuso [ Upstream commit e5e24a365a5e024efef63cc49abb345fbd4852c5 ] tc ingress and openvswitch do not guarantee routing information to be available. These subsystems use the conntrack helper infrastructure, and the SIP helper relies on the skb_dst() to be present if sip_external_media is set to 1 (which is disabled by default as a module parameter). This effectively disables the sip_external_media toggle for these subsystems without resulting in a crash. Fixes: cae3a2627520 ("openvswitch: Allow attaching helpers to ct action") Fixes: b57dc7c13ea9 ("net/sched: Introduce action ct") Cc: stable@vger.kernel.org Reported-by: Ren Wei Signed-off-by: Pablo Neira Ayuso Signed-off-by: Florian Westphal Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- net/netfilter/nf_conntrack_sip.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) --- a/net/netfilter/nf_conntrack_sip.c +++ b/net/netfilter/nf_conntrack_sip.c @@ -947,7 +947,6 @@ static int set_expected_rtp_rtcp(struct return NF_ACCEPT; saddr = &ct->tuplehash[!dir].tuple.src.u3; } else if (sip_external_media) { - struct net_device *dev = skb_dst(skb)->dev; struct dst_entry *dst = NULL; struct flowi fl; @@ -969,7 +968,11 @@ static int set_expected_rtp_rtcp(struct * through the same interface as the signalling peer. */ if (dst) { - bool external_media = (dst->dev == dev); + const struct dst_entry *this_dst = skb_dst(skb); + bool external_media = false; + + if (this_dst && dst->dev == this_dst->dev) + external_media = true; dst_release(dst); if (external_media)