From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3B0047DD54; Thu, 20 Aug 2026 16:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787244422; cv=none; b=C12fwl3+g69xsFTEWL4oBWQPvqXV8m1mh8RURqYWyrxACv9fbHegejpmFuJBr8zLQNKE90hsJ7MDG16YTI7XlnQD2SkJIUyHeTTJR+fVqqGRu1qQmI0w2C+Omf22iRNyu37eYN0NOdjxys6ih6IZOSj+5oP2Thv7uMjhYWpAtZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787244422; c=relaxed/simple; bh=4dG1G63yYSsx3qcKj/C6QnQOPgRr4VViFi/7dzlawoU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OuvPsEMoFZAyNchQPw0ZLBrM2jDvHfyjP2DkbBl/WJS+UY2RJatMF5s3SFp2+Vb1fFckIyVIXZuDdFxl9cqIOOg9hx+JvBtYXb/sYwjfbcuLMoTfTCWVf6kS7Dj6f5O3/H0vaqBKJzASt0dLBLnmGLa52lPehb7x2NmbH045f1Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TQcemF76; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TQcemF76" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A0681F00A3F; Thu, 20 Aug 2026 16:47:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1787244421; bh=iI/ptdq4SIraxrwSFEoGAMQwRws+QZs8LHBiMe/MV9s=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=TQcemF76vflyn0Z5+VHMot/afalyPhokNKc5F8/IXcALIT2Ev7194TllkwT75lCBk kxQT54T2LcWPxSi4bz8JK5epP6feze1RQoMF5774I8n0BBDePgUrg3W8M7zkJfgW61 OM6ogDVyXwbOjr7aCs4PrZ7D/DsReYww+vTS08mI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Daniel Hodges , Vasanthakumar Thiagarajan , Jeff Johnson , Sasha Levin Subject: [PATCH 5.10 163/235] wifi: ath6kl: fix use-after-free in aggr_reset_state() Date: Thu, 20 Aug 2026 16:56:39 +0200 Message-ID: <20260820145221.431293006@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260820145216.426568665@linuxfoundation.org> References: <20260820145216.426568665@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Daniel Hodges [ Upstream commit ba7debb4dd6427386862220e8335a53a4bfc235d ] The aggr_reset_state() function uses timer_delete() (non-synchronous) for the aggregation timer before proceeding to delete TID state and before the structure is freed by callers like aggr_module_destroy(). If the timer callback (aggr_timeout) is executing when aggr_reset_state() is called, the callback will continue to access aggr_conn fields like rx_tid[] and stat[] which may be freed immediately after by kfree(aggr_info->aggr_conn) in aggr_module_destroy(). Additionally, the timer callback can re-arm itself via mod_timer() while aggr_reset_state() is running, creating a more complex race condition. Use timer_delete_sync() instead to ensure any running timer callback has completed before returning. Fixes: bdcd81707973 ("Add ath6kl cleaned up driver") Cc: stable@vger.kernel.org Signed-off-by: Daniel Hodges Reviewed-by: Vasanthakumar Thiagarajan Link: https://patch.msgid.link/20260206185207.30098-1-git@danielhodges.dev Signed-off-by: Jeff Johnson Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/ath/ath6kl/txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/ath/ath6kl/txrx.c +++ b/drivers/net/wireless/ath/ath6kl/txrx.c @@ -1829,7 +1829,7 @@ void aggr_reset_state(struct aggr_info_c return; if (aggr_conn->timer_scheduled) { - del_timer(&aggr_conn->timer); + timer_delete_sync(&aggr_conn->timer); aggr_conn->timer_scheduled = false; }