From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5681272E53; Thu, 20 Aug 2026 16:27:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787243262; cv=none; b=KvQQabsGAA77pt12wXgnjegIGnK+Fzw1lniE2975ZH+RlnqVzHptVHniRdlCs7hqj6FJPbonOBz+TBeLf35ecBWHVtgoykcfjitMMXGdNEJGmH5m5qd5+5DY4AaeuFwpEf9m7URwLyiA84LhjiDsuu8+9FAtCEvYl0ewmsKZ9gI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787243262; c=relaxed/simple; bh=7K6rQnpDMnw96DkYEthz3alH/SUucESYq8KqmskyhL0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fm51ql/JG1X7SoXCRN8rsK5FkZAbqMxfAkjZdivCM+kF5mvz5RenJKgZ8eHwPYrzQqzbsA5Bm6GNgwTJf1Yr1ABGl7136GYpfw4Azo7bLHXTV04OVqGgacHGmFeN2Tcq8VGYXl4RuZ6XZM6xxSZ4sJUHFZeZIH+OzA7P2QM8gHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=n28k/gLi; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="n28k/gLi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF1691F00A3A; Thu, 20 Aug 2026 16:27:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1787243260; bh=0jQpe+dhDjJSlpAv12QsLbXNMLGKnrQmlXPwxWh9Woc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=n28k/gLiCeeNkDpsaM6t8wzqHodIiqASkyJ4+CXIo272NpUa10X2i0F79k254KElF o7j/ZcMB6zdGTev7iVCPAl3jAY2qJmQT8Ljloct70joponn8MBbuxvCWQY6PQl2J71 jJsTuKbSz4/l2V+t0EeG9rcGI/b4JfwbBtsr5rgw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bryam Vargas , Stephen Smalley , Paul Moore Subject: [PATCH 5.15 006/272] selinux: require every boolean value to be defined Date: Thu, 20 Aug 2026 16:53:10 +0200 Message-ID: <20260820145231.426900054@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260820145231.229664293@linuxfoundation.org> References: <20260820145231.229664293@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bryam Vargas commit a93d37a09b863810653f93d371fb197457d59deb upstream. p_bools.nprim comes from the policy image independently of how many booleans follow it, and cond_index_bool() fills bool_val_to_struct[] at value - 1, so a count larger than the values present leaves NULL entries. Every user of that array then walks it by index and dereferences each entry: cond_evaluate_expr() on the access-vector path, security_get_bools() and security_get_bool_value() behind selinuxfs, and security_set_bools(). A sparse class value is absorbed by policydb_class_isvalid() and its siblings; booleans have no such predicate, and no consumer that could use one. Reject a boolean value that no boolean defines, once, where the array is built. Conforming policies define every boolean they declare and are unaffected. Cc: stable@vger.kernel.org Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Bryam Vargas Acked-by: Stephen Smalley Signed-off-by: Paul Moore Signed-off-by: Greg Kroah-Hartman --- security/selinux/ss/policydb.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) --- a/security/selinux/ss/policydb.c +++ b/security/selinux/ss/policydb.c @@ -718,6 +718,7 @@ static inline void hash_eval(struct hash static int policydb_index(struct policydb *p) { int i, rc; + u32 v; if (p->mls_enabled) pr_debug("SELinux: %d users, %d roles, %d types, %d bools, %d sens, %d cats\n", @@ -775,6 +776,24 @@ static int policydb_index(struct policyd if (rc) goto out; } + + /* + * A sparse class value is absorbed by policydb_class_isvalid() and + * its siblings, but no such predicate exists for booleans: every + * user of bool_val_to_struct[] walks it by index and dereferences + * each entry -- cond_evaluate_expr(), the two getters and + * security_set_bools() -- so an unclaimed one has no consumer that + * can tolerate it. + */ + for (v = 0; v < p->p_bools.nprim; v++) { + if (!p->bool_val_to_struct[v]) { + pr_err("SELinux: boolean %u is declared but not defined\n", + v + 1); + rc = -EINVAL; + goto out; + } + } + rc = 0; out: return rc;