From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C836137FF6A; Thu, 20 Aug 2026 15:17:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787239072; cv=none; b=QKpKJHnzgQVFBcj6Fca3nl8UA6N4lqv0wlaeeg0LFmM32MUG83B23eYTUQG1pmpk5KHzsHfB+YIW0IG+GIqExWADaQMDC9elJss+Gp3BpnpsxjlsQtMoUnxYya2KfMsrPXoUr8gQkmN0s8lTnzmHhFnYohGHgfvYOvKCypAv8tQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787239072; c=relaxed/simple; bh=VpC1QWjfTYPO05gnrcF4yn0gOOUOuitYgOQC+z2NFBU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gFYL3EqoEHd/tiegbIWoH7wSaYRljU90d9Fk6Vqszv4pqYwj9jLpdAAqTYtYkg4WR0RV7Q9VcDTI071sObeXMN/UqvZLH38DPafyQMLdbAV7JAKGFwyCemYnAbCu1nA2zPwOt6aSR4lfIv9hiIgR+/4Oa3ve5Dnef/ZuLPa2oGc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XozXCv5X; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XozXCv5X" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F6591F000E9; Thu, 20 Aug 2026 15:17:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1787239071; bh=cAEbz9gOcaA57DNwVu6hEv/XHmCqPyWcQlTtt6NAk4Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=XozXCv5XzwiE94VMcjoxNU/cEa9CZQ87Phvyo1tL2WmnNXUKSbjfKHxbi0ykQKknj dClavYYR7iKbH3iQSvl/i36qZP+dEcWNf/ezTV8oQoBiRVVYS6shXQN87jKpJ1PpO1 HWag+6XgFP9fo5rnYLXZ30hU53+QV3WziqHtYJ0I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, David Howells , Namjae Jeon , ChenXiaoSong , Steve French , Sasha Levin Subject: [PATCH 6.18 140/217] smb/server: fix minimum SMB2 PDU size Date: Thu, 20 Aug 2026 16:55:08 +0200 Message-ID: <20260820145241.969271239@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260820145237.531699751@linuxfoundation.org> References: <20260820145237.531699751@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: ChenXiaoSong [ Upstream commit 4c7d8eb9a79ae5400eac19c4f6f0815bff674452 ] The minimum SMB2 PDU size should be updated to the size of `struct smb2_pdu` (that is, the size of `struct smb2_hdr` + 2). Suggested-by: David Howells Suggested-by: Namjae Jeon Signed-off-by: ChenXiaoSong Reviewed-by: David Howells Acked-by: Namjae Jeon Signed-off-by: Steve French Stable-dep-of: cfc0b8e5080a ("ksmbd: validate minimum PDU size for transform requests") Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- fs/smb/server/connection.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/fs/smb/server/connection.c +++ b/fs/smb/server/connection.c @@ -378,7 +378,7 @@ bool ksmbd_conn_alive(struct ksmbd_conn /* "+2" for BCC field (ByteCount, 2 bytes) */ #define SMB1_MIN_SUPPORTED_PDU_SIZE (sizeof(struct smb_hdr) + 2) -#define SMB2_MIN_SUPPORTED_HEADER_SIZE (sizeof(struct smb2_hdr) + 4) +#define SMB2_MIN_SUPPORTED_PDU_SIZE (sizeof(struct smb2_pdu)) /** * ksmbd_conn_handler_loop() - session thread to listen on new smb requests @@ -478,7 +478,7 @@ recheck: if (((struct smb2_hdr *)smb_get_msg(conn->request_buf))->ProtocolId == SMB2_PROTO_NUMBER) { - if (pdu_size < SMB2_MIN_SUPPORTED_HEADER_SIZE) + if (pdu_size < SMB2_MIN_SUPPORTED_PDU_SIZE) break; }