From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C59047ACE2 for ; Thu, 20 Aug 2026 16:26:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787243203; cv=none; b=AjzUPHEguHh60LSC8Ko2+EBrll3lQhgX6nh+fpMdidNKJcan0lWgmGmw2xa/sV6IuFgmPfgalA0dqu55LayXde2lPls+0X8JAxWGaD1ayQuCyRetbHBotCCc9LX9XnTxKw954SMGb32N/euZ+qQLTOwfeS4/c00ZLz0i52GEiOM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787243203; c=relaxed/simple; bh=w2UNwByDqxajgodIRJvWK1xHMSTglvfbTlyR0XEO6WM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kl65JH3tdUVga9s9IOHoDxjXtBbbpqU/Tv69tVPL1K8NAxFIsqYzjE2KhuK51APpult35Yrl0Qmr+cRD7p4OZXl+m8Gj27v0sxYDVzr4vJbMIHaU4sgFEkB8GWxnzXsHNnQyPWlHnBqRId6m/KN+Z9I/RgR3If3wXXFxL4OtxFQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sZEUSy2+; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sZEUSy2+" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2cace91f112so1021525ad.0 for ; Thu, 20 Aug 2026 09:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787243202; x=1787848002; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=iCo0FN/b32Haxtl0Z/7h5MxCz/K2NNpx7/lpltGLY70=; b=sZEUSy2+LKgx0MsuYhr5/j2imimsSgefRlaEKtOMHIog+0UrjZS7tfX3vp9T00drDt AUbVkw3EqSGzD7qO7nQFOL1SJuuCeMQe1H3PgmOPmAgB2BSlUCM68xnIFEWuODV4PBvU ICXywVSNRhVwF59WXNVq56UuMaFhZd1lcZHhJjc8K8halRKha+8vsx8oagFIVQYQDJMk A5XsnW/UbGin7nXgopEZ9QiYET20g7SqXU21TcW9otUGQ4ptYAOBGCT6W2WrH1p9qC61 9LSI/LtX4P80NfRoPLq7zfEvYqJsIUaPme/6/zY5TsxLKPfTUfq9xZRE7/HrtLcAsdIy myrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787243202; x=1787848002; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iCo0FN/b32Haxtl0Z/7h5MxCz/K2NNpx7/lpltGLY70=; b=N+QWoGhKYxOa8fhIsZU9pK166HBLWowdlrbncDQAvf2Inmt/sbHUCT6jT27fkYVFYM 0SDrosEchu3B9MBLowq/GzJps2e4QK67V1MPYulkofE64jOFNrpSJE/05cL398eWMjzs RXsjJlLwJhFprjF3akXzSIDNoWcolF/nhqdKB2Rr4b44QPT7acu0YJ46GBmiRH/PnGKQ oV9R3/cKvw6U/+qD7N5HJ/4ZfHyNfguO7Zs9kFjbpgr8xE3U59KkStAiiC++eeJ4qQMB A24zGqWReUrdRgmxPCdcr9cL+uYbX8q9+H8bkmyilgYUQwi8BzFYDz/2SBBSj71RV/69 sHlg== X-Forwarded-Encrypted: i=1; AHgh+RrgKQTrYcwGOitBNcmlYOOzyy4ZNkxbJUhuoOS9pXDBEVJabgPlU8QKYjZ+u1h8qi03zsreQ/3BGc2zfAE=@vger.kernel.org X-Gm-Message-State: AFuF++mtNcMf7f6ZOje49JFWkdD5+ka37TFEKy1Ku7jlSfVrxsBTZK+N sRuplXStVDfo2gbvX2dJldPrifI8PKsbFG/hcp0OWxiiq/g+Qk+kLyOtVHlAqvN+ X-Gm-Gg: AR+sD12GwEpeX1HJnOKmGw0uVnxexqweb8EgsxVreEFSqX+ddTqpOZwoxR8UoF3jxNl jYv7NkrRw389utwiP/VGOo4k8lQbWOGGG6K/E46TQDKIRw3fCJK/OllBHa9I5zaHSEktdc5K868 q30WWqleQUCDgZsxRf98YTFfsW4UunDv3Fx+IqO63npLaRbgPAgaBVzcpfCr6S4FezITljmACIR ReDYab3+GJG8SQr7HdSP3VDAGmRImJzzU2tyX+0i41no1LFkxtxg5lvjVuw0y4+BaQCWEdou3by bgJ2trwT2WAxrH65NZaUWrTIEzntlGUXQLyUVt/Qgt0qO8+ucjLmHF8fgt0khoRoKaB9e718NSg syA9dixGCZ7vFsINyvKEB8CYxsMA0v8n/juSpL3jI+EYK5ruPdFfWMr3L8GZMaXzFEQVkNEAMZm EqIT7zhNvuHAO0deYb6mvk6lVfzhGDcUSx5eJ67QPpt59zHtlmwLLHKVtMjqtKle6oQlkhWwgK3 EK9jLE= X-Received: by 2002:a17:902:ef43:b0:2c9:b8b7:5d27 with SMTP id d9443c01a7336-2d5fd5ff363mr271895055ad.1.1787243201598; Thu, 20 Aug 2026 09:26:41 -0700 (PDT) Received: from localhost.localdomain ([210.97.54.78]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d62d555f2esm9330225ad.5.2026.08.20.09.26.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 09:26:41 -0700 (PDT) From: "myeonghyeon.park" To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8723bs: reorder conditions to avoid else branch Date: Fri, 21 Aug 2026 01:26:01 +0900 Message-ID: <20260820162601.74952-1-myeonghyeon.park@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fix the checkpatch.pl warning: "WARNING: else is not generally useful after a break or return" in core/rtw_recv.c. Return early when the SN_EQUAL() condition is met and break when SN_LESS() condition is false to eliminate the unnecessary else branch. Signed-off-by: myeonghyeon.park --- drivers/staging/rtl8723bs/core/rtw_recv.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c index 7568fc514d7c..5776d0212ab8 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -1782,14 +1782,15 @@ static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl, un pnextrframe = (union recv_frame *)plist; pnextattrib = &pnextrframe->u.hdr.attrib; - if (SN_LESS(pnextattrib->seq_num, pattrib->seq_num)) - plist = get_next(plist); - else if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num)) + if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num)) /* Duplicate entry is found!! Do not insert current entry. */ /* spin_unlock_irqrestore(&ppending_recvframe_queue->lock, irql); */ return false; - else + + if (!SN_LESS(pnextattrib->seq_num, pattrib->seq_num)) break; + + plist = get_next(plist); } /* spin_lock_irqsave(&ppending_recvframe_queue->lock, irql); */ -- 2.52.0