From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC4EB3AEB2C; Thu, 20 Aug 2026 20:51:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787259105; cv=none; b=eJtDKCVYkARNjbONChE/AbuQuDtgeaWsNXSbQxeJPJuhDHezGWPRD30rymv4YAhySVxMUnb8cHycO51TtUQDewEQo+kYSvAX98Qal5LA64hgowalk/EaeCnW66Kg0TvNpBh4HpC7YjkYuFMOZe0zSvZaaaaQtexdJiy3UHZk5Vc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787259105; c=relaxed/simple; bh=qRh0HPHZk5aJjdEXjcfZZcVLFrPM/feZu19Hv5uvFBw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BSsJMslY9FsFjWpPuXeszuf7rpqXiMwTivmLL516oPPVaZbeSWC5Kgw3Jr7ZQDMwzhjOU4DeGDBJrsKFwzCGWiqQvOjWh0WRwz7KgtF/oMmOLDcC3687CFpv1mPlsLOjS+DFTPh3QfBHZurLe1oFLRerLKTOwiPPwB4UtgioM4w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WwS5elIy; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WwS5elIy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787259103; x=1818795103; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qRh0HPHZk5aJjdEXjcfZZcVLFrPM/feZu19Hv5uvFBw=; b=WwS5elIyKAKBtgzRvqgrnTTmzYTiQhCSGvfuT4sb3TpGow3/8ZdxVEC9 nDpjDARMDYncEX7WdcqcIhqnXZ4lkJ194f8aoKh7zpXCP9kWfFoqRnAlH ygwgk5Ns02YtEFT1JweqD0mEq0iMhc5flPEd6gS9XDH5+umJVxIcJcbkv J9XPK+P6I3wO0FgsTrI7zYuNIw3J9KZjJ9E7+rLyTuPeWrLiFXUmQhYPu 5qLD1fcaRSkjRp0tm0tdIMsn0Uv05Mj/ISOpY58GprDLGya3ULu1DO+aL tjVP3kRZRIbKHLf1zYedePhp9zbiPqtTxpnVw1vkP4entfr7Fb0KWd7pm w==; X-CSE-ConnectionGUID: J3pzxaWUSNKoirGk+IL0dA== X-CSE-MsgGUID: X0X7KLKTSsmdNTRvXdAG1g== X-IronPort-AV: E=McAfee;i="6800,10657,11881"; a="87868009" X-IronPort-AV: E=Sophos;i="6.25,233,1779174000"; d="scan'208";a="87868009" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2026 13:51:42 -0700 X-CSE-ConnectionGUID: EsvKG2gMQxKNEc5Imd2suw== X-CSE-MsgGUID: vTpL6I3HTiyrLmjFQlXyZA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,233,1779174000"; d="scan'208";a="264844352" Received: from conormcd-mobl2.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.245.149]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2026 13:51:41 -0700 Received: from punajuuri.localdomain (unknown [192.168.240.130]) by kekkonen.fi.intel.com (Postfix) with ESMTP id 3513A121291; Thu, 20 Aug 2026 23:51:48 +0300 (EEST) Received: from sailus by punajuuri.localdomain with local (Exim 4.98.2) (envelope-from ) id 1wx9jo-0000000CDCA-1MId; Thu, 20 Aug 2026 23:51:48 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: linux-media@vger.kernel.org Cc: Daniel Scally , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , platform-driver-x86@vger.kernel.org Subject: [PATCH 2/2] platform/x86: int3472: Fix uninitialised variable warning Date: Thu, 20 Aug 2026 23:51:48 +0300 Message-ID: <20260820205148.2910639-3-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260820205148.2910639-1-sakari.ailus@linux.intel.com> References: <20260820205148.2910639-1-sakari.ailus@linux.intel.com> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fix a smatch warning about uninitialised err_msg variable, by printing the error where it is handled. Signed-off-by: Sakari Ailus --- drivers/platform/x86/intel/int3472/discrete.c | 21 +++++++++---------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c index 6c729fcfce5d..cf8a58ef963b 100644 --- a/drivers/platform/x86/intel/int3472/discrete.c +++ b/drivers/platform/x86/intel/int3472/discrete.c @@ -329,7 +329,6 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, unsigned long gpio_flags; union acpi_object *obj; struct gpio_desc *gpio; - const char *err_msg; const char *con_id; int ret; @@ -375,7 +374,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, case INT3472_GPIO_TYPE_HOTPLUG_DETECT: ret = skl_int3472_map_gpio_to_sensor(int3472, agpio, con_id, gpio_flags); if (ret) - err_msg = "Failed to map GPIO pin to sensor\n"; + dev_err(int3472->dev, "Failed to map GPIO pin to sensor\n"); break; case INT3472_GPIO_TYPE_CLK_ENABLE: @@ -387,7 +386,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, gpio = skl_int3472_gpiod_get_from_temp_lookup(int3472, agpio, con_id, gpio_flags); if (IS_ERR(gpio)) { ret = PTR_ERR(gpio); - err_msg = "Failed to get GPIO\n"; + dev_err(int3472->dev, "Failed to get GPIO\n"); break; } @@ -395,14 +394,14 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, case INT3472_GPIO_TYPE_CLK_ENABLE: ret = skl_int3472_register_gpio_clock(int3472, gpio); if (ret) - err_msg = "Failed to register clock\n"; + dev_err(int3472->dev, "Failed to register clock\n"); break; case INT3472_GPIO_TYPE_PRIVACY_LED: case INT3472_GPIO_TYPE_STROBE: ret = skl_int3472_register_led(int3472, gpio, con_id); if (ret) - err_msg = "Failed to register LED\n"; + dev_err(int3472->dev, "Failed to register LED\n"); break; case INT3472_GPIO_TYPE_POWER_ENABLE: @@ -413,7 +412,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, ret = skl_int3472_register_regulator(int3472, gpio, enable_time_us, con_id, second_sensor); if (ret) - err_msg = "Failed to register regulator\n"; + dev_err(int3472->dev, "Failed to register regulator\n"); break; default: /* Never reached */ @@ -436,11 +435,11 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, int3472->ngpios++; ACPI_FREE(obj); - if (ret < 0) - return dev_err_probe(int3472->dev, ret, err_msg); - - /* Tell acpi_dev_get_resources() to not make a copy of the resource */ - return 1; + /* + * Either return an error or tell acpi_dev_get_resources() to not make a + * copy of the resource. + */ + return ret < 0 ? ret : 1; } int int3472_discrete_parse_crs(struct int3472_discrete_device *int3472) -- 2.47.3