All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nguyen Quang Le Kien <khiemtranzo532001@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	driver-core@lists.linux.dev
Subject: Re: [PATCH v2] driver core: avoid klist_remove() on unattached knode_driver
Date: Thu, 20 Aug 2026 09:05:24 +0200	[thread overview]
Message-ID: <2026082028-celibacy-unclothed-42da@gregkh> (raw)
In-Reply-To: <20260820065606.78768-1-khiemtranzo532001@gmail.com>

On Thu, Aug 20, 2026 at 02:56:06PM +0800, Nguyen Quang Le Kien wrote:
> Hi Greg,

Please provide email context when responding, some of us get 1000+
emails a day.

> v1 used klist_node_attached(&dev->p->knode_driver). v1 passed the syzbot
> test, but after reviewing the code again I realized klist_node_attached()
> isn't really the right check at that level -- it's a raw klist API.

Then please document this in the proper place, for v2, as required.

thanks,

greg k-h

  reply	other threads:[~2026-08-20  7:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20  5:55 [PATCH] driver core: avoid klist_remove() on unattached knode_driver Nguyen Quang Le Kien
2026-08-20  6:05 ` [PATCH v2] " Nguyen Quang Le Kien
2026-08-20  6:40   ` Greg KH
2026-08-20  6:56     ` Nguyen Quang Le Kien
2026-08-20  7:05       ` Greg Kroah-Hartman [this message]
2026-08-20  7:45     ` [PATCH v3] " Nguyen Quang Le Kien
2026-08-20  8:23       ` Greg Kroah-Hartman
2026-08-20  8:45         ` [PATCH v4] " Nguyen Quang Le Kien
2026-08-20  8:56           ` Greg KH
2026-08-20 16:14           ` Danilo Krummrich
2026-08-20 17:22             ` Alan Stern
2026-08-20 20:54               ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026082028-celibacy-unclothed-42da@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=driver-core@lists.linux.dev \
    --cc=khiemtranzo532001@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.