All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamin Lin <jamin_lin@aspeedtech.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Steven Lee" <steven_lee@aspeedtech.com>,
	"Troy Lee" <leetroy@gmail.com>,
	"Kane Chen" <kane_chen@aspeedtech.com>,
	"Andrew Jeffery" <andrew@codeconstruct.com.au>,
	"Joel Stanley" <joel@jms.id.au>, "Eric Blake" <eblake@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Fabiano Rosas" <farosas@suse.de>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"open list:All patches CC here" <qemu-devel@nongnu.org>,
	"open list:ASPEED BMCs" <qemu-arm@nongnu.org>
Cc: Jamin Lin <jamin_lin@aspeedtech.com>, Troy Lee <troy_lee@aspeedtech.com>
Subject: [PATCH v2 0/9] Add ECDSA akcipher support and the ASPEED SBC ECDSA engine for AST10x0
Date: Fri, 21 Aug 2026 03:20:37 +0000	[thread overview]
Message-ID: <20260821032036.1829294-1-jamin_lin@aspeedtech.com> (raw)

This series depends on:

 1. [v2,0/4] Add ASPEED ACRY RSA model for the AST2600
    https://patchwork.kernel.org/project/qemu-devel/cover/20260820081206.3353463-1-jamin_lin@aspeedtech.com/

This series adds ECDSA to the QEMU crypto akcipher framework and models the
ASPEED AST10x0 secure boot controller (SBC) ECDSA engine on top of it.

The crypto side adds ECDSA sign/verify for prime256v1 (NIST P-256) and
secp384r1 (NIST P-384) in both the gcrypt and nettle backends, using the raw
big-endian form (public key Qx || Qy, private key scalar d, signature r || s)
with a pre-computed digest as input.

Both the AST2600 and the AST1030/AST1060 have a Secure Boot Controller (SBC)
that supports RSA and ECDSA verification, but only the AST1030/AST1060 have an
ECDSA verify engine, so this series models ECDSA only. RSA verification is used
solely to verify the AST2600 SPL in ROM CODE, which ASPEED does not release,
so it is very unlikely to be used by end users.

v1:
 1. Add ECDSA akcipher support with gcrypt backend
 2. Add ECDSA akcipher support with nettle backend
 3. Add ECDSA sign/verify unit tests
 4. Support the ECDSA verify command for AST10x0
 5. Add ASPEED SBC ECDSA engine qtest

v2:
 1. Wrap the SEC SRAM in a container mapped at offset 0 so the device
    addresses it by relative offset (drop the "sram-base" property)
 2. Add a patch removing the obsolete unimplemented SBC mapping
 3. Add Qtest to ast1060-evb machine.
 4. Rename R_ECDSA_CMD to R_SEC_TRIGGER, since the register
    triggers both the RSA and ECDSA engines.

Jamin Lin (9):
  qapi/crypto: Add ECDSA algorithm and curve id
  crypto/akcipher: Support ECDSA sign/verify with gcrypt
  crypto/akcipher: Support ECDSA sign/verify with nettle
  hw/arm/aspeed_ast10x0: Remove obsolete unimplemented SBC mapping
  tests/crypto: Add ECDSA sign/verify tests
  hw/misc/aspeed_sbc: Support the ECDSA verify command
  hw/misc/aspeed_sbc: Increase register space to 0x1000
  hw/arm/aspeed_ast10x0: Wire SEC SRAM to the SBC model
  tests/qtest: Add ASPEED SBC ECDSA engine test

 qapi/crypto.json                  |  33 ++-
 include/hw/misc/aspeed_sbc.h      |   6 +-
 hw/arm/aspeed_ast10x0.c           |  14 +-
 hw/misc/aspeed_sbc.c              | 158 +++++++++++++-
 tests/qtest/aspeed-sbc-test.c     | 193 ++++++++++++++++++
 tests/unit/test-crypto-akcipher.c | 236 +++++++++++++++++++++
 crypto/akcipher-gcrypt.c.inc      | 328 +++++++++++++++++++++++++++++-
 crypto/akcipher-nettle.c.inc      | 267 ++++++++++++++++++++++++
 hw/misc/trace-events              |   2 +
 tests/qtest/meson.build           |   2 +
 10 files changed, 1224 insertions(+), 15 deletions(-)
 create mode 100644 tests/qtest/aspeed-sbc-test.c

-- 
2.53.0


             reply	other threads:[~2026-08-21  3:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21  3:20 Jamin Lin [this message]
2026-08-21  3:20 ` [PATCH v2 1/9] qapi/crypto: Add ECDSA algorithm and curve id Jamin Lin
2026-08-21  3:20 ` [PATCH v2 2/9] crypto/akcipher: Support ECDSA sign/verify with gcrypt Jamin Lin
2026-08-21  3:20 ` [PATCH v2 3/9] crypto/akcipher: Support ECDSA sign/verify with nettle Jamin Lin
2026-08-21  3:20 ` [PATCH v2 4/9] hw/arm/aspeed_ast10x0: Remove obsolete unimplemented SBC mapping Jamin Lin
2026-08-21  3:20 ` [PATCH v2 5/9] tests/crypto: Add ECDSA sign/verify tests Jamin Lin
2026-08-21  3:20 ` [PATCH v2 6/9] hw/misc/aspeed_sbc: Support the ECDSA verify command Jamin Lin
2026-08-21  3:20 ` [PATCH v2 7/9] hw/misc/aspeed_sbc: Increase register space to 0x1000 Jamin Lin
2026-08-21  3:20 ` [PATCH v2 8/9] hw/arm/aspeed_ast10x0: Wire SEC SRAM to the SBC model Jamin Lin
2026-08-21  3:20 ` [PATCH v2 9/9] tests/qtest: Add ASPEED SBC ECDSA engine test Jamin Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260821032036.1829294-1-jamin_lin@aspeedtech.com \
    --to=jamin_lin@aspeedtech.com \
    --cc=andrew@codeconstruct.com.au \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=clg@kaod.org \
    --cc=eblake@redhat.com \
    --cc=farosas@suse.de \
    --cc=joel@jms.id.au \
    --cc=kane_chen@aspeedtech.com \
    --cc=leetroy@gmail.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=steven_lee@aspeedtech.com \
    --cc=troy_lee@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.