From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6A09C5DF88 for ; Fri, 21 Aug 2026 06:21:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7742710F223; Fri, 21 Aug 2026 06:21:17 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="bQtRF4vS"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5673F10F22F for ; Fri, 21 Aug 2026 06:20:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1787293240; x=1818829240; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=svz9iE1pcAiqsthLCbdAG5uB4/mMRqsx76kGi78HEKc=; b=bQtRF4vSox0bzVBwuKm8jKDXPWZsUoYYK/Q48fqdULubhLEu1w7zSKxU A4YzKogJaDSK2haKRRvVWhiwmcoPKK5np5tto+7KfFlnhVdZym4XZ/s26 vPWEDjpaZHAVvUKEtuFj63BETXmS8arcjO1YVEkTGkcO2F3QIlnYn2dct BIOYiavM455v9RrJCYX39sQS1yfJdhHcrSvagGZJkoJBzMNeJ41lkIGAw 2iNGhvY6HQjQhoNW2C/ibB1Ke2ubS7AWIJrP2s+QtLi5bbuuPzbADaRlu OPa4agvnry/YidhTTzsfQ3x7CObo6NGR6v4lHoxQnrraFnEX3jWXc2Qhb w==; X-CSE-ConnectionGUID: F1aEs7OwT5SXiHpS2wHDSw== X-CSE-MsgGUID: gulU2uzVSBSLl2kmG3UZkA== X-IronPort-AV: E=McAfee;i="6800,10657,11881"; a="87965463" X-IronPort-AV: E=Sophos;i="6.25,234,1779174000"; d="scan'208";a="87965463" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2026 23:20:39 -0700 X-CSE-ConnectionGUID: lzsNCYcoR8Gol8cWI73ARA== X-CSE-MsgGUID: cICSks2RRGSWvZgrfJJX5Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,234,1779174000"; d="scan'208";a="304441923" Received: from nitin-super-server.iind.intel.com ([10.190.238.72]) by orviesa001.jf.intel.com with ESMTP; 20 Aug 2026 23:20:37 -0700 From: Nitin Gote To: igt-dev@lists.freedesktop.org Cc: Nitin Gote , Matthew Auld , Janusz Krzysztofik , Kamil Konieczny Subject: [PATCH] tests/core_hotunplug: add *-with-load subtests exercising GPU workload during hotplug Date: Fri, 21 Aug 2026 12:28:39 +0530 Message-ID: <20260821065838.1865108-2-nitin.r.gote@intel.com> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" The six fd-holding hot* subtests keep a DRM fd open across unbind/unplug but leave the GPU idle, so the kernel hotplug path is never exercised against an active workload. Add six new dedicated *-with-load subtests that run a GPU spinner across the unbind/unplug sequence so the device is removed while a workload is actively using it. The workload helpers use an explicit chipset dispatch block in workload_start()/stop() so that other vendors can contribute support by adding an else-if branch. New subtests are gated on workload_available(), which currently covers DRIVER_XE and DRIVER_INTEL, and returns false (SKIP) on any other driver. igt_spin_free() is avoided in workload_stop() since the device may be gone by then -- igt_spin_end() writes the stop condition via a userspace mmap and lets the DRM fd close reclaim kernel-side resources. Validated on BMG and DG2 with a KASAN-enabled kernel: all six new subtests pass with no KASAN reports. v4: Rebase to latest igt. Also the failure seen with the new core_hotunplug "with-load" IGT subtests is fixed by kmd patch: https://patchwork.freedesktop.org/series/171989/ v3: Extend struct gpu_workload with a union of vendor-named members to match the chipset dispatch in workload_start()/stop(). (Janusz) v2: Pass the hotunplug priv struct to workload_start()/stop() and dispatch via an explicit if/else-if chipset block to invite other vendors to contribute. (Janusz) Cc: Matthew Auld Cc: Janusz Krzysztofik Cc: Kamil Konieczny Reviewed-by: Janusz Krzysztofik Signed-off-by: Nitin Gote --- tests/core_hotunplug.c | 294 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 294 insertions(+) diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c index 33de65369..b11a4231b 100644 --- a/tests/core_hotunplug.c +++ b/tests/core_hotunplug.c @@ -80,6 +80,34 @@ * SUBTEST: unplug-rescan * Description: Check if a device believed to be closed can be cleanly * unplugged, then restored + * + * SUBTEST: hotunbind-rebind-with-load + * Description: Check if the driver can be cleanly unbound from an open device + * with a background GPU workload in flight, then released and + * rebound + * + * SUBTEST: hotunplug-rescan-with-load + * Description: Check if an open device with a background GPU workload in + * flight can be cleanly unplugged, then released and restored + * + * SUBTEST: hotrebind-with-load + * Description: Check if the driver can be cleanly rebound to a device with a + * still open hot unbound driver instance while a background GPU + * workload is in flight + * + * SUBTEST: hotreplug-with-load + * Description: Check if a hot unplugged and still open device can be cleanly + * restored while a background GPU workload is in flight + * + * SUBTEST: hotrebind-lateclose-with-load + * Description: Check if a hot unbound driver instance still open after hot + * rebind with a background GPU workload in flight can be cleanly + * released + * + * SUBTEST: hotreplug-lateclose-with-load + * Description: Check if an instance of a still open while hot replugged + * device with a background GPU workload in flight can be cleanly + * released */ IGT_TEST_DESCRIPTION("Examine behavior of a driver on device hot unplug"); @@ -550,6 +578,56 @@ static void post_healthcheck(struct hotunplug *priv) cleanup(priv); } +/* GPU workload helpers */ + +struct gpu_workload { + union { + struct { + igt_spin_t *spin; + uint64_t ahnd; + } intel; /* Xe and i915 */ + }; +}; + +static bool workload_available(int chipset) +{ + return chipset == DRIVER_XE || chipset == DRIVER_INTEL; +} + +static void workload_start(struct hotunplug *priv, int fd, + struct gpu_workload *w) +{ + if (priv->chipset == DRIVER_XE || priv->chipset == DRIVER_INTEL) { + local_debug("%s\n", "starting GPU spinner"); + priv->failure = "GPU workload start failure!"; + w->intel.ahnd = intel_allocator_open(fd, 0, INTEL_ALLOCATOR_RELOC); + w->intel.spin = igt_spin_new(fd, .ahnd = w->intel.ahnd); + priv->failure = NULL; + } +} + +static void workload_stop(struct hotunplug *priv, struct gpu_workload *w) +{ + if (priv->chipset == DRIVER_XE || priv->chipset == DRIVER_INTEL) { + if (!w->intel.spin) + return; + + /* + * The device may be gone (unbind/unplug), so avoid + * igt_spin_free(): on Xe it would wait forever on a syncobj + * that never signals; on i915 it would touch the dead fd via + * gem_munmap()/gem_close(). Instead, end the spinner via a + * userspace mmap write and let the DRM fd close reclaim the + * kernel-side resources. + */ + local_debug("%s\n", "stopping GPU spinner"); + igt_spin_end(w->intel.spin); + put_ahnd(w->intel.ahnd); + w->intel.spin = NULL; + w->intel.ahnd = 0; + } +} + /* Subtests */ static void unbind_rebind(struct hotunplug *priv) @@ -664,6 +742,150 @@ static void hotreplug_lateclose(struct hotunplug *priv) igt_assert_f(healthcheck(priv, false), "%s\n", priv->failure); } +static void hotunbind_rebind_with_load(struct hotunplug *priv) +{ + struct gpu_workload w = { 0 }; + + pre_check(priv); + + igt_require_f(workload_available(priv->chipset), + "No GPU workload support for this driver\n"); + + priv->fd.drm = local_drm_open_driver(false, "", " for hot unbind"); + + workload_start(priv, priv->fd.drm, &w); + + driver_unbind(priv, "hot ", 0); + + workload_stop(priv, &w); + + priv->fd.drm = close_device(priv->fd.drm, "late ", "unbound "); + igt_assert_eq(priv->fd.drm, -1); + + driver_bind(priv, 0); + + igt_assert_f(healthcheck(priv, false), "%s\n", priv->failure); +} + +static void hotunplug_rescan_with_load(struct hotunplug *priv) +{ + struct gpu_workload w = { 0 }; + + pre_check(priv); + + igt_require_f(workload_available(priv->chipset), + "No GPU workload support for this driver\n"); + + priv->fd.drm = local_drm_open_driver(false, "", " for hot unplug"); + + workload_start(priv, priv->fd.drm, &w); + + device_unplug(priv, "hot ", 0); + + workload_stop(priv, &w); + + priv->fd.drm = close_device(priv->fd.drm, "late ", "removed "); + igt_assert_eq(priv->fd.drm, -1); + + bus_rescan(priv, 0); + + igt_assert_f(healthcheck(priv, false), "%s\n", priv->failure); +} + +static void hotrebind_with_load(struct hotunplug *priv) +{ + struct gpu_workload w = { 0 }; + + pre_check(priv); + + igt_require_f(workload_available(priv->chipset), + "No GPU workload support for this driver\n"); + + priv->fd.drm = local_drm_open_driver(false, "", " for hot rebind"); + + workload_start(priv, priv->fd.drm, &w); + + driver_unbind(priv, "hot ", 60); + + driver_bind(priv, 0); + + workload_stop(priv, &w); + + igt_assert_f(healthcheck(priv, false), "%s\n", priv->failure); +} + +static void hotreplug_with_load(struct hotunplug *priv) +{ + struct gpu_workload w = { 0 }; + + pre_check(priv); + + igt_require_f(workload_available(priv->chipset), + "No GPU workload support for this driver\n"); + + priv->fd.drm = local_drm_open_driver(false, "", " for hot replug"); + + workload_start(priv, priv->fd.drm, &w); + + device_unplug(priv, "hot ", 60); + + bus_rescan(priv, 0); + + workload_stop(priv, &w); + + igt_assert_f(healthcheck(priv, false), "%s\n", priv->failure); +} + +static void hotrebind_lateclose_with_load(struct hotunplug *priv) +{ + struct gpu_workload w = { 0 }; + + pre_check(priv); + + igt_require_f(workload_available(priv->chipset), + "No GPU workload support for this driver\n"); + + priv->fd.drm = local_drm_open_driver(false, "", " for hot rebind"); + + workload_start(priv, priv->fd.drm, &w); + + driver_unbind(priv, "hot ", 60); + + driver_bind(priv, 0); + + workload_stop(priv, &w); + + priv->fd.drm = close_device(priv->fd.drm, "late ", "unbound "); + igt_assert_eq(priv->fd.drm, -1); + + igt_assert_f(healthcheck(priv, false), "%s\n", priv->failure); +} + +static void hotreplug_lateclose_with_load(struct hotunplug *priv) +{ + struct gpu_workload w = { 0 }; + + pre_check(priv); + + igt_require_f(workload_available(priv->chipset), + "No GPU workload support for this driver\n"); + + priv->fd.drm = local_drm_open_driver(false, "", " for hot replug"); + + workload_start(priv, priv->fd.drm, &w); + + device_unplug(priv, "hot ", 60); + + bus_rescan(priv, 0); + + workload_stop(priv, &w); + + priv->fd.drm = close_device(priv->fd.drm, "late ", "removed "); + igt_assert_eq(priv->fd.drm, -1); + + igt_assert_f(healthcheck(priv, false), "%s\n", priv->failure); +} + /* Main */ int igt_main() @@ -802,6 +1024,78 @@ int igt_main() recover(&priv); } + igt_fixture() + post_healthcheck(&priv); + + igt_subtest_group() { + igt_describe("Check if the driver can be cleanly unbound from an open device with a background GPU workload in flight, then released and rebound"); + igt_subtest("hotunbind-rebind-with-load") + hotunbind_rebind_with_load(&priv); + + igt_fixture() + recover(&priv); + } + + igt_fixture() + post_healthcheck(&priv); + + igt_subtest_group() { + igt_describe("Check if an open device with a background GPU workload in flight can be cleanly unplugged, then released and restored"); + igt_subtest("hotunplug-rescan-with-load") + hotunplug_rescan_with_load(&priv); + + igt_fixture() + recover(&priv); + } + + igt_fixture() + post_healthcheck(&priv); + + igt_subtest_group() { + igt_describe("Check if the driver can be cleanly rebound to a device with a still open hot unbound driver instance while a background GPU workload is in flight"); + igt_subtest("hotrebind-with-load") + hotrebind_with_load(&priv); + + igt_fixture() + recover(&priv); + } + + igt_fixture() + post_healthcheck(&priv); + + igt_subtest_group() { + igt_describe("Check if a hot unplugged and still open device can be cleanly restored while a background GPU workload is in flight"); + igt_subtest("hotreplug-with-load") + hotreplug_with_load(&priv); + + igt_fixture() + recover(&priv); + } + + igt_fixture() + post_healthcheck(&priv); + + igt_subtest_group() { + igt_describe("Check if a hot unbound driver instance still open after hot rebind with a background GPU workload in flight can be cleanly released"); + igt_subtest("hotrebind-lateclose-with-load") + hotrebind_lateclose_with_load(&priv); + + igt_fixture() + recover(&priv); + } + + igt_fixture() + post_healthcheck(&priv); + + igt_subtest_group() { + igt_describe("Check if an instance of a still open while hot replugged device with a background GPU workload in flight can be cleanly released"); + igt_subtest("hotreplug-lateclose-with-load") + hotreplug_lateclose_with_load(&priv); + + igt_fixture() + recover(&priv); + } + igt_fixture() { post_healthcheck(&priv); -- 2.50.1