From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 065C625228C for ; Fri, 21 Aug 2026 07:19:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787296744; cv=none; b=Gty0efuiAvK3sdEOjvafIyTgfq1uD1x1A0UKLogb6R04R7Pc0lZQdQdEuZGJbTQW+Mp1BbNprTA+QsKoxS3cFfArg478MxiYyVNvCpy7MZXlB8qvGbtnZdVAYCQGyhxHtr0QXB1HKIrP4l9Ojh9dJV51Wkw7Sz5bEG1EqXb1IRo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787296744; c=relaxed/simple; bh=c+RtY8Hj7VdofOImWrU9SuKEvS7NY1GyVex+IlCJM84=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jhOiUq1YT/mZvjPhBMFedUI+cdsWYfjnmJoWvRMdtTykoW1JjgnZD0kfPYMUqKPiCH6mHE4aoUUThB0kZKhC8d6UaZTy0tF/Zx9SV0rj9jR1cgmHagG1hnTw1eS2VcnwL3lq+NGsBchqyvVt04MycDg1m51KZbbxIpnofSYwrDk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NwZWLDbq; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NwZWLDbq" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-38f620399a0so546011a91.2 for ; Fri, 21 Aug 2026 00:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787296742; x=1787901542; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=xDp4rmhAwTlJo2Sslrv1XZ29SdV6qudtW+6TKgzPyrc=; b=NwZWLDbq1L/U8PUwK08/qKx8t0cxEcMWB7QMHb83c/r1sdzLMUhKlKUPoH4nT9k0me 5JODVSpyy67Wqj55fiNxLH3PefQNznLIUVrpxaZxZjQN+0a9jxy+7l+g/NN5PggZhY8v 6gcT9VRahy2kaYExr7SjsZqP/3MQeV2TIf2Z0BXa5D4S26QEPlMNdfR5NUsiGKqzYJ3+ YVXqDYE9IW4M7V1zTSJTz0K6mmZu7bln4mRukkVlhGaU6oGYj/aSVpBIBCiqLeMSKyMB Vo4/CH3C3qER97vOhWy+ECaxsMmqQxkOfIgeus87d5FhGdem4xFG+w2q2EZRgMBt6aXB r3Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787296742; x=1787901542; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xDp4rmhAwTlJo2Sslrv1XZ29SdV6qudtW+6TKgzPyrc=; b=p3foi4m8Nl53QZ+5ccALShY/8vm9uqTKl6o19/cWuhbHM9w+gCd947iEc7wQoCnePh NQaPJdmEqqVmpqufeChCmkJN/LhAO58k80UHmMpaVnCj0G7PEeFnuWA5zCtDLqpUfVi9 3FwK4l1l0/UT0efS0ZXu0nByAVOGR3Oj02rTkby5UbF4vbAOFYqW1/V/4Wl9sRz/kvPY PBVBZEdbD+UsDmsKwpgXXYrI1i2kZxwP+imR+MzadfV8kQVWC2UCUF+eMueLk7qURLzD yPX/Tta01/7J3H3UejqxlLm3er6cZJ2npSCYXig+jD6JpwK3OOSvbR44K9FGUBJMB22n PRRQ== X-Forwarded-Encrypted: i=1; AHgh+Rr9aWqJPwMLBSnyjKPbf/Aa1g1Jh3PrAl0Ztbps5RYmVJcvj3CJ2KLqUA2GnFihK9YDrcC2aMg2+rJGa/I=@vger.kernel.org X-Gm-Message-State: AFuF++mnJM8ZTpiztrpVToir7aJfkkltiH7Z2Aqfh+3GEIYsoHou4OXO 0S7ZK456uZGfr5nK78m+AHYjEFq+8gioCOnjG/8kvbhTq8ZyEgQir3GM X-Gm-Gg: AR+sD10enw65PNcseaFSGyD90rLxNHeBOMHnqaiQXsMeaNCvGMP+9Jq+0cO0yKGrMyn n/F1cKRf9c3/mMEvjFaaqpAA/h592agwyW8Dw81SjjyEZSxg6vAOn/dvFEWtgLSwG8rVbWwWKD1 GiT+Ldy6Y8R06Dw1YpI8fDd9BU1q79ZEV4Qxd0s92fzgecDWEv66F2bGPgPkyDd0+YtfSLck3oA Aew9XKrabHrr3xU8RkXRdbMfsquHwYAxf+TaLCr0aKwWXB1IOAyIujIXhTx7b6Ggrz32owSJPYx CSFhSH9DL8nbVTEBUYjmyrUAH9WAK0uIT7TjzGjL3D/H7OgBVtwr5S9UhErAM50ozE01O9xSrHT eknXJrm2a6O4HOHNPLB1pZAYrQbAeifaLCSKRp0WJ6aCZajpXtLdwMgm/0HBpIqIN/DtDOY3hBS aT9rIh4wcBrGC7ZPiNzIYUfs/oH4CmdeWz7mZkC2K0AZkwbAuIBTD3rjC5d0mi X-Received: by 2002:a17:90b:4a:b0:38e:4cb:51f with SMTP id 98e67ed59e1d1-395c352f984mr6908265a91.11.1787296742134; Fri, 21 Aug 2026 00:19:02 -0700 (PDT) Received: from fedora ([111.223.30.106]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1416ae5f1ffsm36733073c88.13.2026.08.21.00.18.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Aug 2026 00:19:01 -0700 (PDT) From: Sajal Gupta To: rubenru09@aol.com Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, syzbot+efe2810681f1b065d3a8@syzkaller.appspotmail.com, Sajal Gupta Subject: [PATCH] drm/gud: validate GUD_ROTATION_0 is present in supported rotations Date: Fri, 21 Aug 2026 12:46:13 +0530 Message-ID: <20260821071812.16500-1-sajal2005gupta@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The rotation argument to drm_plane_create_rotation_property() is set to DRM_MODE_ROTATE_0, and the device reported rotation bitmask is used as the supported_rotations argument. The driver never validates that GUD_ROTATION_0 is present, so a device that omits it from its GUD_PROPERTY_ROTATION triggers the WARN_ON(rotation & ~supported_rotations) in drm_plane_create_rotation_property() Fix this by skipping the creation of rotation property if the device doesn't have the GUD_ROTATION_0 bit Fixes: 40e1a70b4aed ("drm: Add GUD USB Display driver") Reported-by: syzbot+efe2810681f1b065d3a8@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=efe2810681f1b065d3a8 Tested-by: syzbot+efe2810681f1b065d3a8@syzkaller.appspotmail.com Signed-off-by: Sajal Gupta --- drivers/gpu/drm/gud/gud_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/gud/gud_drv.c b/drivers/gpu/drm/gud/gud_drv.c index 89bd6ca36003..3a1b9e2a2eaa 100644 --- a/drivers/gpu/drm/gud/gud_drv.c +++ b/drivers/gpu/drm/gud/gud_drv.c @@ -289,6 +289,8 @@ static int gud_plane_add_properties(struct gud_device *gdrm) * but mask out any additions on future devices. */ val &= GUD_ROTATION_MASK; + if (!(val & GUD_ROTATION_0)) + continue; ret = drm_plane_create_rotation_property(&gdrm->plane, DRM_MODE_ROTATE_0, val); break; -- 2.55.0