Re: [PATCH v2 01/14] perf cs-etm: Fix nVHE per-thread decoding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [Low] Missing explicit POSIX libc header inclusions for functions and constants used in `cs-etm.c`.
--

--- Patch [1]: [PATCH v2 01/14] perf cs-etm: Fix nVHE per-thread decoding ---
commit 0b1cec5f0bbf916c101f1e3a2c758642b42382ed
Author: James Clark <james.clark@linaro.org>

perf cs-etm: Fix nVHE per-thread decoding

This commit fixes the EL host/guest detection logic in cs-etm. It prevents
accidentally falling through to guest machine processing by assuming
everything is the host when perf_guest is not enabled.

> diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
> index 114b3cd2da495..d423f1cb408fa 100644
> --- a/tools/perf/util/cs-etm.c
> +++ b/tools/perf/util/cs-etm.c

[Severity: Low]
This is a pre-existing issue, but the file tools/perf/util/cs-etm.c appears
to be missing explicit POSIX libc header inclusions such as <string.h> and
<stdio.h>.

Currently, the file's include section starts with:

#include <limits.h>
#include <linux/bitfield.h>

Could the missing system headers be added at the top of the file to prevent
compilation failures on strict libc implementations like musl?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260821-james-cs-unformatted-per-thread-fix-v2-0-00c4fd0701b4@linaro.org?part=1