From: sashiko-bot@kernel.org
To: "Marek Vasut" <marek.vasut+renesas@mailbox.org>
Cc: wsa+renesas@sang-engineering.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 1/2] PCI: dwc: Add .post_deinit counterpart to endpoint .pre_init callback
Date: Fri, 21 Aug 2026 12:37:18 +0000 [thread overview]
Message-ID: <20260821123719.01FF81F01558@smtp.kernel.org> (raw)
In-Reply-To: <20260821122808.238248-1-marek.vasut+renesas@mailbox.org>
> If .pre_init() succeeds but subsequent initialization fails, it is
> mandatory to correctly undo the hardware configuration which the
> .pre_init() callback did. Intrododuce .post_deinit() callback to do
> exactly that, undo what the .pre_init() callback did. Usually, that
> means stop the clock, assert reset, and possibly program some registers
> to quiescense the hardware. Invoke the .post_deinit() callback in
> dw_pcie_ep_deinit() to retain functional symmetry.
>
> Reviewed-by: Koichiro Den <den@valinux.co.jp>
> Tested-by: Koichiro Den <den@valinux.co.jp>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260821122808.238248-1-marek.vasut+renesas@mailbox.org?part=1
next prev parent reply other threads:[~2026-08-21 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 12:27 [PATCH v3 1/2] PCI: dwc: Add .post_deinit counterpart to endpoint .pre_init callback Marek Vasut
2026-08-21 12:27 ` [PATCH v3 2/2] PCI: dwc: rcar-gen4: Use .post_deinit to handle dw_pcie_ep_init() failures Marek Vasut
2026-08-21 12:44 ` sashiko-bot
2026-08-21 12:37 ` sashiko-bot [this message]
2026-09-01 14:29 ` [PATCH v3 1/2] PCI: dwc: Add .post_deinit counterpart to endpoint .pre_init callback Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260821123719.01FF81F01558@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marek.vasut+renesas@mailbox.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.