Re: [PATCH v4 3/7] arm64: dts: qcom: Add Motorola One

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `dai@22` and `dai@127` node names use decimal unit-addresses instead of hexadecimal, causing a mismatch with their `reg` properties.
--

--- Patch [3]: [PATCH v4 3/7] arm64: dts: qcom: Add Motorola One ---
commit bc96bd20e17e79acc946f76b450ae2f6d79d33a8
Author: Adam Skladowski <a39.skl@gmail.com>

arm64: dts: qcom: Add Motorola One

Add a devicetree for the Motorola One smartphone, which is based
on the Jacala/MSM8953 SoC. Supported functionality includes I2C
peripherals, keys, regulators, remoteprocs, and USB.

> diff --git a/arch/arm64/boot/dts/qcom/msm8953-motorola-deen.dts b/arch/arm64/boot/dts/qcom/msm8953-motorola-deen.dts
> new file mode 100644
> index 0000000000000..4bc407e23580b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/msm8953-motorola-deen.dts
[ ... ]
> +&q6afedai {
> +	dai@22 {
> +		reg = <QUATERNARY_MI2S_RX>;
> +		qcom,sd-lines = <0>;
> +	};
> +
> +	dai@127 {
> +		reg = <QUINARY_MI2S_RX>;
> +		qcom,sd-lines = <1>;
> +	};
> +};

[Severity: Low]
Should these node names use hexadecimal unit-addresses (dai@16 and dai@7f)
to match the evaluated values of their reg properties?

The macros QUATERNARY_MI2S_RX and QUINARY_MI2S_RX evaluate to 22 (0x16) and
127 (0x7F) respectively. The Device Tree specification requires the
unit-address in a node name to match the first address specified in its reg
property formatted in hexadecimal. Using decimal values here will likely cause
the dtc compiler to emit simple_bus_reg warnings during the build.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260821-next-patches-v4-0-7ab02c0d4eb9@gmail.com?part=3