From: sashiko-bot@kernel.org
To: "Guenter Roeck" <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 1/2] hwmon: (sht4x) Add missing locks
Date: Fri, 21 Aug 2026 15:00:45 +0000 [thread overview]
Message-ID: <20260821150046.349B01F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260821144916.2889031-1-linux@roeck-us.net>
> Sashiko reports:
>
> Heater sysfs callbacks (heater_enable_store, heater_power_store, and
> heater_time_store) are exposed to data races without the hwmon lock.
>
> If a user-space process reads hwmon data while another process enables
> the heater, heater_enable_store() executes without holding
> hwmon_lock(dev). This can interleave I2C commands and mutate shared
> state (data->heating_complete and data->data_pending) concurrently
> with sht4x_read_values(), leading to corrupted I2C sequences.
>
> Fixes: 53dfa12299c1 ("hwmon: (sht4x) Rely on subsystem locking")
> Cc: Alessandro Zini <alessandro.zini@siemens.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260821144916.2889031-1-linux@roeck-us.net?part=1
prev parent reply other threads:[~2026-08-21 15:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 14:49 [PATCH 1/2] hwmon: (sht4x) Add missing locks Guenter Roeck
2026-08-21 14:49 ` [PATCH 2/2] hwmon: (sht4x) Fix return value from heater_enable_store() Guenter Roeck
2026-08-21 15:01 ` sashiko-bot
2026-08-21 15:00 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260821150046.349B01F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.