From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E2F440DB4A for ; Fri, 21 Aug 2026 19:35:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787340926; cv=none; b=q3xpKPnfbCa/C9wTdWoLACi7XihYw4T2BFZwkLTiTmx1jCPlfvTACtVqozW/pjc55D+MX0MwUrLnXD9kfNGa1M7zhL1aECYlkq+Fo5MxRMkQAJUbQoTEb3rZZrXm/SiB1GVt72naQD7J1/n+7eq3oQycsnUVGCKh4pNt2pf2cEQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787340926; c=relaxed/simple; bh=JvuSdU2NOvYivNrD9n2RJ/WKSyhX0/8eRQQFZc+/tC0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nsdy7jtk7NKfvBvxdX5H90IAB4/OoqQXfWPzKFJoOTh3p619DFIhypiE4N2yTDzbb8TbcrjYF/aiQHkQ5iiDfDxJx+2hApn7FJxtOPuB+R+3CufQSs6a1TqY0YRsjr7G0NwafY2fZJ/luh3qwf7Vh0KY/l5Oq8GloU7ER76GmoY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=L74QsX3P; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="L74QsX3P" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1787340923; bh=JvuSdU2NOvYivNrD9n2RJ/WKSyhX0/8eRQQFZc+/tC0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L74QsX3PXkIeTiQLqF3M0lPtYMBNUu8pMbOjby3hiZTd/EXaMTTvikCEZxWRudWkB oTpf3ObNb78foBUAzmDVXZz6ftUvUXh8sszU/+u08wvwMVUrel4TpGGY1FpOSRVmtz 3t8v0+piPID7S7Nb4ks+fcoOH+hiBxDTc21tOi3s5lbaa01ebhXnT6EaufujcC2vnv Bu87vJMgOcKHdG0iD15I+BHRtNXw9Axtil8jsskFYySePLl0RKm0kcbuFmm64RgeOY TnuCr9KYzBtDIHd7i8jR6K2MuPBPErd09SCwTtG0n82fyKLCQGlqLlWdYqvFupXIW5 Pw2ME6NyVYQ1w== Received: from vninja (unknown [100.64.1.54]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: gkiagia) by bali.collaboradmins.com (Postfix) with ESMTPSA id F134117E0C8D; Fri, 21 Aug 2026 21:35:22 +0200 (CEST) From: George Kiagiadakis To: linux-bluetooth@vger.kernel.org Cc: George Kiagiadakis Subject: [PATCH BlueZ 4/5] player: Report EBUSY from a busy Search() Date: Fri, 21 Aug 2026 22:34:48 +0300 Message-ID: <20260821193449.1336263-5-george.kiagiadakis@collabora.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260821193449.1336263-1-george.kiagiadakis@collabora.com> References: <20260821193449.1336263-1-george.kiagiadakis@collabora.com> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit media_folder_search() answered a request that arrived while another one was still pending with EINVAL, while media_folder_list_items(), media_folder_change_folder() and media_item_play() all answer EBUSY for the very same condition. The commit that added Search copied the error code from the argument check sitting directly above it, rather than from ChangeFolder, which had gained the identical busy check four days earlier and used EBUSY. Fixes: 0a232a434d4b ("audio/player: Add implementation of MediaFolder.Search") Assisted-by: Claude:claude-opus-5 valgrind --- profiles/audio/player.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/profiles/audio/player.c b/profiles/audio/player.c index 7c5ea5b62..4c94dcab4 100644 --- a/profiles/audio/player.c +++ b/profiles/audio/player.c @@ -826,7 +826,7 @@ static DBusMessage *media_folder_search(DBusConnection *conn, DBusMessage *msg, return btd_error_not_supported(msg); if (mp->msg != NULL) - return btd_error_failed(msg, strerror(EINVAL)); + return btd_error_failed(msg, strerror(EBUSY)); err = cb->cbs->search(mp, string, cb->user_data); if (err < 0) -- 2.54.0 (Apple Git-157)