From: sashiko-bot@kernel.org
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: wsa+renesas@sang-engineering.com, robh@kernel.org,
devicetree@vger.kernel.org, conor+dt@kernel.org,
linux-rtc@vger.kernel.org,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH v6 05/17] rtc: rzn1: Fix alarm range check truncation on 32-bit systems
Date: Fri, 21 Aug 2026 21:22:28 +0000 [thread overview]
Message-ID: <20260821212229.2C9B81F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260821211032.13554-6-prabhakar.mahadev-lad.rj@bp.renesas.com>
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> alarm and farest were declared as unsigned long, but
> rtc_tm_to_time64() returns time64_t (s64). On 32-bit systems where
> unsigned long is 32 bits, the assignment silently truncates the upper
> 32 bits of the timestamp.
>
> Fix by declaring alarm and farest as time64_t and replacing
> time_after() with a direct signed comparison, which is correct for
> time64_t values that will never realistically overflow.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com?part=5
next prev parent reply other threads:[~2026-08-21 21:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 21:10 [PATCH v6 00/17] Add RTC support for Renesas RZ/T2H and RZ/N2H SoCs Prabhakar
2026-08-21 21:10 ` [PATCH v6 01/17] dt-bindings: rtc: renesas,rzn1-rtc: Add RZ/T2H and RZ/N2H support Prabhakar
2026-08-21 21:19 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 02/17] rtc: rzn1: Handle EPROBE_DEFER for optional pps interrupt Prabhakar
2026-08-21 21:20 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 03/17] rtc: rzn1: Fix weekday underflow when alarm crosses month boundary Prabhakar
2026-08-21 21:26 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 04/17] rtc: rzn1: Handle unset alarm weekday in rzn1_rtc_read_alarm Prabhakar
2026-08-21 21:18 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 05/17] rtc: rzn1: Fix alarm range check truncation on 32-bit systems Prabhakar
2026-08-21 21:22 ` sashiko-bot [this message]
2026-08-21 21:10 ` [PATCH v6 06/17] rtc: rzn1: Disable alarm interrupt before reprogramming alarm registers Prabhakar
2026-08-21 21:26 ` sashiko-bot
2026-08-22 19:22 ` Wolfram Sang
2026-08-21 21:10 ` [PATCH v6 07/17] rtc: rzn1: Fix malformed MODULE_AUTHOR string Prabhakar
2026-08-21 21:13 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 08/17] rtc: Kconfig: Broaden RTC_DRV_RZN1 dependency to ARCH_RENESAS Prabhakar
2026-08-21 21:15 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 09/17] rtc: rzn1: Use pm_runtime_put_sync() Prabhakar
2026-08-21 21:19 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 10/17] rtc: rzn1: Replace remove callback with devm_add_action_or_reset() Prabhakar
2026-08-21 21:17 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 11/17] rtc: rzn1: Dynamically calculate synchronization delay based on clock rate Prabhakar
2026-08-21 21:16 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 12/17] rtc: rzn1: Use temporary variable for struct device Prabhakar
2026-08-21 21:18 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 13/17] rtc: rzn1: Consistently use dev_err_probe() Prabhakar
2026-08-21 21:17 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 14/17] rtc: rzn1: use FIELD_PREP/FIELD_GET and GENMASK for register access Prabhakar
2026-08-21 21:20 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 15/17] rtc: rzn1: Add OF match data to gate SUBU " Prabhakar
2026-08-21 21:20 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 16/17] rtc: rzn1: Drop trailing comma from OF match table sentinel Prabhakar
2026-08-21 21:18 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 17/17] rtc: rzn1: Add support for Renesas RZ/T2H and RZ/N2H SoCs Prabhakar
2026-08-21 21:25 ` sashiko-bot
2026-08-22 19:27 ` [PATCH v6 00/17] Add RTC " Wolfram Sang
2026-08-23 19:27 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260821212229.2C9B81F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.