From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: drivers/hid/hid-msi.c:1274 claw_rgb_queue_fn() warn: can 'drvdata' even be NULL?
Date: Fri, 21 Aug 2026 23:55:15 +0800 [thread overview]
Message-ID: <202608212345.DvQUBcaE-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: "Derek J. Clark" <derekjohn.clark@gmail.com>
CC: Jiri Kosina <jikos@kernel.org>
CC: Zhouwang Huang <honjow311@gmail.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 818bebeb63dd6bf5f4e07e145f6cdbace520a34c
commit: f27e2e3c80edb2ff09c3bb3ee1605c86c64fcaa8 HID: hid-msi: Add RGB control interface
date: 3 weeks ago
:::::: branch date: 13 hours ago
:::::: commit date: 3 weeks ago
config: csky-randconfig-r073-20260821 (https://download.01.org/0day-ci/archive/20260821/202608212345.DvQUBcaE-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 15.2.0
smatch: v0.5.0-9187-g5189e3fb
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: f27e2e3c80ed ("HID: hid-msi: Add RGB control interface")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202608212345.DvQUBcaE-lkp@intel.com/
smatch warnings:
drivers/hid/hid-msi.c:1274 claw_rgb_queue_fn() warn: can 'drvdata' even be NULL?
vim +/drvdata +1274 drivers/hid/hid-msi.c
f27e2e3c80edb2f Derek J. Clark 2026-07-20 1267
f27e2e3c80edb2f Derek J. Clark 2026-07-20 1268 static void claw_rgb_queue_fn(struct work_struct *work)
f27e2e3c80edb2f Derek J. Clark 2026-07-20 1269 {
f27e2e3c80edb2f Derek J. Clark 2026-07-20 1270 struct delayed_work *dwork = container_of(work, struct delayed_work, work);
f27e2e3c80edb2f Derek J. Clark 2026-07-20 1271 struct claw_drvdata *drvdata = container_of(dwork, struct claw_drvdata, rgb_queue);
f27e2e3c80edb2f Derek J. Clark 2026-07-20 1272 int ret;
f27e2e3c80edb2f Derek J. Clark 2026-07-20 1273
f27e2e3c80edb2f Derek J. Clark 2026-07-20 @1274 if (!drvdata)
f27e2e3c80edb2f Derek J. Clark 2026-07-20 1275 return;
f27e2e3c80edb2f Derek J. Clark 2026-07-20 1276
f27e2e3c80edb2f Derek J. Clark 2026-07-20 1277 scoped_guard(spinlock_irqsave, &drvdata->registration_lock) {
f27e2e3c80edb2f Derek J. Clark 2026-07-20 1278 /* Pairs with smp_store_release from cfg_setup_fn in system_wq context */
f27e2e3c80edb2f Derek J. Clark 2026-07-20 1279 if (!smp_load_acquire(&drvdata->rgb_registered))
f27e2e3c80edb2f Derek J. Clark 2026-07-20 1280 return;
f27e2e3c80edb2f Derek J. Clark 2026-07-20 1281 }
f27e2e3c80edb2f Derek J. Clark 2026-07-20 1282
f27e2e3c80edb2f Derek J. Clark 2026-07-20 1283 ret = claw_apply_rgb_state(drvdata);
f27e2e3c80edb2f Derek J. Clark 2026-07-20 1284 if (ret)
f27e2e3c80edb2f Derek J. Clark 2026-07-20 1285 dev_err(&drvdata->hdev->dev, "Failed to apply RGB state: %d\n", ret);
f27e2e3c80edb2f Derek J. Clark 2026-07-20 1286 }
f27e2e3c80edb2f Derek J. Clark 2026-07-20 1287
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-08-21 15:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202608212345.DvQUBcaE-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.