From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3759C5DF97 for ; Sat, 22 Aug 2026 08:01:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Tw87zrGtl9VW/2vD4ePhebjRxHJuzMa/BHCYIyt+2EA=; b=rnlhK3s967h4H3 oovAntjhi8lszRDL/1MLexMuvDXxVnVJAT3l7gq0TOyqEqxaVyfMUV3IkMt8ieLPcFcTta82z8SvD 5oyAKrPacOik4srX4s293GxADcD8qVKCIY0rkWzRCAQAp06GrTQsc3MTo9wIBNOEHTymBVWWU2EAt qygGst2cJJ0de+lOP3VTfasS1kXM8sjbqCWKj0MRZJLtNKtjWxAXZtF7nrsFVG25RrM7XG1zFImEo j2c3Iu0zHig1UEBv6kHRTHDcMoGKM0a2tGRboBPE207Fb+DePVO0inE9WJvgy8nxbEdRArdtJ54jK F3uMST1TPV9z4UHULfxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wxgf5-0000000ENEe-20U1; Sat, 22 Aug 2026 08:01:07 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wxgf2-0000000ENEQ-3IAn for linux-phy@lists.infradead.org; Sat, 22 Aug 2026 08:01:05 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 45C4140AA7; Sat, 22 Aug 2026 08:01:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC78A1F000E9; Sat, 22 Aug 2026 08:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787385664; bh=GdgTm5QXJSEbDVgDlYX7nwx6kwUendpjSOpV52p3aQo=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=DcbsuU85vNX+x2klQx/GevnB3mRagi7WqGmwPhbT4Fp0n02h5ZFzLEeFEYNraolJc gI5//s0e5lkBNl42rwGgTgz76yX2VZNKNg1FeTXAXrIvLZIJwhM/N3PcABwzeFVUjq Tv7VPuW+stXl3sWHl/xCWqunvMYqPOQIA+X/vRL067XJ5m24+1H3dsNX8UUs++6Nta GbmGUzCW3hSJm9T+z1Myu7ZiCCUhgxbp1dY0cGsszUzaFfBKuuTxxddWafhOvaK67M 7YvamZdwzDy9BM6bzs8o8Zks39ZGJN5phuYwaHYqD8kDpZQ6QwKlaZ7MkjMFLpWjOm KvzHJFoiGMsxw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 7/9] dt-bindings: arm: stm32: Switch st,stm32mp23/25-syscfg into simple-mfd To: "Marek Vasut" Cc: devicetree@vger.kernel.org, linux-phy@lists.infradead.org, vkoul@kernel.org, neil.armstrong@linaro.org, robh@kernel.org, olteanv@gmail.com, conor+dt@kernel.org In-Reply-To: <20260822074816.548662-8-marex@nabladev.com> References: <20260822074816.548662-1-marex@nabladev.com> <20260822074816.548662-8-marex@nabladev.com> Date: Sat, 22 Aug 2026 08:01:03 +0000 Message-Id: <20260822080103.AC78A1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg NCBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0NyaXRpY2FsXSBTdHJpY3RseSBl bmZvcmNpbmcgYHNpbXBsZS1tZmRgIGluIHRoZSBjb21wYXRpYmxlIGFycmF5IGJyZWFrcyBiYWNr d2FyZCBjb21wYXRpYmlsaXR5IHdpdGggZXhpc3RpbmcgZGV2aWNlIHRyZWVzLgotIFtIaWdoXSBU aGUgYGVuX3JlZmNudGAgYXRvbWljIHJlZmVyZW5jZSBjb3VudGVyIGlzIGxlYWtlZCBvbiBlcnJv ciBwYXRocyBpbiBgc3RtMzJfdXNiMnBoeV9lbmFibGUoKWAsIHBlcm1hbmVudGx5IGJyZWFraW5n IHRoZSBQSFkuCi0gW01lZGl1bV0gVGhlIGBhbGxPZjppZmAgY29uZGl0aW9uIGZvciBgc3Qsc3Rt MzJtcDIzLzI1LXN5c2NmZ2AgdXNlcyBgZW51bWAgZGlyZWN0bHkgb24gdGhlIGBjb21wYXRpYmxl YCBwcm9wZXJ0eSBhcnJheSwgYnlwYXNzaW5nIHRoZSB2YWxpZGF0aW9uIGJsb2NrLgotIFtMb3dd IFRoZSBgcGF0dGVyblByb3BlcnRpZXNgIHJlZ2V4IGluIHRoZSBzeXNjb24gcGFyZW50IGJpbmRp bmcgcmVqZWN0cyB0aGUgYHVzYi1waHlAYCBub2RlIG5hbWUgcmVjb21tZW5kZWQgYnkgdGhlIGNo aWxkIFBIWSBiaW5kaW5nLgotLQoKLS0tIFBhdGNoIFs3XTogW1BBVENIIHYzIDcvOV0gZHQtYmlu ZGluZ3M6IGFybTogc3RtMzI6IFN3aXRjaCBzdCxzdG0zMm1wMjMvMjUtc3lzY2ZnIGludG8gc2lt cGxlLW1mZCAtLS0KY29tbWl0IDRkZDhlYjc3YWNmMGViMmI0NmVhMDJkMDg4MjZiNGQ0OTBkZTNm YjQKQXV0aG9yOiBNYXJlayBWYXN1dCA8bWFyZXhAbmFibGFkZXYuY29tPgpkdC1iaW5kaW5nczog YXJtOiBzdG0zMjogU3dpdGNoIHN0LHN0bTMybXAyMy8yNS1zeXNjZmcgaW50byBzaW1wbGUtbWZk CgpUaGlzIGNvbW1pdCB1cGRhdGVzIHRoZSBTVE0zMiBzeXNjb24gYmluZGluZyB0byBjb252ZXJ0 IHRoZQpzdCxzdG0zMm1wMjMtc3lzY2ZnIGFuZCBzdCxzdG0zMm1wMjUtc3lzY2ZnIGNvbXBhdGli bGVzIGludG8gInNpbXBsZS1tZmQiLgpUaGlzIGFsbG93cyB0aGUgT1MgdG8gYXV0b21hdGljYWxs eSBwb3B1bGF0ZSB0aGUgc3Vibm9kZXMgZm9yIHRoZSBVU0IgMi4wCkZFTVRPLVBIWS4KCj4gZGlm ZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9hcm0vc3RtMzIvc3Qs c3RtMzItc3lzY29uLnlhbWwgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvYXJt L3N0bTMyL3N0LHN0bTMyLXN5c2Nvbi55YW1sCj4gaW5kZXggOTVkMjMxOWFmZTIzNS4uNGRiNDE5 OGM1ZGQ3YSAxMDA2NDQKPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv YXJtL3N0bTMyL3N0LHN0bTMyLXN5c2Nvbi55YW1sCj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL2FybS9zdG0zMi9zdCxzdG0zMi1zeXNjb24ueWFtbAo+IEBAIC0yMiwx MSArMjIsMTIgQEAgcHJvcGVydGllczoKPiAgICAgICAgICAgICAgICAtIHN0LHN0bTMybXAxNTEt cHdyLW1jdQo+ICAgICAgICAgICAgICAgIC0gc3Qsc3RtMzJtcDE1Ny1zeXNjZmcKPiAgICAgICAg ICAgICAgICAtIHN0LHN0bTMybXAyMS1zeXNjZmcKPiAtICAgICAgICAgICAgICAtIHN0LHN0bTMy bXAyMy1zeXNjZmcKPiAtICAgICAgICAgICAgICAtIHN0LHN0bTMybXAyNS1zeXNjZmcKPiAgICAg ICAgICAgIC0gY29uc3Q6IHN5c2Nvbgo+ICAgICAgICAtIGl0ZW1zOgo+IC0gICAgICAgICAgLSBj b25zdDogc3Qsc3RtMzItdGFtcAo+ICsgICAgICAgICAgLSBlbnVtOgo+ICsgICAgICAgICAgICAg IC0gc3Qsc3RtMzItdGFtcAo+ICsgICAgICAgICAgICAgIC0gc3Qsc3RtMzJtcDIzLXN5c2NmZwo+ ICsgICAgICAgICAgICAgIC0gc3Qsc3RtMzJtcDI1LXN5c2NmZwo+ICsgICAgICAgICAgLSBjb25z dDogc3lzY29uCj4gKyAgICAgICAgICAtIGNvbnN0OiBzaW1wbGUtbWZkCgpbU2V2ZXJpdHk6IENy aXRpY2FsXQpEb2VzIGVuZm9yY2luZyBzaW1wbGUtbWZkIGluIHRoaXMgYXJyYXkgYnJlYWsgYmFj a3dhcmQgY29tcGF0aWJpbGl0eT8KCk9sZGVyIGRldmljZSB0cmVlcyBkZWZpbmUgdGhlc2Ugc3lz Y2ZnIG5vZGVzIHVzaW5nIG9ubHkgc3Qsc3RtMzJtcDI1LXN5c2NmZwphbmQgc3lzY29uLiBNb3Zp bmcgdGhlbSBpbnRvIGEgc3RyaWN0IDMtaXRlbSBsaXN0IHJlcXVpcmluZyBzaW1wbGUtbWZkCmNh dXNlcyB2YWxpZGF0aW9uIHRvIGZhaWwgZm9yIGV4aXN0aW5nIERUQnMuCgo+IEBAIC0zOSw2ICs0 MCwxNyBAQCBwcm9wZXJ0aWVzOgo+ICAgICIjY2xvY2stY2VsbHMiOgo+ICAgICAgY29uc3Q6IDAK PiAgCj4gKyAgIiNhZGRyZXNzLWNlbGxzIjoKPiArICAgIGNvbnN0OiAxCj4gKwo+ICsgICIjc2l6 ZS1jZWxscyI6Cj4gKyAgICBjb25zdDogMQo+ICsKPiArcGF0dGVyblByb3BlcnRpZXM6Cj4gKyAg Il5waHlAWzAtOWEtZl0rJCI6Cj4gKyAgICB0eXBlOiBvYmplY3QKPiArICAgICRyZWY6IC9zY2hl bWFzL3BoeS9zdCxzdG0zMi11c2IycGh5LnlhbWwKCltTZXZlcml0eTogTG93XQpXaWxsIHRoaXMg cmVnZXggcmVqZWN0IHRoZSBub2RlIG5hbWVzIHJlY29tbWVuZGVkIGJ5IHRoZSBjaGlsZCBQSFkg YmluZGluZz8KClRoZSBjaGlsZCBiaW5kaW5nIGV4YW1wbGUgdXNlcyB1c2ItcGh5QDI0MDA6Cgog ICAgdXNiLXBoeUAyNDAwIHsKICAgICAgICBjb21wYXRpYmxlID0gInN0LHN0bTMybXAyNS11c2Iy cGh5MSI7Cgp3aGljaCBmYWlscyB0aGUgc3RyaWN0ZXIgXnBoeUBbMC05YS1mXSskIHBhdHRlcm4g ZGVmaW5lZCBoZXJlLgoKWyAuLi4gXQoKPiBAQCAtNTcsMTAgKzY5LDE0IEBAIGFsbE9mOgo+ICAg IC0gaWY6Cj4gICAgICAgIHByb3BlcnRpZXM6Cj4gICAgICAgICAgY29tcGF0aWJsZToKPiAtICAg ICAgICAgIGNvbnN0OiBzdCxzdG0zMm1wMjUtc3lzY2ZnCj4gKyAgICAgICAgICBlbnVtOgo+ICsg ICAgICAgICAgICAtIHN0LHN0bTMybXAyMy1zeXNjZmcKPiArICAgICAgICAgICAgLSBzdCxzdG0z Mm1wMjUtc3lzY2ZnCgpbU2V2ZXJpdHk6IE1lZGl1bV0KRG9lcyB0aGlzIGNvbmRpdGlvbmFsIGJs b2NrIGJ5cGFzcyBzY2hlbWEgdmFsaWRhdGlvbj8KCkFwcGx5aW5nIGVudW0gZGlyZWN0bHkgdG8g YW4gYXJyYXkgcHJvcGVydHkgY2hlY2tzIGlmIHRoZSBhcnJheSBzdHJpY3RseQplcXVhbHMgdGhl IHNjYWxhciBzdHJpbmcsIHdoaWNoIGFsd2F5cyBldmFsdWF0ZXMgdG8gZmFsc2UuIFNob3VsZCB0 aGlzIHVzZQpjb250YWluczogZW51bTogaW5zdGVhZD8KCj4gICAgICB0aGVuOgo+ICAgICAgICBy ZXF1aXJlZDoKPiAgICAgICAgICAtICIjY2xvY2stY2VsbHMiCj4gKyAgICAgICAgLSAiI2FkZHJl c3MtY2VsbHMiCj4gKyAgICAgICAgLSAiI3NpemUtY2VsbHMiCgpbU2V2ZXJpdHk6IEhpZ2hdCklz IHRoZXJlIGEgcmVmZXJlbmNlIGNvdW50ZXIgbGVhayBpbiBzdG0zMl91c2IycGh5X2VuYWJsZSgp IGludHJvZHVjZWQKZWFybGllciBpbiB0aGlzIHNlcmllcz8KCklmIGFuIHVuc3VwcG9ydGVkIGNs b2NrIHJhdGUgaXMgZGV0ZWN0ZWQsIHRoZSBmdW5jdGlvbiByZXR1cm5zIHdpdGhvdXQKZGVjcmVt ZW50aW5nIGVuX3JlZmNudDoKCmRyaXZlcnMvcGh5L3N0L3BoeS1zdG0zMi11c2IycGh5LmM6c3Rt MzJfdXNiMnBoeV9lbmFibGUoKSB7CiAgICAuLi4KICAgIGlmICguLi4pCiAgICAgICAgLi4uCiAg ICBlbHNlCiAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cn0KCkFkZGl0aW9uYWxseSwgdGhlIGNvbW1v biBlcnJvciBwYXRocyBkbyBub3QgZGVjcmVtZW50IGVuX3JlZmNudCBhZnRlciBpdAp3YXMgaW5j cmVtZW50ZWQ6Cgpkcml2ZXJzL3BoeS9zdC9waHktc3RtMzItdXNiMnBoeS5jOnN0bTMyX3VzYjJw aHlfZW5hYmxlKCkgewogICAgLi4uCmVycm9yX3JlZ2RpczoKICAgIHJlZ3VsYXRvcl9kaXNhYmxl KHBoeV9kZXYtPnZkZDMzKTsKCiAgICByZXR1cm4gcmV0Owp9CgpGdXR1cmUgY2FsbHMgd2lsbCBz ZWUgZW5fcmVmY250ID4gMSBhbmQgcmV0dXJuIHN1Y2Nlc3MgaW1tZWRpYXRlbHksIGxlYXZpbmcK dGhlIFBIWSBkaXNhYmxlZC4KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hp a28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA4MjIwNzQ4MTYuNTQ4NjYyLTEtbWFyZXhAbmFibGFkZXYu Y29tP3BhcnQ9NwoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtcGh5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E33B39E9AC for ; Sat, 22 Aug 2026 08:01:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787385665; cv=none; b=Kk8EmyTKjLn685GtPSRpii45W4Fv/KyVCPbL57H0XmZpi79gxLSpJ+CRUEEkbHM4QA/DqnH2Xt8SBAaGSei60ZnV3Vaa7XN/nXQTY5jef6KkCVS8ANose3y/f1xKEu186Cy7T2HJ3jxC0lQ42s1BgINs/W9ohlmh9RhVZhAnbsw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787385665; c=relaxed/simple; bh=yvw2vbRd5X1bOwsM+e5eruLyDHJboJhgXp0kpagoZn4=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=g0qJk9hHGKQ/44HS/elFvAtNIXzn1GkkTN2Lc5yjLeINfpD4HTuPKYgBG601S2z5hbHYY0PcP4wLFMVKlGRQM8daKeGddPkwAGZcLBq5vM4ZfU8aMlwqDOBtkuERzDI/6HJZc+yMvYAnCbzMFi9PdBz74YsHL+Ka/6NzOipqHno= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DcbsuU85; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DcbsuU85" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC78A1F000E9; Sat, 22 Aug 2026 08:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787385664; bh=GdgTm5QXJSEbDVgDlYX7nwx6kwUendpjSOpV52p3aQo=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=DcbsuU85vNX+x2klQx/GevnB3mRagi7WqGmwPhbT4Fp0n02h5ZFzLEeFEYNraolJc gI5//s0e5lkBNl42rwGgTgz76yX2VZNKNg1FeTXAXrIvLZIJwhM/N3PcABwzeFVUjq Tv7VPuW+stXl3sWHl/xCWqunvMYqPOQIA+X/vRL067XJ5m24+1H3dsNX8UUs++6Nta GbmGUzCW3hSJm9T+z1Myu7ZiCCUhgxbp1dY0cGsszUzaFfBKuuTxxddWafhOvaK67M 7YvamZdwzDy9BM6bzs8o8Zks39ZGJN5phuYwaHYqD8kDpZQ6QwKlaZ7MkjMFLpWjOm KvzHJFoiGMsxw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 7/9] dt-bindings: arm: stm32: Switch st,stm32mp23/25-syscfg into simple-mfd Reply-To: sashiko-reviews@lists.linux.dev To: "Marek Vasut" Cc: devicetree@vger.kernel.org, linux-phy@lists.infradead.org, vkoul@kernel.org, neil.armstrong@linaro.org, robh@kernel.org, olteanv@gmail.com, conor+dt@kernel.org In-Reply-To: <20260822074816.548662-8-marex@nabladev.com> References: <20260822074816.548662-1-marex@nabladev.com> <20260822074816.548662-8-marex@nabladev.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 22 Aug 2026 08:01:03 +0000 Message-Id: <20260822080103.AC78A1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 4 potential issue(= s) to consider: - [Critical] Strictly enforcing `simple-mfd` in the compatible array breaks= backward compatibility with existing device trees. - [High] The `en_refcnt` atomic reference counter is leaked on error paths = in `stm32_usb2phy_enable()`, permanently breaking the PHY. - [Medium] The `allOf:if` condition for `st,stm32mp23/25-syscfg` uses `enum= ` directly on the `compatible` property array, bypassing the validation blo= ck. - [Low] The `patternProperties` regex in the syscon parent binding rejects = the `usb-phy@` node name recommended by the child PHY binding. -- --- Patch [7]: [PATCH v3 7/9] dt-bindings: arm: stm32: Switch st,stm32mp23/= 25-syscfg into simple-mfd --- commit 4dd8eb77acf0eb2b46ea02d08826b4d490de3fb4 Author: Marek Vasut dt-bindings: arm: stm32: Switch st,stm32mp23/25-syscfg into simple-mfd This commit updates the STM32 syscon binding to convert the st,stm32mp23-syscfg and st,stm32mp25-syscfg compatibles into "simple-mfd". This allows the OS to automatically populate the subnodes for the USB 2.0 FEMTO-PHY. > diff --git a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.= yaml b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml > index 95d2319afe235..4db4198c5dd7a 100644 > --- a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml > +++ b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml > @@ -22,11 +22,12 @@ properties: > - st,stm32mp151-pwr-mcu > - st,stm32mp157-syscfg > - st,stm32mp21-syscfg > - - st,stm32mp23-syscfg > - - st,stm32mp25-syscfg > - const: syscon > - items: > - - const: st,stm32-tamp > + - enum: > + - st,stm32-tamp > + - st,stm32mp23-syscfg > + - st,stm32mp25-syscfg > + - const: syscon > + - const: simple-mfd [Severity: Critical] Does enforcing simple-mfd in this array break backward compatibility? Older device trees define these syscfg nodes using only st,stm32mp25-syscfg and syscon. Moving them into a strict 3-item list requiring simple-mfd causes validation to fail for existing DTBs. > @@ -39,6 +40,17 @@ properties: > "#clock-cells": > const: 0 > =20 > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 > + > +patternProperties: > + "^phy@[0-9a-f]+$": > + type: object > + $ref: /schemas/phy/st,stm32-usb2phy.yaml [Severity: Low] Will this regex reject the node names recommended by the child PHY binding? The child binding example uses usb-phy@2400: usb-phy@2400 { compatible =3D "st,stm32mp25-usb2phy1"; which fails the stricter ^phy@[0-9a-f]+$ pattern defined here. [ ... ] > @@ -57,10 +69,14 @@ allOf: > - if: > properties: > compatible: > - const: st,stm32mp25-syscfg > + enum: > + - st,stm32mp23-syscfg > + - st,stm32mp25-syscfg [Severity: Medium] Does this conditional block bypass schema validation? Applying enum directly to an array property checks if the array strictly equals the scalar string, which always evaluates to false. Should this use contains: enum: instead? > then: > required: > - "#clock-cells" > + - "#address-cells" > + - "#size-cells" [Severity: High] Is there a reference counter leak in stm32_usb2phy_enable() introduced earlier in this series? If an unsupported clock rate is detected, the function returns without decrementing en_refcnt: drivers/phy/st/phy-stm32-usb2phy.c:stm32_usb2phy_enable() { ... if (...) ... else return -EINVAL; } Additionally, the common error paths do not decrement en_refcnt after it was incremented: drivers/phy/st/phy-stm32-usb2phy.c:stm32_usb2phy_enable() { ... error_regdis: regulator_disable(phy_dev->vdd33); return ret; } Future calls will see en_refcnt > 1 and return success immediately, leaving the PHY disabled. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260822074816.5486= 62-1-marex@nabladev.com?part=3D7