All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hongyan Xu <getshell@seu.edu.cn>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: Hongyan Xu <getshell@seu.edu.cn>,
	Loic Poulain <loic.poulain@oss.qualcomm.com>,
	Sergey Ryazanov <ryazanov.s.a@gmail.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH net v4] net: wwan: qcom_bam_dmux: fix TX DMA channel use-after-free
Date: Sat, 22 Aug 2026 16:52:13 +0800	[thread overview]
Message-ID: <20260822085214.1595-1-getshell@seu.edu.cn> (raw)
In-Reply-To: <20260815100454.695-1-getshell@seu.edu.cn>

Hi Stephan,

Thanks for the detailed review. I addressed the comments in v4:

- Replace pc_vote, pc_vote_acked, and pc_down_pending with the four-state
  bam_dmux_pc_vote enum.
- Remove the redundant dmux->rx check in bam_dmux_handle_pc().
- Use guard(mutex)() in runtime PM paths and devm_mutex_init() in probe.
- Let runtime_suspend() handle cleanup when runtime_resume() cannot acquire
  the TX channel, instead of calling bam_dmux_power_off() there.
- Request both state IRQs with IRQF_NO_AUTOEN, enable them only after the
  initial probe state is committed, and disable both before final remove
  cleanup.

The v4 patch is attached.

Regards,
Hongyan

  parent reply	other threads:[~2026-08-22  8:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-15 10:04 [PATCH net v3] net: wwan: qcom_bam_dmux: fix TX DMA channel use-after-free Hongyan Xu
2026-08-17 17:44 ` Stephan Gerhold
2026-08-22  8:52 ` Hongyan Xu [this message]
2026-08-22  8:53   ` [PATCH net v4] " Hongyan Xu
2026-08-24 14:58     ` Stephan Gerhold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260822085214.1595-1-getshell@seu.edu.cn \
    --to=getshell@seu.edu.cn \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ryazanov.s.a@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=stephan@gerhold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.