From: sashiko-bot@kernel.org
To: "Keke Ming" <ming.jvle@gmail.com>
Cc: linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2] uprobes: Free utask on dup_return_instance() failure
Date: Sat, 22 Aug 2026 15:16:13 +0000 [thread overview]
Message-ID: <20260822151613.D4A561F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260822150906.528208-1-ming.jvle@gmail.com>
> dup_utask() installs the new uprobe_task in t->utask before copying
> return_instances. If dup_return_instance() fails, the partially copied
> utask is left attached to the child task.
>
> Free the partially copied utask before returning -ENOMEM.
>
> Also, dup_return_instance() copies the return_instance before fixing
> up extra_consumers.
>
> Here, if no deep copy is needed, clear the copied extra_consumers
> pointer.
>
> Signed-off-by: Keke Ming <ming.jvle@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260822150906.528208-1-ming.jvle@gmail.com?part=1
next prev parent reply other threads:[~2026-08-22 15:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-22 5:46 [PATCH] uprobes: Free utask on dup_return_instance() failure Keke Ming
2026-08-22 6:00 ` sashiko-bot
2026-08-23 12:02 ` Masami Hiramatsu
2026-08-23 13:00 ` Keke Ming
2026-08-22 15:09 ` [PATCH v2] " Keke Ming
2026-08-22 15:16 ` sashiko-bot [this message]
2026-08-23 15:38 ` [PATCH] " Oleg Nesterov
2026-08-23 16:26 ` Keke Ming
2026-08-23 19:41 ` Oleg Nesterov
2026-08-24 11:22 ` Keke Ming
2026-08-24 15:57 ` Oleg Nesterov
2026-08-24 19:54 ` Andrii Nakryiko
2026-08-25 12:26 ` Oleg Nesterov
2026-08-25 16:38 ` Andrii Nakryiko
2026-08-25 18:23 ` SIGILL and uretprobes, WAS: " Andrii Nakryiko
2026-08-26 11:49 ` Oleg Nesterov
2026-08-27 16:44 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260822151613.D4A561F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=ming.jvle@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.