From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02BC6C5B572 for ; Sat, 22 Aug 2026 15:33:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=5v3cIjOCiE/XMNl5DoFmxJvCALd+lwRUASJR0O4POfM=; b=biPfX4+O7rQfb2hZ2e0dOOsxnk JPrPya7SwYy1sKPZbHiP3o9VuE9Evij9Ymqc06jkobhckPTiuBF2WONuqsjxMUViyY8P1MwVsUnHA LIf8Rmvmc9ssQBis5BjQ7N8NrQgW7RrZWnG7VAOZ3571e8vYMy9EWURCcU7zISlpe895en2PLeN0Q 4wMxcYjEFgTLkoJa/h5kc2XIRMnbSFBCCsiXmHEbeoZl0DtPc+7p/A5LLl+ks9IhL2SM2JOPP06Ax d0IFhHT5RX9OATN4kaZfu7unnyBuOu/E8co1rmQC6f8zlLQ2yDGsTPLyAWzZmgcaz2IMMmq5dlevV uNJ9sKrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wxniU-0000000Edwg-0UMy; Sat, 22 Aug 2026 15:33:06 +0000 Received: from smtpout-03.galae.net ([185.246.85.4]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wxniR-0000000Edw0-0gz2 for linux-arm-kernel@lists.infradead.org; Sat, 22 Aug 2026 15:33:05 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 0CF424E41342; Sat, 22 Aug 2026 15:32:58 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id C3397604C4; Sat, 22 Aug 2026 15:32:57 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 6B82211C77AD9; Sat, 22 Aug 2026 17:32:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1787412772; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding; bh=5v3cIjOCiE/XMNl5DoFmxJvCALd+lwRUASJR0O4POfM=; b=TAIkjK0J+tkwnhHpkKE4jytUtCstKMwZQIDq2DhElD8iSGunRYnYxxkUIU2y6xew3jkux5 HJmM59lAcBDIb04YvxuPtvE3DwqXOms9T7sStYEeUvnuUx9xld6Ep1iygx+lqw4E4Wpstg t/0Qu4cd9t6WlLqTmaRsfMYsIxONF0im/m8mDo/t53L2tE3SUEQtiEyT4y6epU/XqTv8Z5 O/OWVtmx/x5ssIL8Vtig7XwqVIeoEx69jl4kfVibDIQFVKb9FAK2etDu7teKLTLbky+1SM m9MdtJl+xGfOE2zDSlUr6qWGaitxXNTAbMgZMSO0weWHBphTx6T+FTRw2wNfiw== From: Maxime Chevallier To: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Heiner Kallweit , =?UTF-8?q?Alexis=20Lothor=C3=A9?= , Maxime Coquelin , Alexandre Torgue Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Nazim Amirul Subject: [PATCH net] net: stmmac: selftests: Pass the IP proto mask in the TC selftest Date: Sat, 22 Aug 2026 17:32:43 +0200 Message-ID: <20260822153245.423259-1-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260822_083303_353189_F37B5764 X-CRM114-Status: UNSURE ( 7.57 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The stmmac TC filtering rules have recently gained sanity checks to make sure the passed keys and their respective masks are aligned with the HW filtering abilities. The stmmac selftests failed to pass the mask in the match data for L4 filtering tests, and are now failing consistently with -EINVAL : $ ethtool -t eth1 [...] 23. L4 DA TCP Filtering -22 24. L4 SA TCP Filtering -22 25. L4 DA UDP Filtering -22 26. L4 SA UDP Filtering -22 Let's pass the ip_proto mask in the l4 filtering tests match data. Found on imx8mp, which now have passing L4 tests : $ ethtool -t eth1 [...] 23. L4 DA TCP Filtering 0 24. L4 SA TCP Filtering 0 25. L4 DA UDP Filtering 0 26. L4 SA UDP Filtering 0 Fixes: 5536d7c84363 ("net: stmmac: fix l3l4 filter rejecting unsupported offload requests") Signed-off-by: Maxime Chevallier --- drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c index 1df26c217f9a..e9be4d7cbb82 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c @@ -1489,6 +1489,8 @@ static int __stmmac_test_l4filt(struct stmmac_priv *priv, u32 dst, u32 src, keys.bkey.ip_proto = udp ? IPPROTO_UDP : IPPROTO_TCP; keys.key.src = htons(src); keys.key.dst = htons(dst); + /* Match the full IP proto field */ + masks.bmask.ip_proto = 0xff; masks.mask.src = src_mask; masks.mask.dst = dst_mask; -- 2.55.0