All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: <oe-kbuild@lists.linux.dev>
Cc: <lkp@intel.com>, Dan Carpenter <error27@gmail.com>
Subject: [android-common:android14-kiwi-6.1 226/226] drivers/dma-buf/heaps/page_pool.c:116 dmabuf_page_pool_create() warn: use 'gfp_mask' here instead of GFP_KERNEL?
Date: Sun, 23 Aug 2026 20:32:19 +0800	[thread overview]
Message-ID: <202608221811.Dujad3y9-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: cros-kernel-buildreports@googlegroups.com

tree:   https://android.googlesource.com/kernel/common android14-kiwi-6.1
head:   3d2b0075700eab3a7aa5b384a24ed78ffedc1c24
commit: 70ad75e771d15cdf21f43548ee47bb38b4c2f564 [226/226] ANDROID: dma-heap: Make the page-pool library built-in
:::::: branch date: 20 hours ago
:::::: commit date: 3 years, 5 months ago
config: x86_64-randconfig-161-20260822 (https://download.01.org/0day-ci/archive/20260822/202608221811.Dujad3y9-lkp@intel.com/config)
compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211)
smatch: v0.5.0-9187-g5189e3fb

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202608221811.Dujad3y9-lkp@intel.com/

smatch warnings:
drivers/dma-buf/heaps/page_pool.c:116 dmabuf_page_pool_create() warn: use 'gfp_mask' here instead of GFP_KERNEL?

vim +/gfp_mask +116 drivers/dma-buf/heaps/page_pool.c

d3b59a75e86384b John Stultz 2020-10-02  113  
d3b59a75e86384b John Stultz 2020-10-02  114  struct dmabuf_page_pool *dmabuf_page_pool_create(gfp_t gfp_mask, unsigned int order)
d3b59a75e86384b John Stultz 2020-10-02  115  {
d3b59a75e86384b John Stultz 2020-10-02 @116  	struct dmabuf_page_pool *pool = kmalloc(sizeof(*pool), GFP_KERNEL);
d3b59a75e86384b John Stultz 2020-10-02  117  	int i;
d3b59a75e86384b John Stultz 2020-10-02  118  
d3b59a75e86384b John Stultz 2020-10-02  119  	if (!pool)
d3b59a75e86384b John Stultz 2020-10-02  120  		return NULL;
d3b59a75e86384b John Stultz 2020-10-02  121  
d3b59a75e86384b John Stultz 2020-10-02  122  	for (i = 0; i < POOL_TYPE_SIZE; i++) {
d3b59a75e86384b John Stultz 2020-10-02  123  		pool->count[i] = 0;
d3b59a75e86384b John Stultz 2020-10-02  124  		INIT_LIST_HEAD(&pool->items[i]);
d3b59a75e86384b John Stultz 2020-10-02  125  	}
d3b59a75e86384b John Stultz 2020-10-02  126  	pool->gfp_mask = gfp_mask | __GFP_COMP;
d3b59a75e86384b John Stultz 2020-10-02  127  	pool->order = order;
d3b59a75e86384b John Stultz 2020-10-02  128  	mutex_init(&pool->mutex);
d3b59a75e86384b John Stultz 2020-10-02  129  
d3b59a75e86384b John Stultz 2020-10-02  130  	mutex_lock(&pool_list_lock);
d3b59a75e86384b John Stultz 2020-10-02  131  	list_add(&pool->list, &pool_list);
d3b59a75e86384b John Stultz 2020-10-02  132  	mutex_unlock(&pool_list_lock);
d3b59a75e86384b John Stultz 2020-10-02  133  
d3b59a75e86384b John Stultz 2020-10-02  134  	return pool;
d3b59a75e86384b John Stultz 2020-10-02  135  }
d3b59a75e86384b John Stultz 2020-10-02  136  EXPORT_SYMBOL_GPL(dmabuf_page_pool_create);
d3b59a75e86384b John Stultz 2020-10-02  137  

:::::: The code at line 116 was first introduced by commit
:::::: d3b59a75e86384b6d5302159fa89446ead81e71e ANDROID: dma-buf: heaps: Add a shrinker controlled page pool

:::::: TO: John Stultz <john.stultz@linaro.org>
:::::: CC: Greg Kroah-Hartman <gregkh@google.com>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-08-23 12:32 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202608221811.Dujad3y9-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=error27@gmail.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.