All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Arka Mondal <arkamondalofficial@gmail.com>,
	nuno.sa@analog.com, Michael.Hennerich@analog.com,
	dlechner@baylibre.com, andy@kernel.org,
	venkat.prashanth2498@gmail.com, rohitsarkar5398@gmail.com,
	linux@analog.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] iio: gyro: adis16136: fix unprotected debugfs reads
Date: Sat, 22 Aug 2026 22:39:22 +0100	[thread overview]
Message-ID: <20260822223922.7db1a013@jic23-huawei> (raw)
In-Reply-To: <aoAoCBgh048wLxtZ@ashevche-desk.local>

On Sat, 15 Aug 2026 11:49:12 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Fri, Aug 14, 2026 at 06:07:28PM +0900, Arka Mondal wrote:
> > The serial_number file operations are open coded and never call
> > debugfs_file_get(), which debugfs_create_file_unsafe() requires.
> > debugfs_remove_recursive() therefore does not wait for a read in
> > progress, and unbind frees the iio_dev underneath it.
> > 
> > Use debugfs_create_file() instead.  
> 
> Same question as per patch 1.
> But if Jonathan likes as is
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 

I haven't looked into the tradeoffs fo the two possible solutions,
so would like v2 to have a cover letter and for that to state why
one was chosen over the other.

Thanks

Jonathan

  reply	other threads:[~2026-08-22 21:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14  9:07 [PATCH 1/3] iio: imu: adis16480: fix unprotected debugfs reads Arka Mondal
2026-08-14  9:07 ` [PATCH 2/3] iio: imu: adis16400: " Arka Mondal
2026-08-15  8:42   ` Andy Shevchenko
2026-08-22 21:37     ` Jonathan Cameron
2026-08-24  8:29       ` Andy Shevchenko
2026-08-14  9:07 ` [PATCH 3/3] iio: gyro: adis16136: " Arka Mondal
2026-08-15  8:49   ` Andy Shevchenko
2026-08-22 21:39     ` Jonathan Cameron [this message]
2026-08-15  8:47 ` [PATCH 1/3] iio: imu: adis16480: " Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260822223922.7db1a013@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=arkamondalofficial@gmail.com \
    --cc=dlechner@baylibre.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=rohitsarkar5398@gmail.com \
    --cc=venkat.prashanth2498@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.