From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE64F37E2EE; Sat, 22 Aug 2026 21:55:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787435760; cv=none; b=b8gwvUW2gkoRGt5erbJPx6ovO0vdKg5eMfYug5j5b82d9ot2++BeIDUOHt+SngsriKuFu+itpE7f+x8t2YKCLj+2RywkBZpALsfZr4kIg/5kOu2z5afJwZd29hLDzJd2iNFFfUiFAQQflQByu0Q9byZY1HtmC4Ia3rQEok2teWQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787435760; c=relaxed/simple; bh=QoU2uojzCaepY3mq9/oAzpRjccpQG+T1o2is5hBq9Bo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=a372/xIs8dvxiCdICjNW44QAdVQiX6Y2HWCQwia/NDBanEvyNk1zNQAzXbIQzClnQdETWqS//pi7ujdN16DKw79CIfzXeq/x86oKV4jH3RfpwfJeYIyow8ylDyZ9/ok9UB2b5DlE6vragYU9/U6zE4hqTSnOKlol1GeltKlfpOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CL8X9ssa; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CL8X9ssa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6526A1F000E9; Sat, 22 Aug 2026 21:55:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787435758; bh=/3yifFywdCNpI7vIXFjsnCMF3wXJGkA4SAevNdiCqL0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=CL8X9ssaiHX6ePnpHCPFwynmXd3Vb+TsH0RKgBZW/w2kcz9uMScrSmtd9EDm3V/8d DeT8gOEcpevwTB5pVRvHGgfaLuOtMfR524OTsMHmZWXwo22AG7goOVStRiiS2pVVN2 ITEZQrLlvLB0Q4tvC2sZeXa8zlXu7blbgrVWZ/S/jJ6YegJweuoArE1nXjsnuzVLyx QTBMFBluXUkgefXGVKecWGBdASo5S+ZsEZH9lQ1ET3Dl82WVkbH0jQlrUu0vN9spZg FTm1x3fG+0XKXBh9RT7Y6ZMrbWd5gX23svdpiubutG1GZW+05DpTuDnax/AIOjc7nP T+peq9fJRLAIA== Date: Sat, 22 Aug 2026 22:55:52 +0100 From: Jonathan Cameron To: Yash Suthar Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, andriy.shevchenko@intel.com, grondon@gmail.com, linusw@kernel.org, hexlabsecurity@proton.me, sakari.ailus@linux.intel.com, srinivas.pandruvada@linux.intel.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] iio: accel: bmc150: use aligned scan buffer for both trigger and fifo Message-ID: <20260822225552.0c66a6b7@jic23-huawei> In-Reply-To: <20260815175728.99541-2-yashsuthar983@gmail.com> References: <20260815175728.99541-1-yashsuthar983@gmail.com> <20260815175728.99541-2-yashsuthar983@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 15 Aug 2026 23:27:26 +0530 Yash Suthar wrote: > Drop buffer as duplicate and s16 is not correct we needed __le16 as little > endian, keep scan at the end of the bmc150_accel_data struct with > IIO_DMA_MINALIGN, and use it for both paths. > > Fixes: bd7fe5b71918 ("iio: accel: BMC150 accel support") > Suggested-by: Jonathan Cameron > Signed-off-by: Yash Suthar > --- > drivers/iio/accel/bmc150-accel-core.c | 4 ++-- > drivers/iio/accel/bmc150-accel.h | 14 +++++--------- > 2 files changed, 7 insertions(+), 11 deletions(-) > > diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c > index dc8a6285cf3d..89a475ef9a9b 100644 > --- a/drivers/iio/accel/bmc150-accel-core.c > +++ b/drivers/iio/accel/bmc150-accel-core.c > @@ -1191,12 +1191,12 @@ static irqreturn_t bmc150_accel_trigger_handler(int irq, void *p) > > mutex_lock(&data->mutex); > ret = regmap_bulk_read(data->regmap, BMC150_ACCEL_REG_XOUT_L, > - data->buffer, AXIS_MAX * 2); > + data->scan.channels, AXIS_MAX * 2); Even nicer if you replace AXIS_MAX * 2 with sizeof(data->scan.channels) and also drop the AXIS_MAX definition as no longer used. > mutex_unlock(&data->mutex); > if (ret < 0) > goto err_read; > > - iio_push_to_buffers_with_timestamp(indio_dev, data->buffer, > + iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, > pf->timestamp); > err_read: > iio_trigger_notify_done(indio_dev->trig); > diff --git a/drivers/iio/accel/bmc150-accel.h b/drivers/iio/accel/bmc150-accel.h > index e8f26198359f..9deff256aed5 100644 > --- a/drivers/iio/accel/bmc150-accel.h > +++ b/drivers/iio/accel/bmc150-accel.h > @@ -64,15 +64,6 @@ struct bmc150_accel_data { > struct bmc150_accel_trigger triggers[BMC150_ACCEL_TRIGGERS]; > struct mutex mutex; > u8 fifo_mode, watermark; > - s16 buffer[8]; > - /* > - * Ensure there is sufficient space and correct alignment for > - * the timestamp if enabled > - */ > - struct { > - __le16 channels[3]; > - aligned_s64 ts; > - } scan; > u8 bw_bits; > u32 slope_dur; > u32 slope_thres; > @@ -85,6 +76,11 @@ struct bmc150_accel_data { > void (*resume_callback)(struct device *dev); > struct delayed_work resume_work; > struct iio_mount_matrix orientation; > + /* Ensure correct alignment of timestamp and DMA safety */ > + struct { > + __le16 channels[3]; > + aligned_s64 ts; > + } scan __aligned(IIO_DMA_MINALIGN); > }; > > int bmc150_accel_core_probe(struct device *dev, struct regmap *regmap, int irq,