From: Jonathan Cameron <jic23@kernel.org>
To: Gabriel Rondon <grondon@gmail.com>
Cc: "Andy Shevchenko" <andy@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Stepan Ionichev" <sozdayvek@gmail.com>,
"Maxwell Doose" <m32285159@gmail.com>,
"Yash Suthar" <yashsuthar983@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/3] iio: accel: bmc150: fix event-enable race, then use guard(mutex)
Date: Sat, 22 Aug 2026 23:14:13 +0100 [thread overview]
Message-ID: <20260822231413.6f09cc09@jic23-huawei> (raw)
In-Reply-To: <20260816234231.14168-1-grondon@gmail.com>
On Mon, 17 Aug 2026 00:42:28 +0100
Gabriel Rondon <grondon@gmail.com> wrote:
> This series addresses what came out of the v3 review of the
> guard(mutex) conversion [1]: the pre-existing bugs had to be fixed
> before the conversion could go in.
>
> The unaligned-timestamp / DMA-safety problem in the trigger path is
> no longer part of this series: it is fixed by Yash Suthar's
> "iio: accel: bmc150: DMA-safe buffers and use
> iio_push_to_buffers_with_ts()" v2 series [2], which this series is
> rebased on top of.
>
> Patch 1 sorts the header inclusions (suggested by Andy in the v3
> thread) so the cleanup.h include added later lands in order. Patch 2
> fixes the event-enable race in write_event_config(), where
> ev_enable_state was checked outside the lock. Patch 3 is the
> guard(mutex)/scoped_guard() conversion itself, now applying on top of
> the fixes.
>
> [1] https://lore.kernel.org/linux-iio/20260525110130.61284-1-grondon@gmail.com/
> [2] https://lore.kernel.org/linux-iio/20260815175728.99541-1-yashsuthar983@gmail.com/
>
Given I've asked for some changes to Yash's series, this will need
a rebase. So I've marked it as changes requested in patchwork.
Jonathan
> Changes in v4:
> - Turned into a series: prep and fix first, conversion last
> (Jonathan, v3 review)
> - Sorted header inclusions (Andy)
> - Fixed the ev_enable_state race under the lock, with Fixes: tag and
> Cc: stable
> - The unaligned-timestamp problem raised in the v3 review is fixed by
> [2] rather than by a patch here; the series is rebased on top of [2]
>
> Gabriel Rondon (3):
> iio: accel: bmc150: sort header inclusions alphabetically
> iio: accel: bmc150: take the lock before checking ev_enable_state
> iio: accel: bmc150: use guard(mutex) for mutex handling
>
> drivers/iio/accel/bmc150-accel-core.c | 92 ++++++++++-----------------
> 1 file changed, 33 insertions(+), 59 deletions(-)
>
prev parent reply other threads:[~2026-08-22 22:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-16 23:42 [PATCH v4 0/3] iio: accel: bmc150: fix event-enable race, then use guard(mutex) Gabriel Rondon
2026-08-16 23:42 ` [PATCH v4 1/3] iio: accel: bmc150: sort header inclusions alphabetically Gabriel Rondon
2026-08-17 15:35 ` Andy Shevchenko
2026-08-16 23:42 ` [PATCH v4 2/3] iio: accel: bmc150: take the lock before checking ev_enable_state Gabriel Rondon
2026-08-16 23:42 ` [PATCH v4 3/3] iio: accel: bmc150: use guard(mutex) for mutex handling Gabriel Rondon
2026-08-17 15:39 ` Andy Shevchenko
2026-08-18 15:41 ` Gabriel Rondon
2026-08-18 15:47 ` Andy Shevchenko
2026-08-22 22:11 ` Jonathan Cameron
2026-08-22 22:14 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260822231413.6f09cc09@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=grondon@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m32285159@gmail.com \
--cc=nuno.sa@analog.com \
--cc=sozdayvek@gmail.com \
--cc=yashsuthar983@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.