From: sashiko-bot@kernel.org
To: "Ahmad Byagowi" <ahmadexp@gmail.com>
Cc: conor+dt@kernel.org, robh@kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH v7 2/2] leds: is32fl3207: Add controller driver
Date: Sun, 23 Aug 2026 16:47:17 +0000 [thread overview]
Message-ID: <20260823164718.13FAB1F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <f04b85bbf71a09f372b1f248dbd2b1286a0ba903.1787502624.git.ahmadexp@gmail.com>
> Add an I2C driver for the Lumissil IS32FL3207 18-channel LED controller.
>
> Expose individual and multicolor LEDs through the LED class. Use the
> default 8-bit, 62 kHz PWM mode, derive output current from RISET, and
> enforce each output current limit with the scaling registers. Serialize
> multicolor calculation, scaling, PWM, and controller-wide update
> operations.
>
> Clear retained scaling while SDB holds the outputs disabled. Release SDB
> and briefly enable normal operation to issue the required software reset,
> then keep the controller in software shutdown while registering every LED.
> Enable outputs only after all limits and initial brightness values are
> programmed.
>
> Handle an optional supply and enable GPIO. Serialize shutdown against
> pending brightness updates and honor retained shutdown state.
>
> Signed-off-by: Ahmad Byagowi <ahmadexp@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1787502624.git.ahmadexp@gmail.com?part=2
next prev parent reply other threads:[~2026-08-23 16:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-23 16:35 [PATCH v7 0/2] leds: Add IS32FL3207 controller support Ahmad Byagowi
2026-08-23 16:35 ` [PATCH v7 1/2] dt-bindings: leds: Add IS32FL3207 controller Ahmad Byagowi
2026-08-23 16:40 ` sashiko-bot
2026-08-28 9:30 ` Krzysztof Kozlowski
2026-08-23 16:35 ` [PATCH v7 2/2] leds: is32fl3207: Add controller driver Ahmad Byagowi
2026-08-23 16:47 ` sashiko-bot [this message]
2026-09-10 12:35 ` Lee Jones
2026-09-10 16:56 ` Ahmad Byagowi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260823164718.13FAB1F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ahmadexp@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.