From: Jonathan Cameron <jic23@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Karl Mehltretter" <kmehltretter@gmail.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Ramona Gradinariu" <ramona.gradinariu@analog.com>,
linux-iio@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: iio: Correct ADXL380 filter descriptions
Date: Sun, 23 Aug 2026 18:47:08 +0100 [thread overview]
Message-ID: <20260823184708.41150cdf@jic23-huawei> (raw)
In-Reply-To: <1c0ea889-3a06-4691-a759-0cff624ccc92@infradead.org>
On Sat, 22 Aug 2026 11:19:09 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:
> On 8/22/26 11:07 AM, David Lechner wrote:
> > On 8/22/26 12:00 PM, Randy Dunlap wrote:
> >> Hi,
> >>
> >> On 8/22/26 12:36 AM, Karl Mehltretter wrote:
> >>> The high-pass attributes were described as low-pass filters and vice
> >>> versa. Correct all four descriptions.
> >>>
> >>> Fixes: b6a097a9af00 ("docs: iio: add documentation for adxl380 driver")
> >>> Assisted-by: Codex:gpt-5.6-sol
> >>> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> >>> ---
> >>> Documentation/iio/adxl380.rst | 8 ++++----
> >>> 1 file changed, 4 insertions(+), 4 deletions(-)
> >>>
> >>> diff --git a/Documentation/iio/adxl380.rst b/Documentation/iio/adxl380.rst
> >>> index 654d4c0e84a19..a1c249dc2e51c 100644
> >>> --- a/Documentation/iio/adxl380.rst
> >>> +++ b/Documentation/iio/adxl380.rst
> >>> @@ -39,13 +39,13 @@ specific device folder path ``/sys/bus/iio/devices/iio:deviceX``.
> >>> +---------------------------------------------------+----------------------------------------------------------+
> >>> | in_accel_scale | Scale for the accelerometer channels. |
> >>> +---------------------------------------------------+----------------------------------------------------------+
> >>> -| in_accel_filter_high_pass_3db_frequency | Low pass filter bandwidth. |
> >>> +| in_accel_filter_high_pass_3db_frequency | High pass filter bandwidth. |
> >>> +---------------------------------------------------+----------------------------------------------------------+
> >>> -| in_accel_filter_high_pass_3db_frequency_available | Available low pass filter bandwidth configurations. |
> >>> +| in_accel_filter_high_pass_3db_frequency_available | Available high pass filter bandwidth configurations. |
> >>> +---------------------------------------------------+----------------------------------------------------------+
> >>> -| in_accel_filter_low_pass_3db_frequency | High pass filter bandwidth. |
> >>> +| in_accel_filter_low_pass_3db_frequency | Low pass filter bandwidth. |
> >>> +---------------------------------------------------+----------------------------------------------------------+
> >>> -| in_accel_filter_low_pass_3db_frequency_available | Available high pass filter bandwidth configurations. |
> >>> +| in_accel_filter_low_pass_3db_frequency_available | Available low pass filter bandwidth configurations. |
> >>> +---------------------------------------------------+----------------------------------------------------------+
> >>> | in_accel_x_calibbias | Calibration offset for the X-axis accelerometer channel. |
> >>> +---------------------------------------------------+----------------------------------------------------------+
> >>
> >> These changes LGTM. Thanks.
> >>
> >> Although I am a bit confused. When I look at the adxl380 driver,
> >> I don't see any of these device attributes.
> >> The attributes with these names are in other drivers/iio/accel/
> >> drivers: bma180.c, mma8452.c, and sca3000.c
> >> Can someone try to explain this, please?
> >> thanks.
> >>
> >
> > The attributes come from:
> >
> > .info_mask_shared_by_type = \
> > BIT(IIO_CHAN_INFO_SCALE) | \
> > BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) | \
> > BIT(IIO_CHAN_INFO_HIGH_PASS_FILTER_3DB_FREQUENCY), \
> > .info_mask_shared_by_type_available = \
> > BIT(IIO_CHAN_INFO_SCALE) | \
> > BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) | \
> > BIT(IIO_CHAN_INFO_HIGH_PASS_FILTER_3DB_FREQUENCY), \
> >
> > in adxl380.c
>
> Thanks, David.
>
> for the patch:
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
Applied to the testing branch of iio.git.
That will get rebased on rc1 once available.
Thanks,
Jonathan
prev parent reply other threads:[~2026-08-23 17:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-22 7:36 [PATCH] docs: iio: Correct ADXL380 filter descriptions Karl Mehltretter
2026-08-22 8:05 ` Joshua Crofts
2026-08-22 17:00 ` Randy Dunlap
2026-08-22 18:07 ` David Lechner
2026-08-22 18:19 ` Randy Dunlap
2026-08-23 17:47 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260823184708.41150cdf@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=corbet@lwn.net \
--cc=dlechner@baylibre.com \
--cc=kmehltretter@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=ramona.gradinariu@analog.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.