From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC9373254B8 for ; Sun, 23 Aug 2026 22:35:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787524549; cv=none; b=N41VAPmSWrvMCORxtfNw4ZdPodcwEvA1QtzutzBe8fQj7ulzMc2LEA+4pM/3eGsLPGx4pQ9Saoq58R3XYNbglePlbNzmcj8SOKtGc8S8V6uBTF7yBCbA/0/EAxTwMIKv5C5a9IYHxp+8j7f5CzUiVPv/tZoyA4aNGdClBtOdWQ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787524549; c=relaxed/simple; bh=Ip0lyGoA2Miic59SKNbmu0BUyR+cjrkqL8nqG3DpgYk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=taJQjtKEB+FWKPP65faFbsyD//wKWQ93oAfRQKGPyUWVbDI/hyc4tIEHdzqwb7SdpKo3S43h+n9KYZZ+8u7cFL/K7kRx74EYKUFxWpvFfzJsZTcpZGkE2PFVtDA6qHYB0XvX0gVTE9BhC/vfFPgGJ0UpCMSva6IraS8V8Lb94+w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZpvXbGKQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gGlKel7Z; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZpvXbGKQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gGlKel7Z" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67NLS0WQ015759 for ; Sun, 23 Aug 2026 22:35:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nIN0AMCbgLBEPFv4SXzmm/tPfk0Y99JvEPLGbEfccxg=; b=ZpvXbGKQHYU3iCCl FePYFH+FG+05xZq0hwljaxcihCQtdmHtTgAowvhKYiJcTmEgX+o3LoYYrYGT/Zv6 PqNwUQIbcvRqjXzbcPlJQrU1SzBL/c7uLozOvWCXXOoTEe7f7sVi/0INvgU8HsS9 +OVGAsvDfONCf7UrpEb7/W434Gm8oMYYiCJmNed4FxFUBrlsiLHcyT6tFJ9zJP05 tX8BfZbmXOzPeztGHJ0G/dA+88jCgH9Oh6AV3dtLDLh6l48NdCaoCUj0xx3WUVlw Dd87XVwrEJx7bzEYV6oXITFZ3nKr+KTGcPDWPOk2Kfjhe/zsFIDO26J3Vw+c4YCD YBNbOg== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g74xhceg4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 23 Aug 2026 22:35:46 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-84e375d9736so2213345b3a.2 for ; Sun, 23 Aug 2026 15:35:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787524545; x=1788129345; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=nIN0AMCbgLBEPFv4SXzmm/tPfk0Y99JvEPLGbEfccxg=; b=gGlKel7ZMMwBegC4OBmnHzumBExNtt2Ts1JU6sf4iK/Jqa4SeQevJyXWehA90WNky/ C5VyTAvuOLTw3KEpWI6hE03g3/2kByMRN6of3fRwxjE1AacNmU0t9/ELQUJ20fUBfkA3 jVUDmAN3YK7lcLr2FQVgRNal5dXNnsTeiF7D7NMMVSurSGQYrg/4yJJOLQT5ea915H1C xSn+pnX4mBgkhuqlCdAdLWNt7EswEUXqnJyIRHbCo9z90TpZPYofYBfFCWk0Qdw6hlHB 39kzTV5gALD8MzQiOFCLWXE3+Pjl7Z91aoEhyKSbGpDe62Zu9v+3lfz3dX/SqLoOd3o4 RYmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787524545; x=1788129345; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nIN0AMCbgLBEPFv4SXzmm/tPfk0Y99JvEPLGbEfccxg=; b=PjT/IJ+G8pDxKC6j7/ZyxBzC0z8XaU2EAVKSl4KnAVUlNn/gkRmNJLnKVIEeECPZSC IKRjjEt62Mck4eb38oD3WLKXcgIEc5uhPD6UZyJVmZnzLAU27Rf0uzbCIHRcuWze9zx7 JpL1Om03xjBwNkFNE6oQCVrqsj+b56BWgEHdfKAmc7sJuQqfU0hHyE9agiitSB6wd7ni dKoX/5joGYDDfFgsQBkvFjmvpn8h96RVwN/yTa9fMsLYFrCJNtmDdTYbEwvmOlWFSH8a myI8PtkalrhK979GFVrG1/xWZ1/kQb9xqZOWMR3VKsP6TFOdpBSL8Hp/wCwcTGSkSTN5 UlgA== X-Forwarded-Encrypted: i=1; AHgh+RqvECjhbW4CzrbsIEnJWYXno2HClfPe/Ktdyk3qt3rgS/POdpGPSWl9XEAL47DQqdv39DlLJMCqa/25sT8=@vger.kernel.org X-Gm-Message-State: AFuF++njI9ytZdjnybwgzCGMoZauo2QxvfQ2j1aQHic1FTyBkgHzMGrm 29DIeGPxMHHAGC7r0Dt+55JirXiXPhYqfjBMF6f6UL362Rh35FDf+UrDs/GtWM3WQTgBpF7h3eg oEVHUBmVYkTAnYxEp+qTafHbfc0DWn2R2o2cSXizbP9TgtfNxkP6lCads/VeonfXRWlE= X-Gm-Gg: AR+sD12KBVA2dt53Nyvfw58sUv8wiGDDSjdKiZdWWo/Jc4mY6Fdok/I+Wnqen+Dg0hd 5hykbU4mk9EzkLL8Bw+Z0KEZ2dg3pmeTW/7EfpnHMxbgsR4kXn+rkDnz1HDeFEWX/4O8xFpgH50 U4dt2v35GTSwOCPQpLuflrt49daKBrh3ScKKWfDP/izSpw+XywseRkQuKsO9HcuK0+/Lj6Om7vh MCuJWvU1DaiPlPQiwe/ydjoHjrS3zNXUt31mYc7nb0VTilFvG3eMmFIyQX7/aWp4CVBFR3d7Sz3 SzOvZkZCwNv4cbVA0wK4X/XouU0SwP+VT632//9deSooTyjbtAF3KT0a4qluPa/GdRSC+XsezZS WVmkEVCkst4K1nF2f X-Received: by 2002:a05:6a00:80f:b0:847:8b0f:2508 with SMTP id d2e1a72fcca58-851f9fbafe6mr33424720b3a.13.1787524545572; Sun, 23 Aug 2026 15:35:45 -0700 (PDT) X-Received: by 2002:a05:6a00:80f:b0:847:8b0f:2508 with SMTP id d2e1a72fcca58-851f9fbafe6mr33424687b3a.13.1787524545196; Sun, 23 Aug 2026 15:35:45 -0700 (PDT) Received: from jic23-huawei ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8520f161c64sm1306926b3a.54.2026.08.23.15.35.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2026 15:35:44 -0700 (PDT) Date: Sun, 23 Aug 2026 23:35:36 +0100 From: Jonathan Cameron To: David Laight Cc: Nicolas Pitre , Borislav Betkov , Ingo Molnar , Thomas Gleinxer , Dave Hansen , x86@kernel.org, Andrew Morton , linux-kernel@vger.kernel.org, "H. Peter Anvin" , Peter Zijlstra , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , rodrigo.alencar@analog.com Subject: Re: [PATCH 0/2] x86: Use "er" asm constriant for add/sub Message-ID: <20260823233536.30b984ed@jic23-huawei> In-Reply-To: <20260803163955.627bdd3f@pumpkin> References: <20260803094702.3852-1-david.laight.linux@gmail.com> <11o7545n-7569-3p9r-1q77-8nor8513r6n1@syhkavp.arg> <20260803163955.627bdd3f@pumpkin> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: IODg3F3klZ-iQZfb_nTBGMmQJFjCmwaw X-Authority-Analysis: v=2.4 cv=GdQnWwXL c=1 sm=1 tr=0 ts=6a8b75c2 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=pGLkceISAAAA:8 a=dg4UtMH5AAAA:8 a=0WUTCY9Kkm9-_RlJLZ8A:9 a=CjuIK1q_8ugA:10 a=IoOABgeZipijB_acs4fv:22 a=byNfn09xH3PuSfgbYLsR:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIzMDIwNyBTYWx0ZWRfX7AhQ8Q6pqy2Y F6W79DdvxLUSpKLF7Bwd7d1koUFdFrk3fUBgajUwcVqr74iK4KmcOPPwKKmQZ+4iNbBBEVJaq3v Ldn9LeAJYtJHSW/WDAhlPydKIPR3FnST38vJs5JeS9ldHDMdlYPTKk0t6akSj/poz4gf6MIFves gNbSzppKTUustERe8FjT1V92nZd4rDC6KNOIQVi9BT1Ur5yFUKw6e3c41SQ8J1J/C4dQedVTe48 uXq6klY0Wtd+ruY1voswAfMQ3ZMrZwcKQJtg0UaiVH8OQN+m2XS+cLR/lgNBLCO+GHamH1hDY1N WdSf2A/qD6XUvQkY/GC2viAK1vmwC5vc8yWJaQ7KkYJ/ITmUxTpKpTIHzBS+YNkw0r4RKcHfY4M pweEs3wgnapRWgcYqgDnqsOqAr1cR+iL6UcKcHxvDcGNMdcDcToHG/qOE1n+EMj/ZAJOQyHM+mY 2ot778YFw3qKYQOz+Rg== X-Proofpoint-GUID: IODg3F3klZ-iQZfb_nTBGMmQJFjCmwaw X-Proofpoint-Spam-Info: AW1haW4tMjYwODIzMDIwNyBTYWx0ZWRfX1fVDVxHNZmg8 YHVboQpNXbBpjEVnjBLxxgn6hcDR2Z7tJfYM/mQt0jROAvU2o+cgjSymXHcsXBqjbyYgoRvVWfD DM2X11Ymh5BhkQBYBVaKvhsAnrEi3DA= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-23_07,2026-08-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 lowpriorityscore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608230207 On Mon, 3 Aug 2026 16:39:55 +0100 David Laight wrote: > On Mon, 3 Aug 2026 10:49:40 -0400 (EDT) > Nicolas Pitre wrote: > > > On Mon, 3 Aug 2026, David Laight wrote: > > > > > The x86 instruction set only supports 32bit signed immediate values > > > for add/sub. > > > Replace the "ir" constraint with "er" to avoid build errors. > > > > > > Found by a patch that added used mul_u64_add_u64_div_u64() to > > > do a rounding divide by 2^32 (perhaps not the best way to do this). > > > > > > A quick grep only found one other affected file. > > > > Would be a good idea adding those cases to the test module. > > They fail to compile so it isn't a big deal. > David, thanks for sorting this (and all for reviewing) Seems like everyone is happy. What route is this taking upstream? I held Rodrigo's driver to avoid the build breakage and would like to get it queued up early in next cycle. So not that urgent but nice to be able to tick it off the list! Thanks, Jonathan > David > > > > > > > Nicolas >