Re: [PATCH v3 17/17] arm64: dts: fsl: Add DT overlay to build MQS1 sound cards on i.MX9 platforms

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The device tree overlay defines audio DAPM routing referencing non-existent source widgets `MQS_L` and `MQS_R`, which will cause the sound card probe to fail with `-ENODEV`.
--

--- Patch [17]: [PATCH v3 17/17] arm64: dts: fsl: Add DT overlay to build MQS1 sound cards on i.MX9 platforms ---
commit 16b11b202a8f8c0d5f524ed9bbec5f9b49d2926e
Author: Chancel Liu <chancel.liu@nxp.com>

arm64: dts: fsl: Add DT overlay to build MQS1 sound cards on i.MX9 platforms

This commit adds a common DT overlay to support MQS sound cards on i.MX9
platforms. It routes SAI1 to MQS1, disables conflicting devices, and attaches
a board amplifier via DAPM routing.

> diff --git a/arch/arm64/boot/dts/freescale/imx9-mqs.dtso b/arch/arm64/boot/dts/freescale/imx9-mqs.dtso
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx9-mqs.dtso
[ ... ]
> +&{/} {
> +	sound-mqs {
> +		compatible = "audio-graph-card2";
> +		aux-devs = <&amp_mqs1>;
> +		label = "mqs-audio";
> +		links = <&sai1_port1>;
> +		routing = "MQS AMP INL", "MQS_L",
> +			  "MQS AMP INR", "MQS_R";

[Severity: High]
Will this cause the sound card probe to fail with -ENODEV?

Looking at the MQS codec driver (sound/soc/fsl/fsl_mqs.c), it only registers
a playback DAI with .stream_name = "Playback" and doesn't appear to define
.dapm_widgets exporting "MQS_L" or "MQS_R". 

Since the sound-mqs node lacks a widgets property to manually instantiate them
(e.g., widgets = "Line", "MQS_L", ...), won't snd_soc_dapm_add_route() fail
to find these source widgets and abort the initialization of the sound card?

> +	};
> +};
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824022020.2812810-1-chancel.liu@oss.nxp.com?part=17