Re: [PATCH v3 1/9] ASoC: dt-bindings: qcom,qaif-cpu: Add binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `clocks` and `clock-names` properties are artificially restricted to a maximum of 4 per-AIF bit clocks, preventing the configuration of AIF interfaces 4 through 12.
--

--- Patch [1]: [PATCH v3 1/9] ASoC: dt-bindings: qcom,qaif-cpu: Add binding ---
commit 4490a4ebecf0bd52b36566a5c2160dea592dd645
Author: Harendra Gautam <harendra.gautam@oss.qualcomm.com>

ASoC: dt-bindings: qcom,qaif-cpu: Add binding
    
This commit adds the device tree binding for the Qualcomm Audio Interface
(QAIF) CPU DAI controller. It describes the controller resources, AIF
interfaces, and named DAI constants for the sound card nodes.

> diff --git a/Documentation/devicetree/bindings/sound/qcom,qaif-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,qaif-cpu.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/qcom,qaif-cpu.yaml
[ ... ]
> +  clocks:
> +    minItems: 5
> +    maxItems: 9
> +
> +  clock-names:
> +    description:
> +      The first five clocks are always required. Any further entries are the
> +      per-AIF bit clocks (aif_if<N>_ibit), supplied in order starting from
> +      AIF interface 0 for as many serial AIF interfaces as the board uses.
> +    minItems: 5
> +    items:
> +      - const: lpass_config
> +      - const: lpass_core_axim
> +      - const: aud_dma
> +      - const: aud_dma_mem
> +      - const: bus
> +      - const: aif_if0_ibit
> +      - const: aif_if1_ibit
> +      - const: aif_if2_ibit
> +      - const: aif_if3_ibit

[Severity: Medium]
The description states the hardware supports up to 13 multi-lane Unified Audio
Interfaces, but the clocks property is restricted to a maximum of 9 items.
Does this artificially prevent the configuration of aif_if4_ibit through
aif_if12_ibit?

Any board attempting to configure AIF4 or higher would fail dt_binding_check
because the clock-names list is capped at aif_if3_ibit. Should maxItems and
the items list be expanded to accommodate all 13 possible interfaces?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824063627.3595610-1-harendra.gautam@oss.qualcomm.com?part=1