Re: [PATCH v3 1/1] drm/xe/guc: Report reset-request failure using SIGID

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch introduces a build breakage by referencing a non-existent header file (`xe_log.h`) and an undefined macro (`xe_log_err`). Additionally, it fails to implement the behavior promised in the commit message by passing the standard error code `-EIO` instead of the specified identifier `XE_SIGID_GT_TDR`.
--

--- Patch [1]: [PATCH v3 1/1] drm/xe/guc: Report reset-request failure using SIGID ---
commit 67003dc14864f3bc207ea53dfd2f7eb0b4972a51
Author: Arvind Yadav <arvind.yadav@intel.com>

drm/xe/guc: Report reset-request failure using SIGID

Route the GuC engine reset-request failure through the structured SIGID
logging helper.

> This path was already reported as an error and triggers GT reset recovery,
> so use the GT component and report it with XE_SIGID_GT_TDR.

[Severity: Medium]
The commit message mentions reporting the error with XE_SIGID_GT_TDR, but the
code below passes -EIO instead.

> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 864859bd0ccc9..0faeecc7c516d 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -34,6 +34,7 @@
>  #include "xe_guc_klv_helpers.h"
>  #include "xe_guc_submit_types.h"
>  #include "xe_hw_engine.h"
> +#include "xe_log.h"

[Severity: Medium]
Could this introduce a build breakage? It appears xe_log.h does not exist in
the repository.

[ ... ]

> @@ -3360,8 +3361,9 @@ int xe_guc_exec_queue_reset_failure_handler(struct xe_guc *guc, u32 *msg, u32 len
>  	reason = msg[2];
>  
>  	/* Unexpected failure of a hardware feature, log an actual error */
> -	xe_gt_err(gt, "GuC engine reset request failed on %d:%d because 0x%08X",
> -		  guc_class, instance, reason);
> +	xe_log_err(gt, GT, -EIO,
> +		   "GuC engine reset request failed on %d:%d because 0x%08X\n",
> +		   guc_class, instance, reason);

[Severity: Medium]
Is xe_log_err defined anywhere since xe_log.h is missing? It looks like this
might result in an undefined macro error during compilation.

Additionally, as noted above, this passes -EIO instead of the promised
XE_SIGID_GT_TDR identifier.

>  
>  	xe_gt_reset_async(gt);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824071749.1345374-2-arvind.yadav@intel.com?part=1