Re: [PATCH 1/3] arm64: dts: renesas: r9a09g077: Add RTC node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Build failure due to undefined macro `R9A09G077_PCLKRTC`.
--

--- Patch [1]: [PATCH 1/3] arm64: dts: renesas: r9a09g077: Add RTC node ---
commit 2ac601db99f828037f74c28a1b191a0855d1fe45
Author: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

arm64: dts: renesas: r9a09g077: Add RTC node

This patch adds the Real Time Clock (RTC) node to the Renesas R9A09G077 SoC
device tree include file.

> diff --git a/arch/arm64/boot/dts/renesas/r9a09g077.dtsi b/arch/arm64/boot/dts/renesas/r9a09g077.dtsi
> --- a/arch/arm64/boot/dts/renesas/r9a09g077.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a09g077.dtsi
[ ... ]
> @@ -1146,6 +1146,19 @@ pinctrl: pinctrl@802c0000 {
>  			power-domains = <&cpg>;
>  		};
>  
> +		rtc0: rtc@81009000 {
> +			compatible = "renesas,r9a09g077-rtc";
> +			reg = <0 0x81009000 0 0x1000>;
> +			interrupts = <GIC_SPI 495 IRQ_TYPE_EDGE_RISING>,
> +				     <GIC_SPI 497 IRQ_TYPE_EDGE_RISING>,
> +				     <GIC_SPI 496 IRQ_TYPE_EDGE_RISING>;
> +			interrupt-names = "alarm", "timer", "pps";
> +			clocks = <&cpg CPG_MOD 605>, <&cpg CPG_CORE R9A09G077_PCLKRTC>;

[Severity: Low]
Is there a missing prerequisite patch that defines R9A09G077_PCLKRTC?

Since R9A09G077_PCLKRTC is not defined in the tree, the C preprocessor leaves
it as a literal string. When dtc parses the file, it encounters the unquoted
string inside a cell array and throws a syntax error, causing a build failure
when compiling the device trees.

> +			clock-names = "hclk", "xtal";
> +			power-domains = <&cpg>;
> +			status = "disabled";
> +		};
> +
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824075936.2904336-1-prabhakar.mahadev-lad.rj@bp.renesas.com?part=1